Code Review for downports-jdk11u-dev2

Prepared by:goetz on Thu Jun 25 09:05:47 CEST 2020
Workspace:
Compare against: http://hg.openjdk.java.net/jdk-updates/jdk11u-dev
Compare against version:53306
Summary of changes: 229 lines changed: 222 ins; 4 del; 3 mod; 2397 unchg
Patch of changes: downports-jdk11u-dev2.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/parse1.cpp

rev 53307 : 8244719: CTW: C2 compilation fails with "assert(!VerifyHashTableKeys || _hash_lock == 0) failed: remove node from hash table before modifying it"
Summary: Fix Parse::Block::init_graph() to also count predecessors for exception blocks because they can have a direct bytecode jump to them resulting in this assertion failure.
Reviewed-by: kvn, thartmann
9 lines changed: 2 ins; 4 del; 3 mod; 2397 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/parsing/TestExceptionBlockWithPredecessors.jasm

rev 53307 : 8244719: CTW: C2 compilation fails with "assert(!VerifyHashTableKeys || _hash_lock == 0) failed: remove node from hash table before modifying it"
Summary: Fix Parse::Block::init_graph() to also count predecessors for exception blocks because they can have a direct bytecode jump to them resulting in this assertion failure.
Reviewed-by: kvn, thartmann
174 lines changed: 174 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/parsing/TestExceptionBlockWithPredecessorsMain.java

rev 53307 : 8244719: CTW: C2 compilation fails with "assert(!VerifyHashTableKeys || _hash_lock == 0) failed: remove node from hash table before modifying it"
Summary: Fix Parse::Block::init_graph() to also count predecessors for exception blocks because they can have a direct bytecode jump to them resulting in this assertion failure.
Reviewed-by: kvn, thartmann
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using webrev (vers 25.12-hg+openjdk.java.net).