Code Review for nashorn9

Prepared by:hannesw on Thu Dec 5 13:08:24 CET 2013
Workspace:/home/hannes/work/nashorn9
Summary of changes: 774 lines changed: 153 ins; 485 del; 136 mod; 17560 unchg
Patch of changes: nashorn9.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ClassGenerator.java

4 lines changed: 0 ins; 4 del; 0 mod; 369 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/ConstructorGenerator.java

6 lines changed: 0 ins; 6 del; 0 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/PrototypeGenerator.java

4 lines changed: 0 ins; 4 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw buildtools/nasgen/src/jdk/nashorn/internal/tools/nasgen/StringConstants.java

6 lines changed: 0 ins; 6 del; 0 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/AccessorPropertyDescriptor.java

1 line changed: 0 ins; 0 del; 1 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/ArrayBufferView.java

1 line changed: 0 ins; 0 del; 1 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/DataPropertyDescriptor.java

1 line changed: 0 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/GenericPropertyDescriptor.java

1 line changed: 0 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/Global.java

191 lines changed: 0 ins; 190 del; 1 mod; 1882 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeArguments.java

3 lines changed: 0 ins; 0 del; 3 mod; 343 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeArray.java

1 line changed: 0 ins; 0 del; 1 mod; 1419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeArrayBuffer.java

1 line changed: 0 ins; 0 del; 1 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeBoolean.java

1 line changed: 0 ins; 0 del; 1 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeDate.java

1 line changed: 0 ins; 0 del; 1 mod; 1351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeDebug.java

8 lines changed: 2 ins; 2 del; 4 mod; 221 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeError.java

1 line changed: 0 ins; 0 del; 1 mod; 380 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeEvalError.java

1 line changed: 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeJSAdapter.java

5 lines changed: 0 ins; 0 del; 5 mod; 746 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeJavaImporter.java

1 line changed: 0 ins; 0 del; 1 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeNumber.java

1 line changed: 0 ins; 0 del; 1 mod; 383 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeRangeError.java

1 line changed: 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeReferenceError.java

1 line changed: 0 ins; 0 del; 1 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeRegExp.java

1 line changed: 0 ins; 0 del; 1 mod; 930 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeRegExpExecResult.java

1 line changed: 0 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeStrictArguments.java

1 line changed: 0 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeString.java

1 line changed: 0 ins; 0 del; 1 mod; 1259 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeSyntaxError.java

1 line changed: 0 ins; 0 del; 1 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeTypeError.java

1 line changed: 0 ins; 0 del; 1 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/NativeURIError.java

1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/PrototypeObject.java

6 lines changed: 0 ins; 4 del; 2 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/objects/ScriptFunctionImpl.java

11 lines changed: 0 ins; 5 del; 6 mod; 313 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/PropertyMap.java

181 lines changed: 0 ins; 176 del; 5 mod; 825 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/ScriptObject.java

119 lines changed: 64 ins; 20 del; 35 mod; 3283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/SetMethodCreator.java

3 lines changed: 2 ins; 0 del; 1 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/WithObject.java

6 lines changed: 0 ins; 0 del; 6 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/linker/NashornGuards.java

4 lines changed: 0 ins; 0 del; 4 mod; 108 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/scripts/JO.java

1 line changed: 0 ins; 0 del; 1 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk/nashorn/internal/runtime/PropertyListeners.java (was src/jdk/nashorn/internal/runtime/PropertyListenerManager.java)

129 lines changed: 85 ins; 2 del; 42 mod; 135 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk/nashorn/internal/runtime/PropertyListener.java

66 lines changed: 0 ins; 66 del; 0 mod; 0 unchg

This code review page was prepared using /home/hannes/bin/webrev.sh (vers 23.18-hg).