Code Review for panama.dev

Prepared by:henryjen on Thu Nov 15 14:49:11 PST 2018
Workspace:/Users/hjen/ws/panama.dev
Compare against: ssh://hg.openjdk.java.net/panama/dev
Compare against version:qparent
Branch:foreign
Summary of changes: 1032 lines changed: 390 ins; 396 del; 246 mod; 3948 unchg
Patch of changes: panama.dev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/foreign/NativeTypes.java 

rev 53212 : imported patch SystemABI
7 lines changed: 0 ins; 0 del; 7 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/foreign/memory/LayoutType.java 

rev 53212 : imported patch SystemABI
9 lines changed: 6 ins; 0 del; 3 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/CallbackImplGenerator.java 

rev 53212 : imported patch SystemABI
34 lines changed: 22 ins; 3 del; 9 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/HeaderImplGenerator.java 

rev 53212 : imported patch SystemABI
26 lines changed: 12 ins; 9 del; 5 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/ScopeImpl.java 

rev 53213 : [mq]: upcallABI
3 lines changed: 0 ins; 0 del; 3 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/Util.java 

rev 53212 : imported patch SystemABI
rev 53213 : [mq]: upcallABI
58 lines changed: 46 ins; 11 del; 1 mod; 348 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/AbstractABI.java 

rev 53212 : imported patch SystemABI
12 lines changed: 9 ins; 0 del; 3 mod; 172 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/SystemABI.java 

rev 53212 : imported patch SystemABI
72 lines changed: 57 ins; 4 del; 11 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/sysv/x64/SysVx64ABI.java 

rev 53212 : imported patch SystemABI
rev 53213 : [mq]: upcallABI
71 lines changed: 47 ins; 19 del; 5 mod; 81 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/invokers/DirectNativeInvoker.java 

rev 53212 : imported patch SystemABI
20 lines changed: 5 ins; 7 del; 8 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/invokers/DirectSignatureShuffler.java 

rev 53212 : imported patch SystemABI
34 lines changed: 16 ins; 11 del; 7 mod; 412 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/invokers/DirectUpcallHandler.java 

rev 53213 : [mq]: upcallABI
45 lines changed: 12 ins; 19 del; 14 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/invokers/NativeInvoker.java 

rev 53212 : imported patch SystemABI
63 lines changed: 33 ins; 13 del; 17 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/invokers/UniversalNativeInvoker.java 

rev 53212 : imported patch SystemABI
63 lines changed: 13 ins; 38 del; 12 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/invokers/UniversalUpcallHandler.java 

rev 53213 : [mq]: upcallABI
42 lines changed: 10 ins; 25 del; 7 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/invokers/UpcallHandler.java 

rev 53212 : imported patch SystemABI
rev 53213 : [mq]: upcallABI
80 lines changed: 45 ins; 25 del; 10 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/invokers/VarargsInvoker.java 

rev 53212 : imported patch SystemABI
63 lines changed: 20 ins; 34 del; 9 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/memory/LayoutTypeImpl.java 

rev 53212 : imported patch SystemABI
2 lines changed: 1 ins; 0 del; 1 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/sysv/x64/StandardCall.java (was src/java.base/share/classes/jdk/internal/foreign/abi/sysv/x64/CallingSequenceBuilderImpl.java) 

rev 53212 : imported patch SystemABI
rev 53214 : [mq]: removeCSB
78 lines changed: 24 ins; 22 del; 32 mod; 456 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/abi/sysv/x64/StandardCallTest.java (was test/jdk/java/foreign/abi/sysv/x64/CallingSequenceBuilderTest.java) 

rev 53214 : [mq]: removeCSB
132 lines changed: 12 ins; 38 del; 82 mod; 409 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/AbstractCallingSequenceBuilderImpl.java

37 lines changed: 0 ins; 37 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java 

rev 53214 : [mq]: removeCSB
81 lines changed: 0 ins; 81 del; 0 mod; 0 unchg

This code review page was prepared using /Users/hjen/bin/webrev.ksh (vers 25.16-hg+openjdk.java.net).