Code Review for open

Prepared by:herrick on Mon Mar 11 14:16:07 EDT 2019
Workspace:/home/aherrick/sandbox/open
Branch:JDK-8200758-branch
Summary of changes: 1694 lines changed: 118 ins; 1247 del; 329 mod; 13122 unchg
Patch of changes: open.patch
Bug id: JDK-8219678 : CLI changes in jpackage
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppBundler.java

31 lines changed: 0 ins; 28 del; 3 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppImageBuilder.java

4 lines changed: 0 ins; 2 del; 2 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java

50 lines changed: 8 ins; 20 del; 22 mod; 850 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java

40 lines changed: 8 ins; 10 del; 22 mod; 695 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources.properties

37 lines changed: 0 ins; 36 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources_ja.properties

37 lines changed: 0 ins; 36 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/LinuxResources_zh_CN.properties

37 lines changed: 0 ins; 36 del; 1 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.postinst

1 line changed: 0 ins; 0 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.prerm

1 line changed: 0 ins; 0 del; 1 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/template.spec

2 lines changed: 0 ins; 0 del; 2 mod; 58 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppBundler.java

45 lines changed: 0 ins; 40 del; 5 mod; 378 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java

33 lines changed: 2 ins; 17 del; 14 mod; 944 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppStoreBundler.java

12 lines changed: 1 ins; 8 del; 3 mod; 364 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java

13 lines changed: 0 ins; 10 del; 3 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java

4 lines changed: 0 ins; 2 del; 2 mod; 481 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPkgBundler.java

12 lines changed: 0 ins; 11 del; 1 mod; 536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources.properties

61 lines changed: 0 ins; 61 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_ja.properties

61 lines changed: 0 ins; 61 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_zh_CN.properties

61 lines changed: 0 ins; 61 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/AbstractBundler.java

4 lines changed: 0 ins; 2 del; 2 mod; 192 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/AbstractImageBundler.java

23 lines changed: 1 ins; 18 del; 4 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java

86 lines changed: 37 ins; 21 del; 28 mod; 817 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundleParams.java

17 lines changed: 0 ins; 17 del; 0 mod; 385 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/BundlerParamInfo.java

25 lines changed: 0 ins; 25 del; 0 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/DeployParams.java

23 lines changed: 0 ins; 17 del; 6 mod; 584 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/EnumeratedBundlerParam.java

19 lines changed: 0 ins; 18 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/JLinkBundlerHelper.java

64 lines changed: 17 ins; 38 del; 9 mod; 438 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java

131 lines changed: 1 ins; 111 del; 19 mod; 762 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java

123 lines changed: 9 ins; 49 del; 65 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources.properties

106 lines changed: 9 ins; 92 del; 5 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_ja.properties

106 lines changed: 9 ins; 92 del; 5 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_zh_CN.properties

106 lines changed: 9 ins; 92 del; 5 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinAppBundler.java

28 lines changed: 0 ins; 25 del; 3 mod; 254 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinExeBundler.java

38 lines changed: 0 ins; 19 del; 19 mod; 852 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java

46 lines changed: 0 ins; 22 del; 24 mod; 1170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsAppImageBuilder.java

9 lines changed: 0 ins; 6 del; 3 mod; 440 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsBundlerParam.java

17 lines changed: 0 ins; 14 del; 3 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties

42 lines changed: 0 ins; 42 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties

42 lines changed: 0 ins; 42 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_zh_CN.properties

42 lines changed: 0 ins; 42 del; 0 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/template.iss

1 line changed: 0 ins; 0 del; 1 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/template.wxs

1 line changed: 0 ins; 0 del; 1 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java (was src/jdk.jpackage/share/classes/jdk/jpackage/internal/SecondaryLauncherArguments.java)

27 lines changed: 7 ins; 4 del; 16 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageAddLauncherBase.java (was test/jdk/tools/jpackage/createimage/JPackageCreateImageSecondaryLauncherBase.java)

2 lines changed: 0 ins; 0 del; 2 mod; 139 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageAddLauncherModuleTest.java (was test/jdk/tools/jpackage/createimage/JPackageCreateImageSecondaryLauncherModuleTest.java)

8 lines changed: 0 ins; 0 del; 8 mod; 44 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageAddLauncherTest.java (was test/jdk/tools/jpackage/createimage/JPackageCreateImageSecondaryLauncherTest.java)

8 lines changed: 0 ins; 0 del; 8 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/createimage/JPackageCreateImageTempRootTest.java (was test/jdk/tools/jpackage/createimage/JPackageCreateImageBuildRootTest.java)

8 lines changed: 0 ins; 0 del; 8 mod; 101 unchg

This code review page was prepared using /home/aherrick/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).