--- old/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java 2019-08-15 16:15:21.289711400 -0400 +++ new/src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java 2019-08-15 16:15:19.417675400 -0400 @@ -141,9 +141,7 @@ return (vendor + "-" + appName).replaceAll("\\s", ""); } catch (Exception e) { - if (Log.isDebug()) { - e.printStackTrace(); - } + Log.verbose(e); } return "unknown-MimeInfo.xml"; }, --- old/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java 2019-08-15 16:15:33.489146000 -0400 +++ new/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppImageBuilder.java 2019-08-15 16:15:31.632710300 -0400 @@ -789,7 +789,7 @@ Files.setPosixFilePermissions(path, pfp); } } catch (IOException e) { - Log.debug(e); + Log.verbose(e); } }) .filter(p -> Files.isRegularFile(p) && --- old/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java 2019-08-15 16:15:45.470176400 -0400 +++ new/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java 2019-08-15 16:15:43.613740700 -0400 @@ -184,7 +184,7 @@ Log.error("Found more than one key matching '" + key + "'"); return null; } - Log.debug("Using key '" + matchedKey + "'"); + Log.verbose("Using key '" + matchedKey + "'"); return matchedKey; } catch (IOException ioe) { Log.verbose(ioe); --- old/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java 2019-08-15 16:15:57.375205500 -0400 +++ new/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacCertificate.java 2019-08-15 16:15:55.503169500 -0400 @@ -112,7 +112,7 @@ "MMM dd kk:mm:ss yyyy z", Locale.ENGLISH); result = df.parse(output); } catch (IOException | ParseException ex) { - Log.debug(ex); + Log.verbose(ex); } return result; --- old/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java 2019-08-15 16:16:09.340635600 -0400 +++ new/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java 2019-08-15 16:16:07.515400500 -0400 @@ -272,7 +272,8 @@ protoDMG.getParentFile().mkdirs(); finalDMG.getParentFile().mkdirs(); - String hdiUtilVerbosityFlag = Log.isDebug() ? "-verbose" : "-quiet"; + String hdiUtilVerbosityFlag = VERBOSE.fetchFrom(params) ? + "-verbose" : "-quiet"; // create temp image ProcessBuilder pb = new ProcessBuilder( --- old/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AbstractBundler.java 2019-08-15 16:16:21.259264800 -0400 +++ new/src/jdk.jpackage/share/classes/jdk/jpackage/internal/AbstractBundler.java 2019-08-15 16:16:19.434029700 -0400 @@ -182,7 +182,7 @@ IOUtils.deleteRecursive( StandardBundlerParam.TEMP_ROOT.fetchFrom(params)); } catch (IOException e) { - Log.debug(e.getMessage()); + Log.verbose(e.getMessage()); } } } --- old/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java 2019-08-15 16:16:33.068691900 -0400 +++ new/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java 2019-08-15 16:16:31.243456800 -0400 @@ -114,7 +114,7 @@ for (String arg : args) { argList.add(arg); } - Log.debug ("\njpackage argument list: \n" + argList + "\n"); + Log.verbose ("\njpackage argument list: \n" + argList + "\n"); pos = 0; deployParams = new DeployParams(); @@ -158,7 +158,7 @@ VERBOSE ("verbose", OptionCategories.PROPERTY, () -> { setOptionValue("verbose", true); - Log.setVerbose(true); + Log.setVerbose(); }), RESOURCE_DIR("resource-dir", @@ -622,7 +622,7 @@ I18N.getString("message.bundle-created"), bundler.getName())); } catch (ConfigException e) { - Log.debug(e); + Log.verbose(e); if (e.getAdvice() != null) { throw new PackagerException(e, "MSG_BundlerConfigException", bundler.getName(), e.getMessage(), e.getAdvice()); @@ -632,7 +632,7 @@ bundler.getName(), e.getMessage()); } } catch (RuntimeException re) { - Log.debug(re); + Log.verbose(re); throw new PackagerException(re, "MSG_BundlerRuntimeException", bundler.getName(), re.toString()); } finally { --- old/src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java 2019-08-15 16:16:45.096523200 -0400 +++ new/src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java 2019-08-15 16:16:43.255687800 -0400 @@ -46,7 +46,7 @@ if (noArgs) { Log.info(I18N.getString("MSG_Help_no_args")); } else { - Platform platform = (Log.isDebug()) ? + Platform platform = (Log.isVerbose()) ? Platform.UNKNOWN : Platform.getPlatform(); String types; String pLaunchOptions; --- old/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Log.java 2019-08-15 16:16:56.921550600 -0400 +++ new/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Log.java 2019-08-15 16:16:55.065114900 -0400 @@ -41,12 +41,16 @@ private PrintWriter out = null; private PrintWriter err = null; - public Logger(boolean v) { - verbose = v; + // verbose defaults to true unless environment variable JPACKAGE_DEBUG + // is set to true. + // Then it is only set to true by using --verbose jpackage option + + public Logger() { + verbose = ("true".equals(System.getenv("JPACKAGE_DEBUG"))); } - public void setVerbose(boolean v) { - verbose = v; + public void setVerbose() { + verbose = true; } public boolean isVerbose() { @@ -85,43 +89,26 @@ } public void verbose(Throwable t) { - if (out != null && (Log.debug || verbose)) { + if (out != null && verbose) { t.printStackTrace(out); - } else if (Log.debug || verbose) { + } else if (verbose) { t.printStackTrace(System.out); } } public void verbose(String msg) { - if (out != null && (Log.debug || verbose)) { + if (out != null && verbose) { out.println(msg); - } else if (Log.debug || verbose) { - System.out.println(msg); - } - } - - public void debug(String msg) { - if (out != null && Log.debug) { - out.println(msg); - } else if (Log.debug) { + } else if (verbose) { System.out.println(msg); } } } private static Logger delegate = null; - private static boolean debug = - "true".equals(System.getenv("JPACKAGE_DEBUG")); - - public static void setLogger(Logger l) { - delegate = l; - if (l == null) { - delegate = new Logger(false); - } - } - public static Logger getLogger() { - return delegate; + public static void setLogger(Logger logger) { + delegate = (logger != null) ? logger : new Logger(); } public static void flush() { @@ -142,18 +129,14 @@ } } - public static void setVerbose(boolean v) { + public static void setVerbose() { if (delegate != null) { - delegate.setVerbose(v); + delegate.setVerbose(); } } public static boolean isVerbose() { - if (delegate != null) { - return delegate.isVerbose(); - } - - return false; // Off by default + return (delegate != null) ? delegate.isVerbose() : false; } public static void verbose(String msg) { @@ -167,29 +150,4 @@ delegate.verbose(t); } } - - public static void debug(String msg) { - if (delegate != null) { - delegate.debug(msg); - } - } - - public static void debug(Throwable t) { - try (ByteArrayOutputStream baos = new ByteArrayOutputStream()) { - try (PrintStream ps = new PrintStream(baos)) { - t.printStackTrace(ps); - } - debug(baos.toString()); - } catch (IOException e) { - e.printStackTrace(); - } - } - - public static boolean isDebug() { - return debug; - } - - public static void setDebug(boolean debug) { - Log.debug = debug; - } } --- old/src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java 2019-08-15 16:17:08.762178300 -0400 +++ new/src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java 2019-08-15 16:17:06.921342900 -0400 @@ -497,7 +497,6 @@ File applicationImage = null; if (PREDEFINED_APP_IMAGE.fetchFrom(params) != null) { applicationImage = PREDEFINED_APP_IMAGE.fetchFrom(params); - Log.debug("Using App Image from " + applicationImage); if (!applicationImage.exists()) { throw new RuntimeException( MessageFormat.format(I18N.getString( --- old/src/jdk.jpackage/share/classes/jdk/jpackage/main/Main.java 2019-08-15 16:17:20.665207200 -0400 +++ new/src/jdk.jpackage/share/classes/jdk/jpackage/main/Main.java 2019-08-15 16:17:18.839972100 -0400 @@ -46,8 +46,7 @@ */ public static void main(String... args) throws Exception { // Create logger with default system.out and system.err - Log.Logger logger = new Log.Logger(false); - Log.setLogger(logger); + Log.setLogger(null); int status = new jdk.jpackage.main.Main().execute(args); System.exit(status); @@ -63,7 +62,7 @@ */ public int execute(PrintWriter out, PrintWriter err, String... args) { // Create logger with provided streams - Log.Logger logger = new Log.Logger(false); + Log.Logger logger = new Log.Logger(); logger.setPrintWriter(out, err); Log.setLogger(logger); --- old/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java 2019-08-15 16:17:32.552635800 -0400 +++ new/src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java 2019-08-15 16:17:30.649399200 -0400 @@ -262,9 +262,7 @@ toolName, version)); return version; } catch (Exception e) { - if (Log.isDebug()) { - Log.verbose(e); - } + Log.verbose(e); return null; } }