--- old/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppStoreBundler.java 2019-07-23 09:00:30.524062000 -0400 +++ new/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppStoreBundler.java 2019-07-23 09:00:28.418008000 -0400 @@ -140,7 +140,7 @@ } // first, make sure we don't use the local signing key params.put(DEVELOPER_ID_APP_SIGNING_KEY.getID(), null); - File appLocation = prepareAppBundle(params, false); + File appLocation = prepareAppBundle(params); prepareEntitlements(params); --- old/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java 2019-07-23 09:00:44.050608900 -0400 +++ new/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java 2019-07-23 09:00:42.162960500 -0400 @@ -134,21 +134,17 @@ } } - protected File prepareAppBundle(Map params, - boolean pkg) throws PackagerException { + protected File prepareAppBundle(Map params) + throws PackagerException { File predefinedImage = StandardBundlerParam.getPredefinedAppImage(params); if (predefinedImage != null) { return predefinedImage; } File appImageRoot = APP_IMAGE_TEMP_ROOT.fetchFrom(params); - if (pkg) { - // create pkg in dmg - return new MacPkgBundler().bundle(params, appImageRoot); - } else { - return APP_BUNDLER.fetchFrom(params).doBundle( - params, appImageRoot, true); - } + + return APP_BUNDLER.fetchFrom(params).doBundle( + params, appImageRoot, true); } @Override --- old/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java 2019-07-23 09:00:56.733734100 -0400 +++ new/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java 2019-07-23 09:00:54.846085700 -0400 @@ -61,7 +61,7 @@ try { appImageDir.mkdirs(); - if (prepareAppBundle(params, true) != null && + if (prepareAppBundle(params) != null && prepareConfigFiles(params)) { File configScript = getConfig_Script(params); if (configScript.exists()) { --- old/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPkgBundler.java 2019-07-23 09:01:09.198453700 -0400 +++ new/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacPkgBundler.java 2019-07-23 09:01:07.264004100 -0400 @@ -138,9 +138,8 @@ IOUtils.writableOutputDir(outdir.toPath()); - File appImageDir = null; try { - appImageDir = prepareAppBundle(params, false); + File appImageDir = prepareAppBundle(params); if (appImageDir != null && prepareConfigFiles(params)) { --- old/test/jdk/tools/jpackage/macosx/base/OptionsBase.java 2019-07-23 09:01:21.556970800 -0400 +++ new/test/jdk/tools/jpackage/macosx/base/OptionsBase.java 2019-07-23 09:01:19.653722000 -0400 @@ -51,9 +51,11 @@ try(var br = new BufferedReader(new FileReader(log))) { var line = br.lines().reduce((a, b) -> b).orElse(null) .split("\t"); - disk = line[0].trim(); - testPkg(line[2].trim() + File.separator + TEST_NAME + - "-1.0.pkg"); + if ((line.length < 3) || !line[2].contains(TEST_NAME)) { + throw new AssertionError( + "expected attach output to contain test name: " + + TEST_NAME); + } } } finally { if (disk != null) {