Code Review for open

Prepared by:herrick on Wed Aug 28 09:19:58 EDT 2019
Workspace:/home/aherrick/sandbox.copy/open
Branch:JDK-8200758-branch
Summary of changes: 1576 lines changed: 111 ins; 13 del; 1452 mod; 12677 unchg
Patch of changes: open.patch
Bug id: JDK-8229979 : jpackage cleanup src files, help text, and javadoc
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxRpmBundler.java

2 lines changed: 0 ins; 0 del; 2 mod; 703 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/linux/native/libapplauncher/LinuxPlatform.cpp

4 lines changed: 1 ins; 0 del; 3 mod; 1076 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppStoreBundler.java

37 lines changed: 5 ins; 5 del; 27 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 467 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/macosx/native/libapplauncher/MacPlatform.mm

4 lines changed: 2 ins; 0 del; 2 mod; 501 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/AbstractAppImageBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/AddLauncherArguments.java

1 line changed: 0 ins; 0 del; 1 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java

1 line changed: 0 ins; 0 del; 1 mod; 793 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/Log.java

1 line changed: 0 ins; 0 del; 1 mod; 152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java

6 lines changed: 1 ins; 0 del; 5 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties

1 line changed: 0 ins; 0 del; 1 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_ja.properties

1 line changed: 0 ins; 0 del; 1 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_zh_CN.properties

1 line changed: 0 ins; 0 del; 1 mod; 273 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/jdk/jpackage/main/CommandLine.java

9 lines changed: 5 ins; 0 del; 4 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/share/classes/module-info.java

1 line changed: 0 ins; 0 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinExeBundler.java

2 lines changed: 1 ins; 0 del; 1 mod; 148 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WinMsiBundler.java

10 lines changed: 5 ins; 0 del; 5 mod; 1152 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsAppImageBuilder.java

2 lines changed: 1 ins; 0 del; 1 mod; 392 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsRegistry.java

2 lines changed: 1 ins; 0 del; 1 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libapplauncher/FilePath.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 466 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libapplauncher/WindowsPlatform.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 757 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/FileUtils.cpp

709 lines changed: 7 ins; 0 del; 702 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/FileUtils.h

42 lines changed: 20 ins; 0 del; 22 mod; 356 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/IconSwap.cpp

6 lines changed: 1 ins; 0 del; 5 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/Log.cpp

29 lines changed: 6 ins; 5 del; 18 mod; 184 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/Log.h

15 lines changed: 6 ins; 2 del; 7 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/ResourceEditor.cpp

123 lines changed: 0 ins; 0 del; 123 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/ResourceEditor.h

107 lines changed: 0 ins; 0 del; 107 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/SysInfo.h

5 lines changed: 2 ins; 0 del; 3 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/UniqueHandle.h

43 lines changed: 0 ins; 0 del; 43 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/Utils.cpp

4 lines changed: 2 ins; 0 del; 2 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/Utils.h

2 lines changed: 1 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/VersionInfoSwap.cpp

2 lines changed: 1 ins; 0 del; 1 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/WinErrorHandling.cpp

14 lines changed: 3 ins; 1 del; 10 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/WinErrorHandling.h

3 lines changed: 1 ins; 0 del; 2 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/WinSysInfo.cpp

4 lines changed: 1 ins; 0 del; 3 mod; 194 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/WindowsRegistry.cpp

18 lines changed: 7 ins; 0 del; 11 mod; 149 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/jpackage.cpp

10 lines changed: 5 ins; 0 del; 5 mod; 105 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libjpackage/tstrings.h

21 lines changed: 11 ins; 0 del; 10 mod; 405 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp

4 lines changed: 2 ins; 0 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/msiwrapper/Executor.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/msiwrapper/Executor.h

84 lines changed: 0 ins; 0 del; 84 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/msiwrapper/MsiWrapper.cpp

42 lines changed: 1 ins; 0 del; 41 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/msiwrapper/Resources.cpp

149 lines changed: 5 ins; 0 del; 144 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jpackage/windows/native/msiwrapper/Resources.h

8 lines changed: 3 ins; 0 del; 5 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/linux/base/MaintainerBase.java

1 line changed: 0 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/AddLauncherBase.java

1 line changed: 0 ins; 0 del; 1 mod; 171 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/share/ResourceTest.java

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/FileAssociationsInstallDirTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/FileAssociationsTest.java

6 lines changed: 0 ins; 0 del; 6 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/InstallDirTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/LicenseTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/RuntimeTest.java

1 line changed: 0 ins; 0 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/Test.java

1 line changed: 0 ins; 0 del; 1 mod; 56 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/WinDirChooserTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/WinMenuGroupTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/WinMenuTest.java

1 line changed: 0 ins; 0 del; 1 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/WinPerUserInstallTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/WinShortcutTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/tools/jpackage/windows/exe/WinUpgradeUUIDTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 55 unchg

This code review page was prepared using /home/aherrick/bin/webrev.ksh (vers 25.17-hg+openjdk.java.net).