# HG changeset patch # User igerasim # Date 1536690371 25200 # Tue Sep 11 11:26:11 2018 -0700 # Node ID 0953d04b3ca7d6eaf0552548b6536d38b931a621 # Parent 543a3fb81c4cf56d6ca98160bf7fefbc8a3ed4f2 [mq]: 8210347-Combine-subsequent-calls-to-Set-contains-and-Set-add diff --git a/src/java.base/share/classes/java/lang/ModuleLayer.java b/src/java.base/share/classes/java/lang/ModuleLayer.java --- a/src/java.base/share/classes/java/lang/ModuleLayer.java +++ b/src/java.base/share/classes/java/lang/ModuleLayer.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2014, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -790,8 +790,7 @@ // push in reverse order for (int i = layer.parents.size() - 1; i >= 0; i--) { ModuleLayer parent = layer.parents.get(i); - if (!visited.contains(parent)) { - visited.add(parent); + if (visited.add(parent)) { stack.push(parent); } } diff --git a/src/java.base/share/classes/java/lang/module/Configuration.java b/src/java.base/share/classes/java/lang/module/Configuration.java --- a/src/java.base/share/classes/java/lang/module/Configuration.java +++ b/src/java.base/share/classes/java/lang/module/Configuration.java @@ -601,8 +601,7 @@ // push in reverse order for (int i = layer.parents.size() - 1; i >= 0; i--) { Configuration parent = layer.parents.get(i); - if (!visited.contains(parent)) { - visited.add(parent); + if (visited.add(parent)) { stack.push(parent); } } diff --git a/src/java.base/share/classes/java/util/ServiceLoader.java b/src/java.base/share/classes/java/util/ServiceLoader.java --- a/src/java.base/share/classes/java/util/ServiceLoader.java +++ b/src/java.base/share/classes/java/util/ServiceLoader.java @@ -938,8 +938,7 @@ List parents = layer.parents(); for (int i = parents.size() - 1; i >= 0; i--) { ModuleLayer parent = parents.get(i); - if (!visited.contains(parent)) { - visited.add(parent); + if (visited.add(parent)) { stack.push(parent); } } diff --git a/src/java.base/share/classes/java/util/stream/DistinctOps.java b/src/java.base/share/classes/java/util/stream/DistinctOps.java --- a/src/java.base/share/classes/java/util/stream/DistinctOps.java +++ b/src/java.base/share/classes/java/util/stream/DistinctOps.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2012, 2013, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -170,8 +170,7 @@ @Override public void accept(T t) { - if (!seen.contains(t)) { - seen.add(t); + if (seen.add(t)) { downstream.accept(t); } }