< prev index next >
test/jdk/java/util/regex/RegExTest.java
Print this page
rev 55071 : 8224789: Parsing repetition count in regex does not detect numeric overflow
Reviewed-by: rriggs, bchristi
@@ -1,7 +1,7 @@
/*
- * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 1999, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
@@ -33,28 +33,41 @@
* 6350801 6676425 6878475 6919132 6931676 6948903 6990617 7014645 7039066
* 7067045 7014640 7189363 8007395 8013252 8013254 8012646 8023647 6559590
* 8027645 8035076 8039124 8035975 8074678 6854417 8143854 8147531 7071819
* 8151481 4867170 7080302 6728861 6995635 6736245 4916384 6328855 6192895
* 6345469 6988218 6693451 7006761 8140212 8143282 8158482 8176029 8184706
- * 8194667 8197462 8184692 8221431
+ * 8194667 8197462 8184692 8221431 8224789
*
* @library /test/lib
* @library /lib/testlibrary/java/lang
* @build jdk.test.lib.RandomFactory
* @run main RegExTest
* @key randomness
*/
-import java.util.function.Function;
-import java.util.regex.*;
+import java.io.BufferedReader;
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.InputStreamReader;
+import java.io.ObjectInputStream;
+import java.io.ObjectOutputStream;
+import java.math.BigInteger;
+import java.nio.CharBuffer;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
import java.util.Random;
import java.util.Scanner;
-import java.io.*;
-import java.nio.file.*;
-import java.util.*;
-import java.nio.CharBuffer;
+import java.util.function.Function;
import java.util.function.Predicate;
+import java.util.regex.Matcher;
+import java.util.regex.MatchResult;
+import java.util.regex.Pattern;
+import java.util.regex.PatternSyntaxException;
import jdk.test.lib.RandomFactory;
/**
* This is a test class created to check the operation of
* the Pattern and Matcher classes.
@@ -169,10 +182,11 @@
invalidFlags();
embeddedFlags();
grapheme();
expoBacktracking();
invalidGroupName();
+ illegalRepetitionRange();
if (failure) {
throw new
RuntimeException("RegExTest failed, 1st failure: " +
firstFailure);
@@ -4930,6 +4944,33 @@
}
}
}
report("Invalid capturing group names");
}
+
+ private static void illegalRepetitionRange() {
+ // huge integers > (2^31 - 1)
+ String n = BigInteger.valueOf(1L << 32)
+ .toString();
+ String m = BigInteger.valueOf(1L << 31)
+ .add(new BigInteger(80, generator))
+ .toString();
+ for (String rep : List.of("", "x", ".", ",", "-1", "2,1",
+ n, n + ",", "0," + n, n + "," + m, m, m + ",", "0," + m)) {
+ String pat = ".{" + rep + "}";
+ try {
+ Pattern.compile(pat);
+ failCount++;
+ System.out.println("Expected to fail. Pattern: " + pat);
+ } catch (PatternSyntaxException e) {
+ if (!e.getMessage().startsWith("Illegal repetition")) {
+ failCount++;
+ System.out.println("Unexpected error message: " + e.getMessage());
+ }
+ } catch (Throwable t) {
+ failCount++;
+ System.out.println("Unexpected exception: " + t);
+ }
+ }
+ report("illegalRepetitionRange");
+ }
}
< prev index next >