Code Review for jdk

Prepared by:iignatyev on Thu Jun 8 21:53:57 PDT 2017
Workspace:/Users/iignatye/ws/jdk10/jdk10/jdk
Compare against: ssh://hg.openjdk.java.net/jdk10/jdk10/jdk
Compare against version:17323
Summary of changes: 100 lines changed: 90 ins; 0 del; 10 mod; 19697 unchg
Changeset: jdk.changeset
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Class/forName/modules/TestDriver.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
rev 17325 : imported patch 8181759-1
4 lines changed: 3 ins; 0 del; 1 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Double/ParseHexFloatingPoint.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Integer/BitTwiddle.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Long/BitTwiddle.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 161 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Math/CubeRootTests.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Math/HypotTests.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Math/IeeeRecommendedTests.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 1711 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Math/Log1pTests.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Math/MultiplicationTests.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/ProcessHandle/Basic.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
6 lines changed: 6 ins; 0 del; 0 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/ProcessHandle/InfoTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
6 lines changed: 5 ins; 0 del; 1 mod; 433 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/ProcessHandle/OnExitTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
6 lines changed: 5 ins; 0 del; 1 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/ProcessHandle/TreeTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
5 lines changed: 5 ins; 0 del; 0 mod; 472 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/StackTraceElement/WithClassLoaderName.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/StackWalker/StackWalkTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 352 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/StrictMath/CubeRootTests.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/StrictMath/ExpTests.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 146 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/StrictMath/HypotTests.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 742 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/String/CompactString/SerializationTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/String/LiteralReplace.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 286 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/StringBuffer/CompactStringBufferSerialization.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/StringBuilder/CompactStringBuilderSerialization.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 140 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/Thread/ThreadStateTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/invoke/LFCaching/LFGarbageCollectedTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 153 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/invoke/MethodHandles/CatchExceptionTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 534 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/lang/ref/CleanerTest.java

rev 17326 : imported patch 8181759-2
6 lines changed: 5 ins; 0 del; 1 mod; 722 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/math/BigDecimal/StringConstructor.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 164 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/math/BigInteger/BigIntegerTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 1355 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/math/BigInteger/ModPow65537.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/math/BigInteger/PrimeTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/nio/Buffer/LimitDirectMemoryNegativeTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
6 lines changed: 6 ins; 0 del; 0 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/Base64/TestBase64.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 593 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/List/SubList.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 675 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/WeakHashMap/GCDuringIteration.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/concurrent/ThreadPoolExecutor/ConfigChanges.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
2 lines changed: 1 ins; 0 del; 1 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/logging/FileHandlerMaxLocksTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
rev 17325 : imported patch 8181759-1
2 lines changed: 2 ins; 0 del; 0 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/regex/RegExTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 4843 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/zip/InflaterInputStream/TestAvailable.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
1 line changed: 1 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/zip/ZipFile/MultiThreadedReadTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
rev 17325 : imported patch 8181759-1
2 lines changed: 2 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/zip/ZipFile/ReadLongZipFileName.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
rev 17325 : imported patch 8181759-1
3 lines changed: 3 ins; 0 del; 0 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/java/util/zip/ZipFile/ZipEntryFreeTest.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
rev 17325 : imported patch 8181759-1
2 lines changed: 2 ins; 0 del; 0 mod; 129 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/internal/ref/Cleaner/ExitOnThrow.java

rev 17326 : imported patch 8181759-2
6 lines changed: 4 ins; 0 del; 2 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/internal/util/jar/TestVersionedStream.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
rev 17325 : imported patch 8181759-1
2 lines changed: 2 ins; 0 del; 0 mod; 226 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/jdk/modules/incubator/ImageModules.java

rev 17324 : 8181759: add explicit @build actions for jdk.test.lib classes in all :tier1 tests
Reviewed-by: duke
rev 17325 : imported patch 8181759-1
3 lines changed: 2 ins; 0 del; 1 mod; 383 unchg

Cdiffs Udiffs Sdiffs Frames Old New ----- Raw test/sun/misc/SunMiscSignalTest.java

rev 17326 : imported patch 8181759-2
6 lines changed: 5 ins; 0 del; 1 mod; 439 unchg

This code review page was prepared using /Users/iignatye/ws/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).