# HG changeset patch # User iignatyev # Date 1490152064 25200 # Tue Mar 21 20:07:44 2017 -0700 # Node ID 7b795cf64302f1a8958ac6bbd712ed311d9a3830 # Parent 13c06d444258db40958b671e2a17ec31ce707ef1 8177374: fix module dependency declaration in jdk_svc tests Reviewed-by: duke diff --git a/test/com/sun/tools/attach/BasicTests.java b/test/com/sun/tools/attach/BasicTests.java --- a/test/com/sun/tools/attach/BasicTests.java +++ b/test/com/sun/tools/attach/BasicTests.java @@ -40,16 +40,17 @@ /* * @test * @bug 6173612 6273707 6277253 6335921 6348630 6342019 6381757 - * @summary Basic unit tests for the VM attach mechanism. * @key intermittent + * @summary Basic unit tests for the VM attach mechanism. This test will perform + * a number of basic attach tests. + * * @library /lib/testlibrary * @modules java.instrument - * java.management + * jdk.attach * jdk.jartool/sun.tools.jar + * * @run build jdk.testlibrary.* Agent BadAgent RedefineAgent Application RedefineDummy RunnerUtil * @run main BasicTests - * - * This test will perform a number of basic attach tests. */ public class BasicTests { diff --git a/test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java b/test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java --- a/test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java +++ b/test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java @@ -27,7 +27,6 @@ * @summary Test if proxy for PlatformLoggingMXBean is equivalent * to proxy for LoggingMXBean * - * @modules jdk.management * @build LoggingMXBeanTest * @run main LoggingMXBeanTest */ diff --git a/test/java/lang/management/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java b/test/java/lang/management/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java --- a/test/java/lang/management/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java +++ b/test/java/lang/management/PlatformLoggingMXBean/PlatformLoggingMXBeanTest.java @@ -24,12 +24,10 @@ /* * @test * @bug 6876135 7024172 7067691 - * * @summary Test PlatformLoggingMXBean * This test performs similar testing as * java/util/logging/LoggingMXBeanTest. * - * @modules jdk.management * @build PlatformLoggingMXBeanTest * @run main PlatformLoggingMXBeanTest */ diff --git a/test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java b/test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java --- a/test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java +++ b/test/sun/management/jmxremote/bootstrap/CustomLauncherTest.java @@ -40,12 +40,16 @@ /** * @test * @bug 6434402 8004926 + * @author Jaroslav Bachorik + * * @library /lib/testlibrary * @modules jdk.management.agent/jdk.internal.agent + * java.management + * jdk.attach + * * @build jdk.testlibrary.* * @build TestManager TestApplication CustomLauncherTest * @run main/othervm CustomLauncherTest - * @author Jaroslav Bachorik */ public class CustomLauncherTest { private static final String TEST_CLASSPATH = System.getProperty("test.class.path"); diff --git a/test/sun/management/jmxremote/bootstrap/JvmstatCountersTest.java b/test/sun/management/jmxremote/bootstrap/JvmstatCountersTest.java --- a/test/sun/management/jmxremote/bootstrap/JvmstatCountersTest.java +++ b/test/sun/management/jmxremote/bootstrap/JvmstatCountersTest.java @@ -27,7 +27,11 @@ * @summary Tests that the jvmstat counters published by the out-of-the-box * management agent for the JMX connection details are correct. * @author Luis-Miguel Alventosa + * * @modules jdk.management.agent/jdk.internal.agent + * java.management + * jdk.attach + * * @run clean JvmstatCountersTest * @run build JvmstatCountersTest * @run main/othervm/timeout=600 -XX:+UsePerfData JvmstatCountersTest 1 diff --git a/test/sun/management/jmxremote/bootstrap/LocalManagementTest.java b/test/sun/management/jmxremote/bootstrap/LocalManagementTest.java --- a/test/sun/management/jmxremote/bootstrap/LocalManagementTest.java +++ b/test/sun/management/jmxremote/bootstrap/LocalManagementTest.java @@ -32,13 +32,17 @@ /** * @test - * @library /lib/testlibrary * @bug 5016507 6173612 6319776 6342019 6484550 8004926 * @summary Start a managed VM and test that a management tool can connect * without connection or username/password details. * TestManager will attempt a connection to the address obtained from * both agent properties and jvmstat buffer. + * + * @library /lib/testlibrary * @modules jdk.management.agent/jdk.internal.agent + * java.management + * jdk.attach + * * @build jdk.testlibrary.* TestManager TestApplication * @run main/othervm/timeout=300 LocalManagementTest */ diff --git a/test/sun/management/jmxremote/startstop/JMXStartStopTest.java b/test/sun/management/jmxremote/startstop/JMXStartStopTest.java --- a/test/sun/management/jmxremote/startstop/JMXStartStopTest.java +++ b/test/sun/management/jmxremote/startstop/JMXStartStopTest.java @@ -53,13 +53,17 @@ /** * @test * @bug 7110104 + * @key randomness intermittent + * @summary Makes sure that enabling/disabling the management agent through JCMD + * achieves the desired results + * * @library /lib/testlibrary * @modules jdk.management.agent/jdk.internal.agent + * java.management + * java.rmi + * * @build jdk.testlibrary.* JMXStartStopTest PortAllocator TestApp ManagementAgentJcmd * @run main/othervm/timeout=600 -XX:+UsePerfData JMXStartStopTest - * @summary Makes sure that enabling/disabling the management agent through JCMD - * achieves the desired results - * @key randomness intermittent */ public class JMXStartStopTest { private static final String TEST_APP_NAME = "TestApp"; diff --git a/test/sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java b/test/sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java --- a/test/sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java +++ b/test/sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java @@ -40,9 +40,8 @@ * @library /test/lib * @library /lib/testlibrary * @modules jdk.hotspot.agent/sun.jvm.hotspot + * java.management * - * @build jdk.testlibrary.* - * @build jdk.test.lib.apps.* * @build JMapHeapConfigTest TmtoolTestScenario * @run main JMapHeapConfigTest */