--- old/src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java 2018-04-05 15:20:47.337898000 +0530 +++ new/src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGImageReader.java 2018-04-05 15:20:47.009734000 +0530 @@ -698,10 +698,12 @@ readHeader(); /* - * Optimization: We can skip the remaining metadata if the - * ignoreMetadata flag is set, and only if this is not a palette - * image (in that case, we need to read the metadata to get the - * tRNS chunk, which is needed for the getImageTypes() method). + * Optimization: We can skip reading metadata if ignoreMetadata + * flag is set and colorType is not PNG_COLOR_PALETTE. However, + * we parse tRNS chunk to retrieve the transparent color from the + * metadata. Doing so, helps PNGImageReader to appropriately + * identify and set transparent pixels in the decoded image for + * colorType PNG_COLOR_RGB and PNG_COLOR_GRAY. */ int colorType = metadata.IHDR_colorType; if (ignoreMetadata && colorType != PNG_COLOR_PALETTE) { @@ -717,10 +719,19 @@ int chunkType = stream.readInt(); if (chunkType == IDAT_TYPE) { - // We've reached the image data + // We've reached the first IDAT chunk position stream.skipBytes(-8); imageStartPosition = stream.getStreamPosition(); + /* + * According to PNG specification tRNS chunk must + * precede the first IDAT chunk. So we can stop + * reading metadata. + */ break; + } else if (chunkType == tRNS_TYPE) { + parse_tRNS_chunk(chunkLength); + // After parsing tRNS chunk we will skip 4 CRC bytes + stream.skipBytes(4); } else { // Skip the chunk plus the 4 CRC bytes that follow stream.skipBytes(chunkLength + 4); @@ -1266,7 +1277,24 @@ break; } - if (useSetRect) { + /* + * In case of colortype PNG_COLOR_RGB or PNG_COLOR_GRAY + * if we have transparent pixel information from tRNS chunk + * we need to consider that also and store proper information + * in alpha channel. + * + * Also we create destination image with extra alpha channel + * in getImageTypes() when we have tRNS chunk for colorType + * PNG_COLOR_RGB or PNG_COLOR_GRAY. + */ + boolean tRNSTransparentPixelPresent = + theImage.getSampleModel().getNumBands() == inputBands + 1 && + metadata.tRNS_present && + (metadata.tRNS_colorType == PNG_COLOR_RGB || + metadata.tRNS_colorType == PNG_COLOR_GRAY); + if (useSetRect && + !tRNSTransparentPixelPresent) + { imRas.setRect(updateMinX, dstY, passRow); } else { int newSrcX = srcX; @@ -1281,7 +1309,47 @@ ps[b] = scale[b][ps[b]]; } } - imRas.setPixel(dstX, dstY, ps); + if (tRNSTransparentPixelPresent) + { + /* + * Create intermediate array to fill the extra + * alpha channel for each pixel. + */ + int[] temp = new int[inputBands + 1]; + if (metadata.tRNS_colorType == PNG_COLOR_RGB) { + temp[0] = ps[0]; + temp[1] = ps[1]; + temp[2] = ps[2]; + if (ps[0] == metadata.tRNS_red && + ps[1] == metadata.tRNS_green && + ps[2] == metadata.tRNS_blue) + { + temp[3] = 0; + } else { + if (bitDepth < 16) { + temp[3] = 255; + } else { + temp[3] = 65535; + } + } + } else { + // when tRNS_colorType is PNG_COLOR_GRAY + temp[0] = ps[0]; + if (ps[0] == metadata.tRNS_gray) + { + temp[1] = 0; + } else { + if (bitDepth < 16) { + temp[1] = 255; + } else { + temp[1] = 65535; + } + } + } + imRas.setPixel(dstX, dstY, temp); + } else { + imRas.setPixel(dstX, dstY, ps); + } newSrcX += srcXStep; } } @@ -1422,9 +1490,20 @@ // how many bands are in the image, so perform checking // of the read param. int colorType = metadata.IHDR_colorType; - checkReadParamBandSettings(param, - inputBandsForColorType[colorType], - theImage.getSampleModel().getNumBands()); + if (theImage.getSampleModel().getNumBands() == + inputBandsForColorType[colorType] + 1 && + metadata.tRNS_present && + (metadata.tRNS_colorType == PNG_COLOR_RGB || + metadata.tRNS_colorType == PNG_COLOR_GRAY)) + { + checkReadParamBandSettings(param, + inputBandsForColorType[colorType] + 1, + theImage.getSampleModel().getNumBands()); + } else { + checkReadParamBandSettings(param, + inputBandsForColorType[colorType], + theImage.getSampleModel().getNumBands()); + } clearAbortRequest(); processImageStarted(0); @@ -1506,7 +1585,27 @@ } switch (colorType) { + /* + * In case of PNG_COLOR_RGB or PNG_COLOR_GRAY, if we + * have transparent pixel information in tRNS chunk + * we create destination image having alpha channel. + */ case PNG_COLOR_GRAY: + readMetadata(); // Need tRNS chunk + + if (metadata.tRNS_present && + metadata.tRNS_colorType == PNG_COLOR_GRAY) + { + gray = ColorSpace.getInstance(ColorSpace.CS_GRAY); + bandOffsets = new int[2]; + bandOffsets[0] = 0; + bandOffsets[1] = 1; + l.add(ImageTypeSpecifier.createInterleaved(gray, + bandOffsets, + dataType, + true, + false)); + } // Packed grayscale l.add(ImageTypeSpecifier.createGrayscale(bitDepth, dataType, @@ -1514,7 +1613,15 @@ break; case PNG_COLOR_RGB: + readMetadata(); // Need tRNS chunk + if (bitDepth == 8) { + if (metadata.tRNS_present && + metadata.tRNS_colorType == PNG_COLOR_RGB) + { + l.add(ImageTypeSpecifier.createFromBufferedImageType( + BufferedImage.TYPE_4BYTE_ABGR)); + } // some standard types of buffered images // which can be used as destination l.add(ImageTypeSpecifier.createFromBufferedImageType( @@ -1527,6 +1634,20 @@ BufferedImage.TYPE_INT_BGR)); } + if (metadata.tRNS_present && + metadata.tRNS_colorType == PNG_COLOR_RGB) + { + rgb = ColorSpace.getInstance(ColorSpace.CS_sRGB); + bandOffsets = new int[4]; + bandOffsets[0] = 0; + bandOffsets[1] = 1; + bandOffsets[2] = 2; + bandOffsets[3] = 3; + + l.add(ImageTypeSpecifier. + createInterleaved(rgb, bandOffsets, + dataType, true, false)); + } // Component R, G, B rgb = ColorSpace.getInstance(ColorSpace.CS_sRGB); bandOffsets = new int[3]; --- /dev/null 2018-04-05 14:58:40.451564000 +0530 +++ new/test/jdk/javax/imageio/plugins/png/ReadPngGrayImageWithTRNSChunk.java 2018-04-05 15:20:47.818138001 +0530 @@ -0,0 +1,170 @@ +/* + * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 6788458 + * @summary Test verifies that PNGImageReader takes tRNS chunk values + * into consideration while reading non-indexed Gray PNG images. + * @run main ReadPngGrayImageWithTRNSChunk + */ + +import java.awt.Graphics2D; +import java.awt.image.BufferedImage; +import java.awt.Color; +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.util.Iterator; +import javax.imageio.ImageTypeSpecifier; +import javax.imageio.ImageWriter; +import javax.imageio.ImageIO; +import javax.imageio.ImageWriteParam; +import javax.imageio.metadata.IIOMetadata; +import javax.imageio.metadata.IIOMetadataNode; +import javax.imageio.stream.ImageOutputStream; +import javax.imageio.IIOImage; + +public class ReadPngGrayImageWithTRNSChunk { + + private static ImageOutputStream ios; + private static File output; + private static IIOMetadataNode root; + private static BufferedImage img; + private static ImageWriter writer; + private static ImageWriteParam param; + private static IIOMetadata metadata; + + private static void initialize(int type) { + int width = 2; + int height = 1; + img = new BufferedImage(width, height, type); + Graphics2D g2D = img.createGraphics(); + + // transparent first pixel + g2D.setColor(new Color(255, 255, 255)); + g2D.fillRect(0, 0, 1, 1); + // non-transparent second pixel + g2D.setColor(new Color(128, 128,128)); + g2D.fillRect(1, 0, 1, 1); + g2D.dispose(); + + Iterator iterWriter = + ImageIO.getImageWritersBySuffix("png"); + writer = iterWriter.next(); + + param = writer.getDefaultWriteParam(); + ImageTypeSpecifier specifier = + ImageTypeSpecifier. + createFromBufferedImageType(type); + metadata = writer.getDefaultImageMetadata(specifier, param); + } + + private static void createOutputStream() throws IOException { + String dir = System.getProperty("test.src"); + String sep = System.getProperty("file.separator"); + String filePath = dir + sep; + File directory = new File(filePath); + output = File.createTempFile("output", "png", directory); + directory.delete(); + ios = ImageIO.createImageOutputStream(output); + } + + private static void createTRNSNode(String tRNS_value) { + IIOMetadataNode tRNS_gray = new IIOMetadataNode("tRNS_Grayscale"); + tRNS_gray.setAttribute("gray", tRNS_value); + + IIOMetadataNode tRNS = new IIOMetadataNode("tRNS"); + tRNS.appendChild(tRNS_gray); + root = new IIOMetadataNode("javax_imageio_png_1.0"); + root.appendChild(tRNS); + } + + private static boolean verifyAlphaValue(BufferedImage img) { + Color firstPixel = new Color(img.getRGB(0, 0), true); + Color secondPixel = new Color(img.getRGB(1, 0), true); + + return firstPixel.getAlpha() != 0 || + secondPixel.getAlpha() != 255; + } + + private static boolean read8BitGrayPNGWithTRNSChunk() throws IOException { + initialize(BufferedImage.TYPE_BYTE_GRAY); + // Create tRNS node and merge it with default metadata + createTRNSNode("255"); + + metadata.mergeTree("javax_imageio_png_1.0", root); + + writer.setOutput(ios); + + writer.write(metadata, new IIOImage(img, null, metadata), param); + + // Read 8 bit PNG Gray image with tRNS chunk + BufferedImage display_img = ImageIO.read(output); + // Verify alpha values present in first & second pixel + return verifyAlphaValue(display_img); + } + + private static boolean read16BitGrayPNGWithTRNSChunk() throws IOException { + initialize(BufferedImage.TYPE_USHORT_GRAY); + // Create tRNS node and merge it with default metadata + createTRNSNode("65535"); + + metadata.mergeTree("javax_imageio_png_1.0", root); + + writer.setOutput(ios); + + writer.write(metadata, new IIOImage(img, null, metadata), param); + + // Read 16 bit PNG Gray image with tRNS chunk + BufferedImage display_img = ImageIO.read(output); + // Verify alpha values present in first & second pixel + return verifyAlphaValue(display_img); + } + + public static void main(String[] args) throws IOException { + // read 8 bit PNG Gray image with tRNS chunk + boolean read8BitFail, read16BitFail; + try { + createOutputStream(); + read8BitFail = read8BitGrayPNGWithTRNSChunk(); + } finally { + ios.close(); + Files.delete(output.toPath()); + } + + // read 16 bit PNG Gray image with tRNS chunk + try { + createOutputStream(); + read16BitFail = read16BitGrayPNGWithTRNSChunk(); + } finally { + ios.close(); + Files.delete(output.toPath()); + } + + if (read8BitFail || read16BitFail) { + throw new RuntimeException("PNGImageReader is not using" + + " transparent pixel information from tRNS chunk properly"); + } + } +} --- /dev/null 2018-04-05 14:58:40.451564000 +0530 +++ new/test/jdk/javax/imageio/plugins/png/ReadPngRGBImageWithTRNSChunk.java 2018-04-05 15:20:48.598528001 +0530 @@ -0,0 +1,216 @@ +/* + * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 6788458 + * @summary Test verifies that PNGImageReader takes tRNS chunk values + * into consideration while reading non-indexed RGB PNG images. + * @run main ReadPngRGBImageWithTRNSChunk + */ + +import java.awt.Graphics2D; +import java.awt.image.BufferedImage; +import java.awt.Color; +import java.io.File; +import java.io.IOException; +import java.nio.file.Files; +import java.util.Iterator; +import javax.imageio.ImageTypeSpecifier; +import javax.imageio.ImageWriter; +import javax.imageio.ImageIO; +import javax.imageio.ImageWriteParam; +import javax.imageio.metadata.IIOMetadata; +import javax.imageio.metadata.IIOMetadataNode; +import javax.imageio.stream.ImageOutputStream; +import javax.imageio.IIOImage; +import java.awt.image.DataBuffer; +import java.awt.image.DataBufferUShort; +import java.awt.image.WritableRaster; +import java.awt.image.Raster; +import java.awt.color.ColorSpace; +import java.awt.image.ColorModel; +import java.awt.image.ComponentColorModel; +import java.awt.Transparency; + +public class ReadPngRGBImageWithTRNSChunk { + + private static ImageOutputStream ios; + private static File output; + private static IIOMetadataNode root; + + private static void createOutputStream() throws IOException { + String dir = System.getProperty("test.src"); + String sep = System.getProperty("file.separator"); + String filePath = dir + sep; + File directory = new File(filePath); + output = File.createTempFile("output", "png", directory); + directory.delete(); + ios = ImageIO.createImageOutputStream(output); + } + + private static void createTRNSNode(String tRNS_value) { + IIOMetadataNode tRNS_rgb = new IIOMetadataNode("tRNS_RGB"); + tRNS_rgb.setAttribute("red", tRNS_value); + tRNS_rgb.setAttribute("green", tRNS_value); + tRNS_rgb.setAttribute("blue", tRNS_value); + + IIOMetadataNode tRNS = new IIOMetadataNode("tRNS"); + tRNS.appendChild(tRNS_rgb); + root = new IIOMetadataNode("javax_imageio_png_1.0"); + root.appendChild(tRNS); + } + + private static boolean verifyAlphaValue(BufferedImage img) { + Color firstPixel = new Color(img.getRGB(0, 0), true); + Color secondPixel = new Color(img.getRGB(1, 0), true); + + return firstPixel.getAlpha() != 0 || + secondPixel.getAlpha() != 255; + } + + private static boolean read8BitRGBPNGWithTRNSChunk() throws IOException { + int width = 2; + int height = 1; + // Create 8 bit PNG image + BufferedImage img = + new BufferedImage(width, height, BufferedImage.TYPE_3BYTE_BGR); + Graphics2D g2D = img.createGraphics(); + + // transparent first pixel + g2D.setColor(Color.WHITE); + g2D.fillRect(0, 0, 1, 1); + // non-transparent second pixel + g2D.setColor(Color.RED); + g2D.fillRect(1, 0, 1, 1); + g2D.dispose(); + + Iterator iterWriter = + ImageIO.getImageWritersBySuffix("png"); + ImageWriter writer = iterWriter.next(); + + ImageWriteParam param = writer.getDefaultWriteParam(); + ImageTypeSpecifier specifier = + ImageTypeSpecifier. + createFromBufferedImageType(BufferedImage.TYPE_3BYTE_BGR); + IIOMetadata metadata = + writer.getDefaultImageMetadata(specifier, param); + + // Create tRNS node and merge it with default metadata + createTRNSNode("255"); + + metadata.mergeTree("javax_imageio_png_1.0", root); + + writer.setOutput(ios); + + writer.write(metadata, new IIOImage(img, null, metadata), param); + + // Read 8 bit PNG RGB image with tRNS chunk + BufferedImage display_img = ImageIO.read(output); + // Verify alpha values present in first & second pixel + return verifyAlphaValue(display_img); + } + + private static boolean read16BitRGBPNGWithTRNSChunk() throws IOException { + // Create 16 bit PNG image + int height = 1; + int width = 2; + int numBands = 3; + int shortArrayLength = width * height * numBands; + short[] pixelData = new short[shortArrayLength]; + // transparent first pixel + pixelData[0] = (short)0xffff; + pixelData[1] = (short)0xffff; + pixelData[2] = (short)0xffff; + // non-transparent second pixel + pixelData[3] = (short)0xffff; + pixelData[4] = (short)0xffff; + pixelData[5] = (short)0xfffe; + + DataBuffer buffer = new DataBufferUShort(pixelData, shortArrayLength); + + int[] bandOffset = {0, 1 ,2}; + WritableRaster ras = + Raster.createInterleavedRaster(buffer, width, height, + width * numBands, numBands, bandOffset, null); + + int nBits[] = {16, 16 ,16}; + ColorModel colorModel = new + ComponentColorModel(ColorSpace.getInstance(ColorSpace.CS_sRGB), + nBits, false, false, Transparency.OPAQUE, + DataBuffer.TYPE_USHORT); + BufferedImage img = new BufferedImage(colorModel, ras, + false, null); + + Iterator iterWriter = + ImageIO.getImageWritersBySuffix("png"); + ImageWriter writer = iterWriter.next(); + + ImageWriteParam param = writer.getDefaultWriteParam(); + ImageTypeSpecifier specifier = + ImageTypeSpecifier. + createFromBufferedImageType(BufferedImage.TYPE_3BYTE_BGR); + IIOMetadata metadata = + writer.getDefaultImageMetadata(specifier, param); + + // Create tRNS node and merge it with default metadata + createTRNSNode("65535"); + + metadata.mergeTree("javax_imageio_png_1.0", root); + + writer.setOutput(ios); + + writer.write(metadata, new IIOImage(img, null, metadata), param); + + // Read 16 bit PNG RGB image with tRNS chunk + BufferedImage display_img = ImageIO.read(output); + // Verify alpha values present in first & second pixel + return verifyAlphaValue(display_img); + } + + public static void main(String[] args) throws IOException { + // read 8 bit PNG RGB image with tRNS chunk + boolean read8BitFail, read16BitFail; + try { + createOutputStream(); + read8BitFail = read8BitRGBPNGWithTRNSChunk(); + } finally { + ios.close(); + Files.delete(output.toPath()); + } + + // read 16 bit PNG RGB image with tRNS chunk + try { + createOutputStream(); + read16BitFail = read16BitRGBPNGWithTRNSChunk(); + } finally { + ios.close(); + Files.delete(output.toPath()); + } + + if (read8BitFail || read16BitFail) { + throw new RuntimeException("PNGImageReader is not using" + + " transparent pixel information from tRNS chunk properly"); + } + } +}