Code Review for sandbox

Prepared by:jdv on Fri Jun 14 14:39:10 IST 2019
Workspace:/Users/jdv/workspace/jdk/sandbox
Branch:metal-prototype-branch
Summary of changes: 17972 lines changed: 11452 ins; 6340 del; 180 mod; 15743 unchg
Patch of changes: sandbox.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/lib/Awt2dLibraries.gmk

17 lines changed: 16 ins; 1 del; 0 mod; 983 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/module/jdk8_packages.dat

1 line changed: 1 ins; 0 del; 0 mod; 1340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/awt/CGraphicsConfig.java

6 lines changed: 1 ins; 4 del; 1 mod; 96 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/awt/CGraphicsDevice.java

22 lines changed: 2 ins; 17 del; 3 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/java2d/MacosxSurfaceManagerFactory.java

22 lines changed: 2 ins; 18 del; 2 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java

37 lines changed: 1 ins; 6 del; 30 mod; 379 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/LWComponentPeer.java

34 lines changed: 3 ins; 24 del; 7 mod; 1458 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformView.java

80 lines changed: 3 ins; 53 del; 24 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow.java

102 lines changed: 26 ins; 26 del; 50 mod; 1287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java

22 lines changed: 18 ins; 0 del; 4 mod; 453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java

34 lines changed: 6 ins; 0 del; 28 mod; 979 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h

2 lines changed: 1 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m

20 lines changed: 20 ins; 0 del; 0 mod; 1486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m

6 lines changed: 6 ins; 0 del; 0 mod; 1659 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/awt/CGraphicsDevice.m

2 lines changed: 2 ins; 0 del; 0 mod; 386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/Blit.java

5 lines changed: 4 ins; 0 del; 1 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/BlitBg.java

5 lines changed: 4 ins; 0 del; 1 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListAA.java

5 lines changed: 4 ins; 0 del; 1 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/DrawGlyphListLCD.java

5 lines changed: 4 ins; 0 del; 1 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/DrawLine.java

5 lines changed: 4 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/FillParallelogram.java

5 lines changed: 4 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/FillRect.java

5 lines changed: 4 ins; 0 del; 1 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/FillSpans.java

5 lines changed: 4 ins; 0 del; 1 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitive.java

110 lines changed: 83 ins; 12 del; 15 mod; 600 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitiveMgr.java

1 line changed: 1 ins; 0 del; 0 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/MaskBlit.java

5 lines changed: 4 ins; 0 del; 1 mod; 263 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/MaskFill.java

15 lines changed: 12 ins; 0 del; 3 mod; 269 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/ScaledBlit.java

5 lines changed: 4 ins; 0 del; 1 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/loops/TransformHelper.java

5 lines changed: 4 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/classes/sun/java2d/opengl/OGLTextRenderer.java

6 lines changed: 5 ins; 0 del; 1 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libawt/java2d/Trace.h

56 lines changed: 56 ins; 0 del; 0 mod; 182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libawt/java2d/loops/GraphicsPrimitiveMgr.c

8 lines changed: 8 ins; 0 del; 0 mod; 658 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.desktop/share/native/libawt/java2d/loops/GraphicsPrimitiveMgr.h

1 line changed: 1 ins; 0 del; 0 mod; 658 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/macos/MacOSFlags.java

86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLBlitLoops.java

945 lines changed: 945 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLBufImgOps.java

112 lines changed: 112 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLContext.java

222 lines changed: 222 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLDrawImage.java

113 lines changed: 113 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLGraphicsConfig.java

439 lines changed: 439 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLLayer.java

124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLMaskBlit.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLMaskFill.java

85 lines changed: 85 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLPaints.java

208 lines changed: 208 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderQueue.java

254 lines changed: 254 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLRenderer.java

223 lines changed: 223 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceData.java

885 lines changed: 885 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceDataProxy.java

84 lines changed: 84 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLTextRenderer.java

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLUtilities.java

326 lines changed: 326 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/classes/sun/java2d/metal/MTLVolatileSurfaceManager.java

146 lines changed: 146 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/awt/common.h

67 lines changed: 67 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/awt/shaders.metal

101 lines changed: 101 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.h

72 lines changed: 72 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m

482 lines changed: 482 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBufImgOps.h

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBufImgOps.m

378 lines changed: 378 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.h

240 lines changed: 240 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLContext.m

448 lines changed: 448 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLFuncs.h

41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLFuncs.m

83 lines changed: 83 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.h

81 lines changed: 81 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLGraphicsConfig.m

203 lines changed: 203 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.h

63 lines changed: 63 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLLayer.m

180 lines changed: 180 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLMaskBlit.h

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLMaskBlit.m

57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLMaskFill.h

36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLMaskFill.m

111 lines changed: 111 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.h

59 lines changed: 59 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPaints.m

462 lines changed: 462 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.h

31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLPipelineStatesStorage.m

147 lines changed: 147 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderQueue.h

134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderQueue.m

850 lines changed: 850 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.h

78 lines changed: 78 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLRenderer.m

654 lines changed: 654 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceData.h

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceData.m

458 lines changed: 458 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLSurfaceDataBase.h

212 lines changed: 212 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTextRenderer.h

57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTextRenderer.m

382 lines changed: 382 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexturePool.h

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLTexurePool.m

92 lines changed: 92 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLUtils.h

6 lines changed: 6 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLUtils.m

47 lines changed: 47 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLVertexCache.h

86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLVertexCache.m

175 lines changed: 175 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/classes/sun/java2d/metal/MetalBlitLoops.java

952 lines changed: 0 ins; 952 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/classes/sun/java2d/metal/MetalContext.java

227 lines changed: 0 ins; 227 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/classes/sun/java2d/metal/MetalGraphicsConfig.java

197 lines changed: 0 ins; 197 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/classes/sun/java2d/metal/MetalLayer.java

173 lines changed: 0 ins; 173 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/classes/sun/java2d/metal/MetalRenderQueue.java

258 lines changed: 0 ins; 258 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/classes/sun/java2d/metal/MetalRenderer.java

222 lines changed: 0 ins; 222 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/classes/sun/java2d/metal/MetalSurfaceData.java

556 lines changed: 0 ins; 556 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/classes/sun/java2d/metal/MetalVolatileSurfaceManager.java

134 lines changed: 0 ins; 134 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalGraphicsConfig.h

120 lines changed: 0 ins; 120 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalGraphicsConfig.m

454 lines changed: 0 ins; 454 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalLayer.h

75 lines changed: 0 ins; 75 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalLayer.m

385 lines changed: 0 ins; 385 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalRenderQueue.h

61 lines changed: 0 ins; 61 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalRenderQueue.m

832 lines changed: 0 ins; 832 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalRenderer.h

114 lines changed: 0 ins; 114 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalRenderer.m

514 lines changed: 0 ins; 514 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalSurfaceData.h

53 lines changed: 0 ins; 53 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MetalSurfaceData.m

532 lines changed: 0 ins; 532 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/VertexDataManager.h

64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/VertexDataManager.m

166 lines changed: 0 ins; 166 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/shaders/BaseShader.metal

66 lines changed: 0 ins; 66 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/shaders/MetalShaderTypes.h

24 lines changed: 0 ins; 24 del; 0 mod; 0 unchg

This code review page was prepared using webrev.ksh (vers 25.17-hg+openjdk.java.net).