Code Review for jdk

Prepared by:jdenise on Tue Jun 23 14:29:32 CEST 2015
Workspace:/Users/jdenise/workspaces/latest-jdk9/hs-rt/jdk
Summary of changes: 8005 lines changed: 5350 ins; 2145 del; 510 mod; 7764 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/Tools.gmk

1 line changed: 0 ins; 1 del; 0 mod; 188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/mapfiles/libjava/mapfile-vers

13 lines changed: 10 ins; 3 del; 0 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/classes/build/tools/module/ImageBuilder.java

101 lines changed: 28 ins; 28 del; 45 mod; 426 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/src/classes/build/tools/module/ModuleArchive.java

194 lines changed: 40 ins; 99 del; 55 mod; 88 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/Archive.java

76 lines changed: 59 ins; 6 del; 11 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/BasicImageReader.java

189 lines changed: 64 ins; 40 del; 85 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/BasicImageWriter.java

181 lines changed: 18 ins; 123 del; 40 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageHeader.java

58 lines changed: 21 ins; 4 del; 33 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageLocation.java

361 lines changed: 0 ins; 354 del; 7 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageReader.java

419 lines changed: 274 ins; 95 del; 50 mod; 357 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageStream.java

1 line changed: 0 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageStrings.java

78 lines changed: 0 ins; 75 del; 3 mod; 29 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jimage/UTF8String.java

38 lines changed: 9 ins; 23 del; 6 mod; 235 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtDirectoryStream.java

1 line changed: 0 ins; 0 del; 1 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtFileAttributeView.java

11 lines changed: 3 ins; 0 del; 8 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtFileAttributes.java

2 lines changed: 0 ins; 0 del; 2 mod; 119 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java

191 lines changed: 146 ins; 20 del; 25 mod; 490 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystemProvider.java

7 lines changed: 5 ins; 0 del; 2 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/JrtPath.java

21 lines changed: 14 ins; 0 del; 7 mod; 848 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/jrtfs/SystemImages.java

1 line changed: 1 ins; 0 del; 0 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/native/include/jvm.h

42 lines changed: 42 ins; 0 del; 0 mod; 1238 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.dev/share/classes/jdk/tools/jimage/JImageTask.java

379 lines changed: 72 ins; 252 del; 55 mod; 289 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.dev/share/classes/jdk/tools/jimage/resources/jimage.properties

28 lines changed: 13 ins; 7 del; 8 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.rmic/share/classes/sun/tools/java/ClassPath.java

1 line changed: 0 ins; 0 del; 1 mod; 482 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/Class/getDeclaredField/FieldSetAccessibleTest.java

2 lines changed: 0 ins; 0 del; 2 mod; 382 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/Buffer/LimitDirectMemory.sh

1 line changed: 1 ins; 0 del; 0 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/charset/Charset/NIOCharsetAvailabilityTest.java

3 lines changed: 0 ins; 0 del; 3 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/nio/file/spi/SetDefaultProvider.java

1 line changed: 1 ins; 0 del; 0 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/internal/jimage/VerifyJimage.java

6 lines changed: 5 ins; 0 del; 1 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/internal/jrtfs/Basic.java

212 lines changed: 156 ins; 0 del; 56 mod; 403 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/internal/jrtfs/WithSecurityManager.java

6 lines changed: 3 ins; 0 del; 3 mod; 74 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ExternalFilesWriter.java

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageBufferCache.java

123 lines changed: 123 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageFileCreator.java

355 lines changed: 355 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageJavaSubstrate.java

242 lines changed: 242 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageLocationBase.java

264 lines changed: 264 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageLocationWriter.java

140 lines changed: 140 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageModuleData.java

288 lines changed: 288 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageModuleDataWriter.java

165 lines changed: 165 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageNativeSubstrate.java

134 lines changed: 134 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageResourcesTree.java

344 lines changed: 344 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageStringsReader.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageStringsWriter.java

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ImageSubstrate.java

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/PerfectHashBuilder.java

255 lines changed: 255 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ResourcePool.java

256 lines changed: 256 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/ResourcePoolImpl.java

211 lines changed: 211 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/StringTable.java

44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/decompressor/CompressedResourceHeader.java

124 lines changed: 124 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/decompressor/Decompressor.java

97 lines changed: 97 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressor.java

53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressorFactory.java

80 lines changed: 80 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/decompressor/ResourceDecompressorRepository.java

70 lines changed: 70 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/decompressor/ZipDecompressor.java

79 lines changed: 79 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/jimage/decompressor/ZipDecompressorFactory.java

45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/native/libjava/Image.c

177 lines changed: 177 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.dev/share/classes/jdk/tools/jimage/ExtractedImage.java

210 lines changed: 210 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.dev/share/classes/jdk/tools/jimage/TaskHelper.java

231 lines changed: 231 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/jimage/ImageFile.java

288 lines changed: 0 ins; 288 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/jimage/ImageModules.java

180 lines changed: 0 ins; 180 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/jimage/PReader.java

139 lines changed: 0 ins; 139 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/jimage/PackageModuleMap.java

62 lines changed: 0 ins; 62 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/jimage/Resource.java

67 lines changed: 0 ins; 67 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/jimage/concurrent/ConcurrentPReader.java

149 lines changed: 0 ins; 149 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/unix/native/libjava/ConcurrentPReader_md.c

66 lines changed: 0 ins; 66 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/windows/native/libjava/ConcurrentPReader_md.c

64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

This code review page was prepared using /Users/jdenise/workspaces/util/webrev/webrev.ksh (vers 25.6-hg+openjdk.java.net).