Code Review for open

Prepared by:jjg on Fri Jan 24 16:22:21 PST 2020
Workspace:/w/jjg/work/jdk.javadoc/open
Compare against: http://hg.openjdk.java.net/jdk/jdk
Summary of changes: 684 lines changed: 445 ins; 3 del; 236 mod; 22185 unchg
Patch of changes: open.patch
Bug id: JDK-8237845 : Encapsulate doclet options
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java

2 lines changed: 0 ins; 0 del; 2 mod; 713 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractOverviewIndexWriter.java

2 lines changed: 0 ins; 0 del; 2 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java

3 lines changed: 0 ins; 0 del; 3 mod; 257 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 449 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java

3 lines changed: 0 ins; 0 del; 3 mod; 604 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java

6 lines changed: 0 ins; 0 del; 6 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java

19 lines changed: 2 ins; 0 del; 17 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java

18 lines changed: 0 ins; 0 del; 18 mod; 295 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java

17 lines changed: 0 ins; 0 del; 17 mod; 2170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlOptions.java

207 lines changed: 184 ins; 0 del; 23 mod; 496 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java

4 lines changed: 0 ins; 0 del; 4 mod; 112 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java

3 lines changed: 0 ins; 0 del; 3 mod; 384 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 925 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 178 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java

7 lines changed: 0 ins; 0 del; 7 mod; 347 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 530 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java

1 line changed: 0 ins; 0 del; 1 mod; 193 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java

26 lines changed: 0 ins; 0 del; 26 mod; 947 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/AbstractDoclet.java

4 lines changed: 0 ins; 0 del; 4 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java

11 lines changed: 0 ins; 0 del; 11 mod; 686 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java

288 lines changed: 259 ins; 0 del; 29 mod; 705 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/Messages.java

1 line changed: 0 ins; 0 del; 1 mod; 163 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/PropertyUtils.java

4 lines changed: 0 ins; 2 del; 2 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeFieldBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ConstructorBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/EnumConstantBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/FieldBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 190 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MethodBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java

2 lines changed: 0 ins; 0 del; 2 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PackageSummaryBuilder.java

9 lines changed: 0 ins; 0 del; 9 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PropertyBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 189 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java

6 lines changed: 0 ins; 0 del; 6 mod; 598 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java

6 lines changed: 0 ins; 0 del; 6 mod; 759 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ClassTree.java

1 line changed: 0 ins; 0 del; 1 mod; 407 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ElementListWriter.java

2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/IndexBuilder.java

1 line changed: 0 ins; 0 del; 1 mod; 265 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/MetaKeywords.java

4 lines changed: 0 ins; 0 del; 4 mod; 160 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/StandardDocFileFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 381 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/TypeElementCatalog.java

1 line changed: 0 ins; 0 del; 1 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java

5 lines changed: 0 ins; 1 del; 4 mod; 3420 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java

2 lines changed: 0 ins; 0 del; 2 mod; 1005 unchg

This code review page was prepared using /w/jjg/bin/webrev (vers 25.18-hg+openjdk.java.net).