Code Review for jdk.amber

Prepared by:jjg on Wed Oct 30 16:24:53 PDT 2019
Workspace:/w/jjg/work/jdk.amber
Compare against: http://hg.openjdk.java.net/amber/amber
Compare against version:default
Branch:records
Summary of changes: 2037 lines changed: 1808 ins; 51 del; 178 mod; 20583 unchg
Patch of changes: jdk.amber.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java

rev 58565 : records: mark record related model API as preview
3 lines changed: 1 ins; 0 del; 2 mod; 511 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java

34 lines changed: 25 ins; 0 del; 9 mod; 569 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Contents.java

rev 58344 : records implementation
2 lines changed: 2 ins; 0 del; 0 mod; 416 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDoclet.java

rev 58344 : records implementation
8 lines changed: 0 ins; 1 del; 7 mod; 308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java

10 lines changed: 2 ins; 0 del; 8 mod; 2207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/LinkInfoImpl.java

6 lines changed: 5 ins; 0 del; 1 mod; 434 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java

rev 58344 : records implementation
9 lines changed: 9 ins; 0 del; 0 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java

rev 58565 : records: mark record related model API as preview
18 lines changed: 13 ins; 1 del; 4 mod; 465 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java

rev 58565 : records: mark record related model API as preview
4 lines changed: 2 ins; 0 del; 2 mod; 1297 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/ClassWriter.java

rev 58344 : records implementation
2 lines changed: 0 ins; 0 del; 2 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/CommentUtils.java

rev 58565 : records: mark record related model API as preview
246 lines changed: 233 ins; 3 del; 10 mod; 229 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/PackageSummaryWriter.java

rev 58344 : records implementation
9 lines changed: 9 ins; 0 del; 0 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/Resources.java

rev 58344 : records implementation
2 lines changed: 2 ins; 0 del; 0 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ClassBuilder.java

rev 58565 : records: mark record related model API as preview
127 lines changed: 122 ins; 0 del; 5 mod; 390 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MemberSummaryBuilder.java

rev 58344 : records implementation
1 line changed: 0 ins; 0 del; 1 mod; 591 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PackageSummaryBuilder.java

rev 58344 : records implementation
17 lines changed: 17 ins; 0 del; 0 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java

rev 58344 : records implementation
2 lines changed: 0 ins; 0 del; 2 mod; 614 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties

rev 58348 : remove dead code; update tests
62 lines changed: 60 ins; 0 del; 2 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java

rev 58565 : records: mark record related model API as preview
63 lines changed: 28 ins; 3 del; 32 mod; 258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java

rev 58565 : records: mark record related model API as preview
5 lines changed: 2 ins; 0 del; 3 mod; 750 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletWriter.java

rev 58348 : remove dead code; update tests
4 lines changed: 2 ins; 0 del; 2 mod; 341 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/ClassUseMapper.java

rev 58565 : records: mark record related model API as preview
6 lines changed: 2 ins; 0 del; 4 mod; 603 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/CommentHelper.java

rev 58344 : records implementation
6 lines changed: 4 ins; 0 del; 2 mod; 694 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/TypeElementCatalog.java

rev 58344 : records implementation
26 lines changed: 17 ins; 2 del; 7 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java

rev 58565 : records: mark record related model API as preview
193 lines changed: 95 ins; 41 del; 57 mod; 3287 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/VisibleMemberTable.java

rev 58565 : records: mark record related model API as preview
3 lines changed: 1 ins; 0 del; 2 mod; 1000 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ElementsTable.java

rev 58565 : records: mark record related model API as preview
9 lines changed: 3 ins; 0 del; 6 mod; 1293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocMemberEnter.java

rev 58344 : records implementation
9 lines changed: 9 ins; 0 del; 0 mod; 198 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java

rev 58344 : records implementation
2 lines changed: 0 ins; 0 del; 2 mod; 679 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/doclet/testTaglets/TestTaglets.out

rev 58348 : remove dead code; update tests
0 lines changed: 0 ins; 0 del; 0 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java

rev 58344 : records implementation
2 lines changed: 2 ins; 0 del; 0 mod; 1025 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/tool/api/basic/GetTask_DiagListenerTest.java

rev 58360 : adding preview comments to APIs, enabling preview for records
1 line changed: 0 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/tool/modules/ModuleTestBase.java

rev 58344 : records implementation
3 lines changed: 0 ins; 0 del; 3 mod; 484 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/langtools/jdk/javadoc/tool/reporter_generates_warnings/pkg/MyDoclet.java

rev 58344 : records implementation
2 lines changed: 0 ins; 0 del; 2 mod; 141 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/TestRecordTypes.java

448 lines changed: 448 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/AnnotatedBinaryNode.java

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/BinaryNode.java

rev 58344 : records implementation
45 lines changed: 45 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/Coords.java

rev 58344 : records implementation
95 lines changed: 95 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/Holder.java

rev 58344 : records implementation
34 lines changed: 34 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/Node.java

rev 58344 : records implementation
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/NonNull.java

33 lines changed: 33 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/Point.java

rev 58344 : records implementation
36 lines changed: 36 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/SerializablePoint.java

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/examples/SerializableProxy.java

rev 58344 : records implementation
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/langtools/jdk/javadoc/doclet/testRecordTypes/jdk11/element-list

rev 58344 : records implementation
283 lines changed: 283 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /w/jjg/bin/webrev (vers 25.6-hg+openjdk.java.net).