Code Review for langtools

Prepared by: Jan Lahoda (jlahoda) on Wed Feb 8 11:44:52 PST 2017
Workspace:/scratch/jlahoda/hudson-standalone/.hudson/jobs/patch-module-patches/workspace/sandbox/langtools
Summary of changes: 383 lines changed: 253 ins; 100 del; 30 mod; 10444 unchg
Patch of changes: langtools.patch
Author comments:
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java

8 lines changed: 8 ins; 0 del; 0 mod; 782 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/ModuleFinder.java

43 lines changed: 36 ins; 3 del; 4 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java

3 lines changed: 2 ins; 1 del; 0 mod; 2214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java

19 lines changed: 10 ins; 5 del; 4 mod; 1656 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/file/Locations.java

15 lines changed: 0 ins; 10 del; 5 mod; 1731 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties

7 lines changed: 2 ins; 0 del; 5 mod; 3060 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/modules/XModuleTest.java

212 lines changed: 195 ins; 7 del; 10 mod; 489 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClassoutput/ModuleInfoWithPatchedModuleClassoutput.java (was test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/patchmodule/java.compiler/module-info.java)

1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClassoutput/additional/module-info.java (was test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/patchmodule/java.compiler/module-info.java)

1 line changed: 0 ins; 0 del; 1 mod; 23 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClassoutput/patchmodule/java.compiler/javax/lang/model/element/Extra.java (was test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/patchmodule/java.compiler/javax/lang/model/element/Extra.java)

0 lines changed: 0 ins; 0 del; 0 mod; 26 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcepath/ModuleInfoWithPatchedModule.java (was test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/ModuleInfoWithPatchedModuleSourcePath.java)

0 lines changed: 0 ins; 0 del; 0 mod; 24 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcepath/patchmodule/java.compiler/javax/lang/model/element/Extra.java (was test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/patchmodule/java.compiler/javax/lang/model/element/Extra.java)

0 lines changed: 0 ins; 0 del; 0 mod; 26 unchg

------ ------ ------ ------ --- New Patch Raw test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcepath/patchmodule/java.compiler/module-info.java (was test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleSourcePath/patchmodule/java.compiler/module-info.java)

0 lines changed: 0 ins; 0 del; 0 mod; 24 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClasspath/ModuleInfoWithXmoduleClasspath.java

24 lines changed: 0 ins; 24 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClasspath/additional/module-info.java

24 lines changed: 0 ins; 24 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/tools/javac/diags/examples/ModuleInfoWithPatchedModuleClasspath/patchmodule/java.compiler/javax/lang/model/element/Extra.java

26 lines changed: 0 ins; 26 del; 0 mod; 0 unchg

This code review page was prepared using /scratch/jlahoda/hudson-standalone/.hudson/jobs/patch-module-patches/workspace/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).