Code Review for open

Prepared by:joehw on Mon Nov 6 22:19:45 PST 2017
Workspace:/jaxp/openjdk/jdk10master/open
Compare against: ssh://hg.openjdk.java.net/jdk10/master
Summary of changes: 407 lines changed: 7 ins; 21 del; 379 mod; 77577 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/java_cup/internal/runtime/lr_parser.java

1 line changed: 0 ins; 0 del; 1 mod; 1250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltDatetime.java

3 lines changed: 0 ins; 0 del; 3 mod; 1117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/AttributeSet.java

3 lines changed: 0 ins; 0 del; 3 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/BinOpExpr.java

3 lines changed: 0 ins; 0 del; 3 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FilterExpr.java

2 lines changed: 0 ins; 0 del; 2 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionAvailableCall.java

2 lines changed: 0 ins; 0 del; 2 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/FunctionCall.java

4 lines changed: 0 ins; 0 del; 4 mod; 1182 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/LogicalExpr.java

3 lines changed: 0 ins; 0 del; 3 mod; 230 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Message.java

2 lines changed: 0 ins; 0 del; 2 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Mode.java

6 lines changed: 0 ins; 0 del; 6 mod; 1489 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Number.java

2 lines changed: 0 ins; 0 del; 2 mod; 595 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java

3 lines changed: 0 ins; 0 del; 3 mod; 1486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Sort.java

4 lines changed: 0 ins; 0 del; 4 mod; 731 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/SyntaxTreeNode.java

3 lines changed: 1 ins; 0 del; 2 mod; 917 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/TestSeq.java

2 lines changed: 0 ins; 0 del; 2 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/UnionPathExpr.java

2 lines changed: 0 ins; 0 del; 2 mod; 144 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathParser.java

133 lines changed: 0 ins; 0 del; 133 mod; 3045 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/util/MethodGenerator.java

13 lines changed: 0 ins; 5 del; 8 mod; 2118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2DOM.java

2 lines changed: 0 ins; 0 del; 2 mod; 331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/SAX2StAXEventWriter.java

3 lines changed: 0 ins; 1 del; 2 mod; 415 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 623 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerFactoryImpl.java

3 lines changed: 0 ins; 0 del; 3 mod; 1709 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TransformerImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 1468 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/XSLTCSource.java

2 lines changed: 0 ins; 0 del; 2 mod; 136 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDocumentImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 2837 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMNormalizer.java

2 lines changed: 0 ins; 0 del; 2 mod; 2039 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMStringListImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DocumentImpl.java

2 lines changed: 0 ins; 0 del; 2 mod; 1378 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDTDScannerImpl.java

6 lines changed: 1 ins; 1 del; 4 mod; 2188 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLErrorReporter.java

4 lines changed: 1 ins; 0 del; 3 mod; 608 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLNamespaceBinder.java

4 lines changed: 0 ins; 0 del; 4 mod; 844 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java

4 lines changed: 1 ins; 1 del; 2 mod; 1553 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDLoader.java

4 lines changed: 0 ins; 0 del; 4 mod; 514 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDProcessor.java

3 lines changed: 0 ins; 0 del; 3 mod; 1699 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/XMLDTDValidator.java

3 lines changed: 0 ins; 0 del; 3 mod; 2069 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/util/Base64.java

4 lines changed: 0 ins; 0 del; 4 mod; 304 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/BaseDVFactory.java

3 lines changed: 0 ins; 0 del; 3 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/ExtendedSchemaDVFactoryImpl.java

3 lines changed: 0 ins; 0 del; 3 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/FullDVFactory.java

3 lines changed: 0 ins; 0 del; 3 mod; 166 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/SchemaDVFactoryImpl.java

3 lines changed: 0 ins; 0 del; 3 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/xs/XSSimpleTypeDecl.java

7 lines changed: 0 ins; 0 del; 7 mod; 3483 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/AttributePSVImpl.java

3 lines changed: 1 ins; 1 del; 1 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/ElementPSVImpl.java

3 lines changed: 1 ins; 1 del; 1 mod; 346 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/SubstitutionGroupHandler.java

3 lines changed: 0 ins; 0 del; 3 mod; 358 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaValidator.java

7 lines changed: 0 ins; 1 del; 6 mod; 4612 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSComplexTypeDecl.java

3 lines changed: 0 ins; 0 del; 3 mod; 732 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSConstraints.java

15 lines changed: 0 ins; 1 del; 14 mod; 1520 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSGrammarBucket.java

3 lines changed: 0 ins; 0 del; 3 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/CMBuilder.java

3 lines changed: 1 ins; 0 del; 2 mod; 475 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java

3 lines changed: 0 ins; 0 del; 3 mod; 1827 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java

8 lines changed: 0 ins; 0 del; 8 mod; 4386 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDSimpleTypeTraverser.java

3 lines changed: 0 ins; 0 del; 3 mod; 518 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDUniqueOrKeyTraverser.java

4 lines changed: 0 ins; 0 del; 4 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/XSGrammarPool.java

2 lines changed: 0 ins; 0 del; 2 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/SimpleXMLSchema.java

3 lines changed: 0 ins; 0 del; 3 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/validation/SoftReferenceGrammarPool.java

4 lines changed: 0 ins; 0 del; 4 mod; 433 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractDOMParser.java

4 lines changed: 0 ins; 0 del; 4 mod; 2658 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/DOMEntityResolverWrapper.java

3 lines changed: 0 ins; 0 del; 3 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/SymbolHash.java

3 lines changed: 0 ins; 0 del; 3 mod; 326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java

11 lines changed: 0 ins; 2 del; 9 mod; 3125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMManagerDefault.java

3 lines changed: 0 ins; 0 del; 3 mod; 856 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeList.java

3 lines changed: 0 ins; 0 del; 3 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/DTMNodeProxy.java

2 lines changed: 0 ins; 0 del; 2 mod; 2404 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/BaseMarkupSerializer.java

2 lines changed: 0 ins; 0 del; 2 mod; 1949 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/NamespaceMappings.java

3 lines changed: 0 ins; 0 del; 3 mod; 321 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/ToStream.java

5 lines changed: 0 ins; 1 del; 4 mod; 3660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/NodeSet.java

5 lines changed: 0 ins; 0 del; 5 mod; 1366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/VariableStack.java

4 lines changed: 0 ins; 0 del; 4 mod; 515 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/axes/LocPathIterator.java

3 lines changed: 0 ins; 0 del; 3 mod; 1031 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/compiler/Lexer.java

7 lines changed: 0 ins; 3 del; 4 mod; 638 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/compiler/OpMap.java

3 lines changed: 0 ins; 0 del; 3 mod; 453 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/com/sun/org/apache/xpath/internal/jaxp/JAXPExtensionsProvider.java

3 lines changed: 0 ins; 0 del; 3 mod; 206 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/javax/xml/xpath/XPathException.java

2 lines changed: 0 ins; 0 del; 2 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/org/w3c/dom/bootstrap/DOMImplementationRegistry.java

6 lines changed: 0 ins; 3 del; 3 mod; 396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.xml/share/classes/org/xml/sax/helpers/NamespaceSupport.java

4 lines changed: 0 ins; 0 del; 4 mod; 846 unchg

This code review page was prepared using /java/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).