Print this page
rev 3618 : 7193946: Move warnings associated with UseMemSetInBOT flag
Summary: The warnings associated with the UseMemSetInBOT flag are duplicated in CMS and G1. The separate warnings have been removed and single instance of the warning has been placed in a common location.
Reviewed-by:

Split Close
Expand all
Collapse all
          --- old/src/share/vm/runtime/arguments.cpp
          +++ new/src/share/vm/runtime/arguments.cpp
↓ open down ↓ 3249 lines elided ↑ open up ↑
3250 3250    // set PauseAtExit if the gamma launcher was used and a debugger is attached
3251 3251    // but only if not already set on the commandline
3252 3252    if (Arguments::created_by_gamma_launcher() && os::is_debugger_attached()) {
3253 3253      bool set = false;
3254 3254      CommandLineFlags::wasSetOnCmdline("PauseAtExit", &set);
3255 3255      if (!set) {
3256 3256        FLAG_SET_DEFAULT(PauseAtExit, true);
3257 3257      }
3258 3258    }
3259 3259  
     3260 +#ifdef SPARC
     3261 +  if (UseConcMarkSweepGC || UseG1GC) {
     3262 +    // Issue a stern warning if the user has explicitly set
     3263 +    // UseMemSetInBOT (it is known to cause issues), but allow
     3264 +    // use for experimentation and debugging.
     3265 +    if (VM_Version::is_sun4v() && UseMemSetInBOT) {
     3266 +      assert(!FLAG_IS_DEFAULT(UseMemSetInBOT), "Error");
     3267 +      warning("Experimental flag -XX:+UseMemSetInBOT is known to cause instability"
     3268 +          " on sun4v; please understand that you are using at your own risk!");
     3269 +    }
     3270 +  }
     3271 +#endif // SPARC
     3272 +
3260 3273    return JNI_OK;
3261 3274  }
3262 3275  
3263 3276  int Arguments::PropertyList_count(SystemProperty* pl) {
3264 3277    int count = 0;
3265 3278    while(pl != NULL) {
3266 3279      count++;
3267 3280      pl = pl->next();
3268 3281    }
3269 3282    return count;
↓ open down ↓ 167 lines elided ↑ open up ↑
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX