Code Review for g1-marking-verification

Prepared by:johnc on Fri Sep 21 16:29:16 PDT 2012
Workspace:/export/workspaces/g1-marking-verification
Compare against: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot
Compare against version:145ffab733e7
Summary of changes: 83 lines changed: 43 ins; 31 del; 9 mod; 6018 unchg
Patch of changes: g1-marking-verification.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/concurrentMark.cpp

rev 3635 : 7200261: G1: Liveness counting inconsistencies during marking verification
Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures.
Reviewed-by:
26 lines changed: 1 ins; 18 del; 7 mod; 4403 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/concurrentMark.hpp

rev 3635 : 7200261: G1: Liveness counting inconsistencies during marking verification
Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures.
Reviewed-by:
7 lines changed: 7 ins; 0 del; 0 mod; 1228 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp

rev 3635 : 7200261: G1: Liveness counting inconsistencies during marking verification
Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures.
Reviewed-by:
50 lines changed: 35 ins; 13 del; 2 mod; 387 unchg

This code review page was prepared using /java/j2se/bin/webrev (vers 23.18-hg).