| Prepared by: | johnc on Tue Sep 25 14:54:08 PDT 2012 |
|---|---|
| Workspace: | /export/workspaces/g1-marking-verification |
| Compare against: | http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot |
| Compare against version: | 5baec2e69518 |
| Summary of changes: | 178 lines changed: 80 ins; 26 del; 72 mod; 5960 unchg |
| Patch of changes: | g1-marking-verification.patch |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/g1/concurrentMark.cpp
rev 3640 : 7200261: G1: Liveness counting inconsistencies during marking verification Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures. Reviewed-by: * * * [mq]: code-review-comments113 lines changed: 35 ins; 21 del; 57 mod; 4350 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/g1/concurrentMark.hpp
rev 3640 : 7200261: G1: Liveness counting inconsistencies during marking verification Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures. Reviewed-by: * * * [mq]: code-review-comments8 lines changed: 7 ins; 0 del; 1 mod; 1227 unchg
Cdiffs
Udiffs
Wdiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp
rev 3640 : 7200261: G1: Liveness counting inconsistencies during marking verification Summary: The clipping code in the routine that sets the bits for a range of cards, in the liveness accounting verification code was incorrect. It set all the bits in the card bitmap from the given starting index which would lead to spurious marking verification failures. Reviewed-by: * * * [mq]: code-review-comments57 lines changed: 38 ins; 5 del; 14 mod; 383 unchg
This code review page was prepared using /java/j2se/bin/webrev (vers 23.18-hg).