Code Review for g1-verify-after-fullgc

Prepared by:johnc on Wed May 22 16:02:23 PDT 2013
Workspace:/export/workspaces/g1-verify-after-fullgc
Compare against: http://hg.openjdk.java.net/hsx/hotspot-gc/hotspot
Compare against version:6702da6b6082
Summary of changes: 11 lines changed: 6 ins; 2 del; 3 mod; 8621 unchg
Patch of changes: g1-verify-after-fullgc.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp

rev 4702 : 8015244: G1: Verification after a full GC is incorrectly placed.
Summary: In a full GC, move the verification after the GC to after RSet rebuilding. Verify RSet entries during a full GC under control of a flag.
Reviewed-by:
4 lines changed: 2 ins; 2 del; 0 mod; 6492 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1RemSet.cpp

rev 4702 : 8015244: G1: Verification after a full GC is incorrectly placed.
Summary: In a full GC, move the verification after the GC to after RSet rebuilding. Verify RSet entries during a full GC under control of a flag.
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 811 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/g1_globals.hpp

rev 4702 : 8015244: G1: Verification after a full GC is incorrectly placed.
Summary: In a full GC, move the verification after the GC to after RSet rebuilding. Verify RSet entries during a full GC under control of a flag.
Reviewed-by:
5 lines changed: 4 ins; 0 del; 1 mod; 335 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw src/share/vm/gc_implementation/g1/heapRegion.cpp

rev 4702 : 8015244: G1: Verification after a full GC is incorrectly placed.
Summary: In a full GC, move the verification after the GC to after RSet rebuilding. Verify RSet entries during a full GC under control of a flag.
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 983 unchg

This code review page was prepared using /java/j2se/bin/webrev (vers 23.18-hg).