< prev index next >

src/share/vm/utilities/debug.hpp

Print this page
rev 7563 : 8067306: Improve STATIC_ASSERT
Summary: New improved implementation
Reviewed by:
rev 7564 : [mq]: update1

@@ -223,25 +223,28 @@
 void report_unimplemented(const char* file, int line);
 void report_untested(const char* file, int line, const char* message);
 
 void warning(const char* format, ...) ATTRIBUTE_PRINTF(1, 2);
 
-#ifdef ASSERT
-// Compile-time asserts.
-template <bool> struct StaticAssert;
-template <> struct StaticAssert<true> {};
+// Compile-time asserts.  Cond must be a compile-time constant expression that
+// is convertible to bool.  STATIC_ASSERT() can be used anywhere a declaration
+// may appear.
+//
+// Implementation Note: STATIC_ASSERT_FAILURE<true> provides a value member
+// rather than type member that could be used directly in the typedef, because
+// a type member would require conditional use of "typename", depending on
+// whether Cond is dependent or not.  The use of a value member leads to the
+// use of an array type.  Terniary operator because, purportedly, some old
+// compilers don't handle implicit conversion properly in this context.  It
+// also deals with C++11 constexpr explicit conversion to bool :)
 
-// Only StaticAssert<true> is defined, so if cond evaluates to false we get
-// a compile time exception when trying to use StaticAssert<false>.
-#define STATIC_ASSERT(cond)                   \
-  do {                                        \
-    StaticAssert<(cond)> DUMMY_STATIC_ASSERT; \
-    (void)DUMMY_STATIC_ASSERT; /* ignore */   \
-  } while (false)
-#else
-#define STATIC_ASSERT(cond)
-#endif
+template<bool x> struct STATIC_ASSERT_FAILURE;
+template<> struct STATIC_ASSERT_FAILURE<true> { enum { value = 1 }; };
+
+#define STATIC_ASSERT(Cond)                                     \
+  typedef char STATIC_ASSERT_FAILURE_ ## __LINE__ [             \
+    STATIC_ASSERT_FAILURE< (Cond) ? true : false >::value ]
 
 // out of shared space reporting
 enum SharedSpaceType {
   SharedReadOnly,
   SharedReadWrite,
< prev index next >