Code Review for open

Prepared by:kbarrett on Tue Nov 12 13:11:28 EST 2019
Workspace:/home/kab/sandboxes/simplify_try_collect/jdk/open
Compare against version:qparent
Summary of changes: 422 lines changed: 208 ins; 132 del; 82 mod; 8159 unchg
Patch of changes: open.patch
Bug id: JDK-8232588 : G1 concurrent System.gc can return early or late
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

203 lines changed: 133 ins; 14 del; 56 mod; 4695 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 56783 : [mq]: simplify
rev 56785 : [mq]: fix_comment
rev 56786 : [mq]: stefanj_review
19 lines changed: 7 ins; 1 del; 11 mod; 1471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp

1 line changed: 0 ins; 0 del; 1 mod; 429 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1VMOperations.cpp

rev 56783 : [mq]: simplify
rev 56784 : [mq]: tschatzl_review
167 lines changed: 48 ins; 111 del; 8 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1VMOperations.hpp

rev 56783 : [mq]: simplify
25 lines changed: 15 ins; 5 del; 5 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp

rev 56783 : [mq]: simplify
2 lines changed: 0 ins; 1 del; 1 mod; 177 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/mutexLocker.cpp

3 lines changed: 3 ins; 0 del; 0 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/mutexLocker.hpp

1 line changed: 1 ins; 0 del; 0 mod; 307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/vmOperations.hpp

rev 56783 : [mq]: simplify
1 line changed: 1 ins; 0 del; 0 mod; 523 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).