Code Review for open

Prepared by:kbarrett on Sun Dec 1 18:05:10 EST 2019
Workspace:/home/kab/sandboxes/noncopyable/jdk/open
Compare against version:qparent
Summary of changes: 172 lines changed: 43 ins; 73 del; 56 mod; 13999 unchg
Patch of changes: open.patch
Bug id: JDK-8234779 : Provide idiom for declaring classes noncopyable
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/aix/os_perf_aix.cpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 1 ins; 1 del; 1 mod; 925 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/os_perf_bsd.cpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
7 lines changed: 1 ins; 2 del; 4 mod; 480 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/semaphore_bsd.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
5 lines changed: 2 ins; 2 del; 1 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/os_perf_linux.cpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 1 ins; 1 del; 1 mod; 1035 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/waitBarrier_linux.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 45 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/posix/os_posix.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
7 lines changed: 0 ins; 4 del; 3 mod; 337 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/posix/semaphore_posix.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 53 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_perf_solaris.cpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
2 lines changed: 0 ins; 1 del; 1 mod; 818 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/solaris/os_solaris.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
6 lines changed: 0 ins; 3 del; 3 mod; 361 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_perf_windows.cpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
2 lines changed: 0 ins; 1 del; 1 mod; 1423 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/os_windows.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
6 lines changed: 0 ins; 4 del; 2 mod; 217 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/semaphore_windows.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1FreeIdSet.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1SharedDirtyCardQueue.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 0 ins; 2 del; 1 mod; 274 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.inline.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
10 lines changed: 1 ins; 6 del; 3 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageParState.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 0 ins; 2 del; 1 mod; 197 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/ptrQueue.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
11 lines changed: 5 ins; 4 del; 2 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/taskqueue.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 1 del; 2 mod; 613 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp

rev 57095 : [mq]: use
5 lines changed: 1 ins; 2 del; 2 mod; 135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 1 ins; 1 del; 1 mod; 730 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeapRegionSet.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 1 del; 2 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zArray.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zList.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/jni/jfrJavaCall.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 1 ins; 1 del; 1 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/memory/metaspaceClosure.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 1 del; 2 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/oops/array.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/os_perf.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
5 lines changed: 0 ins; 1 del; 4 mod; 275 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/semaphore.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/thread.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 0 ins; 2 del; 1 mod; 2307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/bitMap.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
6 lines changed: 1 ins; 3 del; 2 mod; 455 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/lockFreeStack.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 0 ins; 2 del; 1 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/macros.hpp

rev 57094 : [mq]: macro
rev 57096 : [mq]: trailing_semi
13 lines changed: 13 ins; 0 del; 0 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/ostream.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
3 lines changed: 1 ins; 1 del; 1 mod; 306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/singleWriterSynchronizer.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 0 ins; 2 del; 2 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/waitBarrier.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 132 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/utilities/waitBarrier_generic.hpp

rev 57095 : [mq]: use
rev 57096 : [mq]: trailing_semi
4 lines changed: 1 ins; 2 del; 1 mod; 56 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).