Code Review for open

Prepared by:kbarrett on Mon Jul 6 19:05:28 EDT 2020
Workspace:/home/kab/sandboxes/storage_notification/jdk/open
Compare against version:stefank.patch
Summary of changes: 513 lines changed: 357 ins; 77 del; 79 mod; 9466 unchg
Patch of changes: open.patch
Bug id: JDK-8248391 : Unify handling of all OopStorage instances in weak root processing
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.cpp

rev 60027 : [mq]: kab_review
17 lines changed: 5 ins; 4 del; 8 mod; 793 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/stringTable.hpp

rev 60027 : [mq]: kab_review
9 lines changed: 0 ins; 5 del; 4 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1Policy.cpp

rev 60027 : [mq]: kab_review
2 lines changed: 2 ins; 0 del; 0 mod; 1423 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.cpp

rev 60027 : [mq]: kab_review
23 lines changed: 13 ins; 1 del; 9 mod; 1071 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorage.hpp

rev 60027 : [mq]: kab_review
22 lines changed: 11 ins; 5 del; 6 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageParState.hpp

rev 60027 : [mq]: kab_review
7 lines changed: 3 ins; 0 del; 4 mod; 204 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageParState.inline.hpp

rev 60027 : [mq]: kab_review
4 lines changed: 0 ins; 4 del; 0 mod; 99 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSet.hpp

rev 60027 : [mq]: kab_review
15 lines changed: 0 ins; 8 del; 7 mod; 158 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSetParState.hpp

rev 60027 : [mq]: kab_review
4 lines changed: 3 ins; 0 del; 1 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/oopStorageSetParState.inline.hpp

rev 60027 : [mq]: kab_review
9 lines changed: 0 ins; 2 del; 7 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/weakProcessor.cpp

rev 60027 : [mq]: kab_review
40 lines changed: 11 ins; 16 del; 13 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/weakProcessor.hpp

rev 60027 : [mq]: kab_review
7 lines changed: 5 ins; 1 del; 1 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/weakProcessor.inline.hpp

rev 60027 : [mq]: kab_review
9 lines changed: 3 ins; 4 del; 2 mod; 181 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp

rev 60027 : [mq]: kab_review
1 line changed: 0 ins; 0 del; 1 mod; 3135 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp

rev 60027 : [mq]: kab_review
1 line changed: 0 ins; 0 del; 1 mod; 328 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.inline.hpp

rev 60027 : [mq]: kab_review
2 lines changed: 0 ins; 0 del; 2 mod; 214 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRootsIterator.cpp

rev 60027 : [mq]: kab_review
2 lines changed: 0 ins; 0 del; 2 mod; 363 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zRootsIterator.hpp

rev 60027 : [mq]: kab_review
1 line changed: 0 ins; 0 del; 1 mod; 205 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zWeakRootsProcessor.cpp

rev 60027 : [mq]: kab_review
1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/resolvedMethodTable.cpp

rev 60027 : [mq]: kab_review
25 lines changed: 7 ins; 11 del; 7 mod; 388 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/prims/resolvedMethodTable.hpp

rev 60027 : [mq]: kab_review
28 lines changed: 10 ins; 16 del; 2 mod; 66 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/runtime/stringtable/StringTableCleaningTest.java

rev 60028 : imported patch test
284 lines changed: 284 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/kab/devtools/jdk/code-tools/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).