# HG changeset patch # User kzhaldyb # Date 1473960140 -10800 # Thu Sep 15 20:22:20 2016 +0300 # Node ID cfc53baa6dfb8623bd3fe75dc23d3af10c1b7434 # Parent f722ed07b76bb8ffc26672ab952be7c0648fdc8f 8165613: Convert TestKlass_test to Gtest Reviewed-by: duke diff --git a/src/share/vm/oops/klass.cpp b/src/share/vm/oops/klass.cpp --- a/src/share/vm/oops/klass.cpp +++ b/src/share/vm/oops/klass.cpp @@ -728,27 +728,3 @@ } #endif - -/////////////// Unit tests /////////////// - -#ifndef PRODUCT - -class TestKlass { - public: - static void test_oop_is_instanceClassLoader() { - Klass* klass = SystemDictionary::ClassLoader_klass(); - guarantee(klass->is_instance_klass(), "assert"); - guarantee(InstanceKlass::cast(klass)->is_class_loader_instance_klass(), "test failed"); - - klass = SystemDictionary::String_klass(); - guarantee(!klass->is_instance_klass() || - !InstanceKlass::cast(klass)->is_class_loader_instance_klass(), - "test failed"); - } -}; - -void TestKlass_test() { - TestKlass::test_oop_is_instanceClassLoader(); -} - -#endif // PRODUCT diff --git a/src/share/vm/utilities/internalVMTests.cpp b/src/share/vm/utilities/internalVMTests.cpp --- a/src/share/vm/utilities/internalVMTests.cpp +++ b/src/share/vm/utilities/internalVMTests.cpp @@ -58,7 +58,6 @@ run_unit_test(GuardedMemory_test); run_unit_test(TestNewSize_test); run_unit_test(TestOldSize_test); - run_unit_test(TestKlass_test); run_unit_test(TestBitMap_test); run_unit_test(TestResourcehash_test); run_unit_test(ObjectMonitor_test); diff --git a/test/native/runtime/test_instanceKlass.cpp b/test/native/runtime/test_instanceKlass.cpp --- a/test/native/runtime/test_instanceKlass.cpp +++ b/test/native/runtime/test_instanceKlass.cpp @@ -24,6 +24,7 @@ #include "precompiled.hpp" #include "classfile/symbolTable.hpp" +#include "classfile/systemDictionary.hpp" #include "memory/resourceArea.hpp" #include "oops/instanceKlass.hpp" #include "unittest.hpp" @@ -34,3 +35,14 @@ TempNewSymbol package_sym = InstanceKlass::package_from_name(NULL, NULL); ASSERT_TRUE(package_sym == NULL) << "Wrong package for NULL symbol"; } + +// Tests for InstanceKlass::is_class_loader_instance_klass() function +TEST_VM(InstanceKlass, class_loader_class) { + InstanceKlass* klass = SystemDictionary::ClassLoader_klass(); + ASSERT_TRUE(klass->is_class_loader_instance_klass()); +} + +TEST_VM(InstanceKlass, string_klass) { + InstanceKlass* klass = SystemDictionary::String_klass(); + ASSERT_TRUE(!klass->is_class_loader_instance_klass()); +}