Code Review for 8250902

Prepared by: Ludovic Henry on Fri Aug 07 21:13:48 PDT 2020
Compare against: https://github.com/openjdk/jdk11u
Compare against version: 637c2805
Summary of changes: 2069 lines changed; 1219 ins; 471 del; 379 mod; 50413 unchg
Patch of changes: 8250902.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/aarch64/vm_version_aarch64.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
7 lines changed; 5 ins; 0 del; 2 mod; 435 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/arm/vm_version_arm_32.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
6 lines changed; 5 ins; 0 del; 1 mod; 338 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/ppc/vm_version_ppc.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
7 lines changed; 5 ins; 0 del; 2 mod; 989 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/s390/vm_version_s390.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
7 lines changed; 5 ins; 0 del; 2 mod; 1223 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/assembler_x86.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
14 lines changed; 13 ins; 0 del; 1 mod; 9331 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/assembler_x86.hpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
3 lines changed; 2 ins; 0 del; 1 mod; 2319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86.hpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
4 lines changed; 3 ins; 0 del; 1 mod; 1816 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/cpu/x86/macroAssembler_x86_md5.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
204 lines changed; 204 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/stubGenerator_x86_32.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
45 lines changed; 44 ins; 0 del; 1 mod; 3951 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/stubGenerator_x86_64.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
42 lines changed; 41 ins; 0 del; 1 mod; 6120 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/cpu/x86/vm_version_x86.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
4 lines changed; 4 ins; 0 del; 0 mod; 1747 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
6 lines changed; 3 ins; 0 del; 3 mod; 1081 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/classfile/vmSymbols.hpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
9 lines changed; 6 ins; 2 del; 1 mod; 1660 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
2 lines changed; 1 ins; 0 del; 1 mod; 430 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/c2compiler.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
1 lines changed; 1 ins; 0 del; 0 mod; 630 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/escape.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
2 lines changed; 2 ins; 0 del; 0 mod; 3650 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/library_call.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
96 lines changed; 24 ins; 0 del; 72 mod; 6700 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
2 lines changed; 0 ins; 0 del; 2 mod; 1685 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/opto/runtime.hpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
2 lines changed; 0 ins; 0 del; 2 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/globals.hpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
4 lines changed; 3 ins; 0 del; 1 mod; 2819 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubRoutines.cpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
3 lines changed; 2 ins; 0 del; 1 mod; 578 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/runtime/stubRoutines.hpp

964db390: 8250902: Implement MD5 Intrinsics on x86  
5 lines changed; 4 ins; 0 del; 1 mod; 480 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/MD5.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
22 lines changed; 21 ins; 0 del; 1 mod; 234 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/SHA.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
3 lines changed; 0 ins; 0 del; 3 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/ProblemList-aot.txt

964db390: 8250902: Implement MD5 Intrinsics on x86  
8 lines changed; 0 ins; 8 del; 0 mod; 67 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/TestDigest.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
178 lines changed; 178 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/TestSHA.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
172 lines changed; 0 ins; 172 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/DigestOptionsBase.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
170 lines changed; 170 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/SHAOptionsBase.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
162 lines changed; 0 ins; 162 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseMD5IntrinsicsOptionOnSupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
48 lines changed; 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseMD5IntrinsicsOptionOnUnsupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
56 lines changed; 56 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA1IntrinsicsOptionOnSupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
3 lines changed; 0 ins; 0 del; 3 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA1IntrinsicsOptionOnUnsupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
7 lines changed; 0 ins; 0 del; 7 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnSupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
3 lines changed; 0 ins; 0 del; 3 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnUnsupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
7 lines changed; 0 ins; 0 del; 7 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA512IntrinsicsOptionOnSupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
3 lines changed; 0 ins; 0 del; 3 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHA512IntrinsicsOptionOnUnsupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
7 lines changed; 0 ins; 0 del; 7 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnSupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
4 lines changed; 0 ins; 0 del; 4 mod; 49 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/TestUseSHAOptionOnUnsupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
7 lines changed; 0 ins; 0 del; 7 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForOtherCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
28 lines changed; 11 ins; 0 del; 17 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForSupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
86 lines changed; 28 ins; 15 del; 43 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedAArch64CPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
45 lines changed; 13 ins; 0 del; 32 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedSparcCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
32 lines changed; 11 ins; 0 del; 21 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/GenericTestCaseForUnsupportedX86CPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
33 lines changed; 11 ins; 0 del; 22 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/UseSHAIntrinsicsSpecificTestCaseForUnsupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
6 lines changed; 0 ins; 0 del; 6 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/UseSHASpecificTestCaseForSupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
34 lines changed; 0 ins; 0 del; 34 mod; 92 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/cli/testcases/UseSHASpecificTestCaseForUnsupportedCPU.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
21 lines changed; 0 ins; 0 del; 21 mod; 78 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/DigestSanityTestBase.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
114 lines changed; 114 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/SHASanityTestBase.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
112 lines changed; 0 ins; 112 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestMD5Intrinsics.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
68 lines changed; 68 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestMD5MultiBlockIntrinsics.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
76 lines changed; 76 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1Intrinsics.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
6 lines changed; 3 ins; 0 del; 3 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1MultiBlockIntrinsics.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
12 lines changed; 5 ins; 0 del; 7 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256Intrinsics.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
6 lines changed; 3 ins; 0 del; 3 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256MultiBlockIntrinsics.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
18 lines changed; 7 ins; 0 del; 11 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512Intrinsics.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
6 lines changed; 3 ins; 0 del; 3 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA512MultiBlockIntrinsics.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
18 lines changed; 7 ins; 0 del; 11 mod; 91 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/compiler/testlibrary/sha/predicate/IntrinsicPredicates.java

964db390: 8250902: Implement MD5 Intrinsics on x86  
13 lines changed; 9 ins; 0 del; 4 mod; 119 unchg

This code review page was prepared using webrev version 9f5bf30ef5c5e4333babc17285f6f2a1688443a3