Code Review for jdk

Prepared by:mchung on Tue Oct 11 11:00:42 PDT 2016
Workspace:/scratch/mchung/ws/jdk9/jdk9-jlink-plugins/jdk
Compare against: ssh://hg.openjdk.java.net/jdk9/dev/jdk
Summary of changes: 259 lines changed: 137 ins; 26 del; 96 mod; 9165 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/spi/ToolProvider.java

18 lines changed: 4 ins; 0 del; 14 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jartool/share/classes/module-info.java

2 lines changed: 2 ins; 0 del; 0 mod; 30 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jartool/share/classes/sun/tools/jar/GNUStyleOptions.java

5 lines changed: 1 ins; 0 del; 4 mod; 323 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jartool/share/classes/sun/tools/jar/Main.java

10 lines changed: 6 ins; 0 del; 4 mod; 2246 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/JlinkTask.java

3 lines changed: 1 ins; 0 del; 2 mod; 557 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Main.java

17 lines changed: 13 ins; 2 del; 2 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jmod/JmodTask.java

3 lines changed: 1 ins; 0 del; 2 mod; 1402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/jdk/tools/jmod/Main.java

16 lines changed: 13 ins; 1 del; 2 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jlink/share/classes/module-info.java

3 lines changed: 3 ins; 0 del; 0 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/lang/module/ModuleReader/ModuleReaderTest.java

5 lines changed: 2 ins; 1 del; 2 mod; 330 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jar/ChangeDir.java

9 lines changed: 5 ins; 1 del; 3 mod; 127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jar/InputFilesTest.java

7 lines changed: 4 ins; 0 del; 3 mod; 209 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jar/JarBackSlash.java

7 lines changed: 2 ins; 1 del; 4 mod; 131 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jar/JarEntryTime.java

9 lines changed: 2 ins; 3 del; 4 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jar/UpdateJar.java

6 lines changed: 2 ins; 0 del; 4 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jar/UpdateManifest.java

22 lines changed: 3 ins; 7 del; 12 mod; 212 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jar/index/MetaInf.java

4 lines changed: 1 ins; 0 del; 3 mod; 123 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/JLinkTest.java

10 lines changed: 6 ins; 2 del; 2 mod; 293 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jlink/basic/BasicTest.java

10 lines changed: 5 ins; 1 del; 4 mod; 126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jmod/JmodNegativeTest.java

6 lines changed: 3 ins; 0 del; 3 mod; 530 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jmod/JmodTest.java

6 lines changed: 3 ins; 0 del; 3 mod; 536 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/jmod/hashes/HashesTest.java

5 lines changed: 2 ins; 1 del; 2 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/launcher/modules/basic/BasicTest.java

16 lines changed: 3 ins; 4 del; 9 mod; 243 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/launcher/modules/dryrun/DryRunTest.java

10 lines changed: 3 ins; 2 del; 5 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/tools/lib/tests/JImageGenerator.java

10 lines changed: 7 ins; 0 del; 3 mod; 750 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jartool/share/classes/sun/tools/jar/JarToolProvider.java

40 lines changed: 40 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /java/devtools/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).