Code Review for dev

Prepared by:mcimadamore on Wed Apr 17 17:00:40 IST 2019
Workspace:/w/lt/panama/dev
Branch:foreign
Summary of changes: 2130 lines changed: 606 ins; 1022 del; 502 mod; 2929 unchg
Patch of changes: dev.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/Util.java

19 lines changed: 0 ins; 19 del; 0 mod; 463 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/Argument.java

23 lines changed: 1 ins; 9 del; 13 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/ArgumentBinding.java

15 lines changed: 2 ins; 0 del; 13 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequence.java

74 lines changed: 10 ins; 41 del; 23 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/DirectSignatureShuffler.java

19 lines changed: 3 ins; 4 del; 12 mod; 408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/ShuffleRecipe.java

63 lines changed: 23 ins; 23 del; 17 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/ShuffleRecipeBuilder.java

48 lines changed: 16 ins; 13 del; 19 mod; 85 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/ShuffleRecipeClass.java

18 lines changed: 16 ins; 0 del; 2 mod; 25 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/Storage.java

10 lines changed: 10 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/StorageClass.java

15 lines changed: 0 ins; 14 del; 1 mod; 48 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/UniversalNativeInvoker.java

22 lines changed: 4 ins; 8 del; 10 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/UniversalUpcallHandler.java

25 lines changed: 3 ins; 9 del; 13 mod; 191 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/VarargsInvoker.java

61 lines changed: 51 ins; 2 del; 8 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/SysVx64ABI.java

75 lines changed: 27 ins; 9 del; 39 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/CallingSequenceBuilderImpl.java

156 lines changed: 16 ins; 89 del; 51 mod; 210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/Windowsx64ABI.java

110 lines changed: 43 ins; 43 del; 24 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/foreign/abi/x64/sysv/StandardCallTest.java

175 lines changed: 16 ins; 0 del; 159 mod; 349 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/CallingSequenceBuilder.java (was src/java.base/share/classes/jdk/internal/foreign/abi/x64/CallingSequenceBuilder.java)

152 lines changed: 26 ins; 82 del; 44 mod; 29 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/UniversalAdapter.java

38 lines changed: 38 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/x64/SharedUtils.java (was src/java.base/share/classes/jdk/internal/foreign/abi/x64/SharedConstants.java)

138 lines changed: 137 ins; 0 del; 1 mod; 32 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/CallingSequenceBuilderImpl.java (was src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/StandardCall.java)

186 lines changed: 22 ins; 111 del; 53 mod; 362 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/UnalignedStructTest.java

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/foreign/libUnalignedStruct.c

37 lines changed: 37 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/ShuffleRecipeFieldHelper.java

41 lines changed: 0 ins; 41 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/ShuffleRecipeOperationCollector.java

93 lines changed: 0 ins; 93 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/Constants.java

33 lines changed: 0 ins; 33 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/UniversalNativeInvokerImpl.java

63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/UniversalUpcallHandlerImpl.java

55 lines changed: 0 ins; 55 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/x64/sysv/VarargsInvokerImpl.java

52 lines changed: 0 ins; 52 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/Constants.java

35 lines changed: 0 ins; 35 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/UniversalNativeInvokerImpl.java

63 lines changed: 0 ins; 63 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/UniversalUpcallHandlerImpl.java

56 lines changed: 0 ins; 56 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/jdk/internal/foreign/abi/x64/windows/VarargsInvokerImpl.java

55 lines changed: 0 ins; 55 del; 0 mod; 0 unchg

This code review page was prepared using /home/maurizio/bin/webrev (vers 25.16-hg+openjdk.java.net).