Code Review for jdk

Prepared by:aboulgak on Wed Jul 27 17:28:38 PDT 2011
Workspace:/cygdrive/D/JDK/jnditl/jdk
Compare against: http://hg.openjdk.java.net/jdk8/tl/jdk
Summary of changes: 1654 lines changed: 298 ins; 181 del; 1175 mod; 39324 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/com/sun/jndi/Makefile

2 lines changed: 2 ins; 0 del; 0 mod; 40 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/javax/others/Makefile

1 line changed: 1 ins; 0 del; 0 mod; 52 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/cosnaming/CNBindingEnumeration.java

82 lines changed: 3 ins; 4 del; 75 mod; 157 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/cosnaming/CNCtx.java

39 lines changed: 6 ins; 4 del; 29 mod; 1127 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/cosnaming/CNNameParser.java

6 lines changed: 0 ins; 0 del; 6 mod; 494 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/cosnaming/ExceptionMapper.java

3 lines changed: 0 ins; 0 del; 3 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/cosnaming/IiopUrl.java

3 lines changed: 0 ins; 0 del; 3 mod; 220 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/dns/DnsClient.java

2 lines changed: 0 ins; 0 del; 2 mod; 697 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/dns/DnsContext.java

69 lines changed: 34 ins; 8 del; 27 mod; 1033 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/dns/DnsContextFactory.java

29 lines changed: 2 ins; 5 del; 22 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/dns/DnsName.java

18 lines changed: 0 ins; 6 del; 12 mod; 590 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/dns/NameNode.java

5 lines changed: 0 ins; 0 del; 5 mod; 151 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/dns/Resolver.java

5 lines changed: 0 ins; 2 del; 3 mod; 187 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/dns/ResourceRecords.java

6 lines changed: 0 ins; 0 del; 6 mod; 134 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/dns/ZoneNode.java

5 lines changed: 0 ins; 0 del; 5 mod; 200 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/Ber.java

2 lines changed: 2 ins; 0 del; 0 mod; 107 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/ClientId.java

6 lines changed: 0 ins; 0 del; 6 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/Connection.java

24 lines changed: 3 ins; 8 del; 13 mod; 992 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/DigestClientId.java

1 line changed: 0 ins; 0 del; 1 mod; 117 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/EventQueue.java

8 lines changed: 0 ins; 2 del; 6 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/EventSupport.java

25 lines changed: 4 ins; 8 del; 13 mod; 329 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapAttribute.java

13 lines changed: 2 ins; 4 del; 7 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapBindingEnumeration.java

6 lines changed: 2 ins; 0 del; 4 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapClient.java

112 lines changed: 40 ins; 37 del; 35 mod; 1531 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapCtx.java

223 lines changed: 75 ins; 26 del; 122 mod; 3393 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapCtxFactory.java

13 lines changed: 1 ins; 1 del; 11 mod; 252 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapEntry.java

3 lines changed: 0 ins; 0 del; 3 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapName.java

22 lines changed: 1 ins; 0 del; 21 mod; 996 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapNamingEnumeration.java

23 lines changed: 2 ins; 9 del; 12 mod; 419 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapPoolManager.java

12 lines changed: 0 ins; 0 del; 12 mod; 417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapReferralContext.java

48 lines changed: 11 ins; 0 del; 37 mod; 900 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapReferralException.java

6 lines changed: 1 ins; 1 del; 4 mod; 426 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapResult.java

7 lines changed: 2 ins; 0 del; 5 mod; 75 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapSchemaCtx.java

13 lines changed: 3 ins; 0 del; 10 mod; 424 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapSchemaParser.java

28 lines changed: 0 ins; 1 del; 27 mod; 1276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/LdapSearchEnumeration.java

3 lines changed: 0 ins; 0 del; 3 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/NamingEventNotifier.java

6 lines changed: 1 ins; 0 del; 5 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/NotifierArgs.java

2 lines changed: 0 ins; 0 del; 2 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/Obj.java

25 lines changed: 1 ins; 4 del; 20 mod; 635 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/ReferralEnumeration.java

1 line changed: 0 ins; 0 del; 1 mod; 31 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/ServiceLocator.java

10 lines changed: 0 ins; 5 del; 5 mod; 292 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/SimpleClientId.java

3 lines changed: 0 ins; 0 del; 3 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/UnsolicitedResponseImpl.java

1 line changed: 0 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/VersionHelper.java

1 line changed: 0 ins; 0 del; 1 mod; 77 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/VersionHelper12.java

7 lines changed: 0 ins; 0 del; 7 mod; 86 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java

12 lines changed: 0 ins; 10 del; 2 mod; 466 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/pool/Connections.java

9 lines changed: 0 ins; 0 del; 9 mod; 378 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/pool/ConnectionsWeakRef.java

3 lines changed: 1 ins; 0 del; 2 mod; 68 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/pool/Pool.java

20 lines changed: 2 ins; 7 del; 11 mod; 225 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/pool/PoolCleaner.java

2 lines changed: 0 ins; 0 del; 2 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/sasl/DefaultCallbackHandler.java

2 lines changed: 0 ins; 0 del; 2 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/ldap/sasl/LdapSasl.java

5 lines changed: 1 ins; 0 del; 4 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/rmi/registry/RegistryContext.java

27 lines changed: 8 ins; 2 del; 17 mod; 580 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/rmi/registry/RegistryContextFactory.java

5 lines changed: 0 ins; 0 del; 5 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/corba/CorbaUtils.java

8 lines changed: 0 ins; 0 del; 8 mod; 266 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/ctx/AtomicContext.java

10 lines changed: 0 ins; 1 del; 9 mod; 683 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/ctx/AtomicDirContext.java

43 lines changed: 10 ins; 1 del; 32 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/ctx/ComponentContext.java

11 lines changed: 0 ins; 2 del; 9 mod; 796 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/ctx/ComponentDirContext.java

51 lines changed: 8 ins; 2 del; 41 mod; 421 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/ctx/Continuation.java

4 lines changed: 0 ins; 0 del; 4 mod; 436 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java

18 lines changed: 0 ins; 0 del; 18 mod; 505 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeDirContext.java

37 lines changed: 3 ins; 1 del; 33 mod; 540 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/dir/ContainmentFilter.java

3 lines changed: 0 ins; 0 del; 3 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/dir/ContextEnumerator.java

7 lines changed: 0 ins; 0 del; 7 mod; 228 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/dir/DirSearch.java

3 lines changed: 0 ins; 0 del; 3 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/dir/HierMemDirCtx.java

94 lines changed: 26 ins; 0 del; 68 mod; 875 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/dir/LazySearchEnumerationImpl.java

13 lines changed: 2 ins; 0 del; 11 mod; 169 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/dir/SearchFilter.java

8 lines changed: 1 ins; 0 del; 7 mod; 667 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/url/GenericURLContext.java

15 lines changed: 5 ins; 0 del; 10 mod; 520 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/toolkit/url/GenericURLDirContext.java

1 line changed: 0 ins; 0 del; 1 mod; 410 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/url/dns/dnsURLContext.java

2 lines changed: 0 ins; 0 del; 2 mod; 72 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/url/dns/dnsURLContextFactory.java

2 lines changed: 0 ins; 0 del; 2 mod; 101 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/url/iiop/iiopURLContext.java

2 lines changed: 0 ins; 0 del; 2 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/url/iiop/iiopURLContextFactory.java

3 lines changed: 0 ins; 0 del; 3 mod; 98 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/url/ldap/ldapURLContext.java

19 lines changed: 4 ins; 0 del; 15 mod; 614 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/url/ldap/ldapURLContextFactory.java

1 line changed: 0 ins; 0 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/url/rmi/rmiURLContext.java

3 lines changed: 0 ins; 1 del; 2 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/jndi/url/rmi/rmiURLContextFactory.java

2 lines changed: 0 ins; 0 del; 2 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/naming/internal/FactoryEnumeration.java

6 lines changed: 2 ins; 0 del; 4 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/naming/internal/NamedWeakReference.java

2 lines changed: 0 ins; 0 del; 2 mod; 46 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/naming/internal/ResourceManager.java

59 lines changed: 15 ins; 5 del; 39 mod; 564 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/naming/internal/VersionHelper.java

9 lines changed: 1 ins; 1 del; 7 mod; 147 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/naming/internal/VersionHelper12.java

38 lines changed: 0 ins; 2 del; 36 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/CompositeName.java

3 lines changed: 0 ins; 0 del; 3 mod; 627 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/CompoundName.java

3 lines changed: 0 ins; 0 del; 3 mod; 621 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/InitialContext.java

5 lines changed: 4 ins; 0 del; 1 mod; 558 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/NameImpl.java

34 lines changed: 0 ins; 0 del; 34 mod; 696 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/Reference.java

8 lines changed: 0 ins; 0 del; 8 mod; 387 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/directory/BasicAttribute.java

8 lines changed: 1 ins; 0 del; 7 mod; 549 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/directory/BasicAttributes.java

11 lines changed: 1 ins; 0 del; 10 mod; 366 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/ldap/InitialLdapContext.java

4 lines changed: 1 ins; 0 del; 3 mod; 208 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/ldap/LdapName.java

24 lines changed: 0 ins; 4 del; 20 mod; 767 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/ldap/Rdn.java

22 lines changed: 0 ins; 7 del; 15 mod; 746 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/ldap/Rfc2253Parser.java

3 lines changed: 0 ins; 0 del; 3 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/ldap/StartTlsRequest.java

8 lines changed: 0 ins; 0 del; 8 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/spi/ContinuationContext.java

7 lines changed: 0 ins; 0 del; 7 mod; 239 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/spi/ContinuationDirContext.java

10 lines changed: 1 ins; 0 del; 9 mod; 324 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/spi/DirectoryManager.java

5 lines changed: 1 ins; 0 del; 4 mod; 333 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/naming/spi/NamingManager.java

11 lines changed: 1 ins; 0 del; 10 mod; 864 unchg

This code review page was prepared using /usr/bin/webrev (vers 23.18-hg).