Code Review for open

Prepared by:naoto on Fri Jan 10 15:58:15 PST 2020
Workspace:/projects/jdk/jdk/unicode/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:qparent
Summary of changes: 264 lines changed: 86 ins; 13 del; 165 mod; 31193 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/net/IDN.java

rev 57619 : [mq]: 8174270
5 lines changed: 0 ins; 0 del; 5 mod; 494 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/text/Bidi.java

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 332 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/text/CollationElementIterator.java

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 781 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/text/Normalizer.java

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 176 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/text/RBTableBuilder.java

rev 57619 : [mq]: 8174270
3 lines changed: 0 ins; 1 del; 2 mod; 611 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/CollatorUtilities.java

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 63 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/ComposedCharIter.java

rev 57619 : [mq]: 8174270
3 lines changed: 0 ins; 0 del; 3 mod; 80 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/Normalizer.java

rev 57619 : [mq]: 8174270
3 lines changed: 0 ins; 0 del; 3 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/text/Bidi/Bug6850113.java

rev 57619 : [mq]: 8174270
4 lines changed: 0 ins; 0 del; 4 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/text/Bidi/Bug7051769.java

rev 57619 : [mq]: 8174270
4 lines changed: 0 ins; 0 del; 4 mod; 84 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/text/Normalizer/ConformanceTest.java

rev 57619 : [mq]: 8174270
6 lines changed: 0 ins; 2 del; 4 mod; 523 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/text/Normalizer/ICUBasicTest.java

rev 57619 : [mq]: 8174270
6 lines changed: 0 ins; 2 del; 4 mod; 604 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/text/Normalizer/NormalizerAPITest.java

rev 57619 : [mq]: 8174270
7 lines changed: 0 ins; 0 del; 7 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/text/Normalizer/ThreadSafeTest.java

rev 57619 : [mq]: 8174270
5 lines changed: 0 ins; 0 del; 5 mod; 137 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/net/idn/NFS4StringPrep.java

rev 57619 : [mq]: 8174270
3 lines changed: 0 ins; 0 del; 3 mod; 167 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/net/idn/PunycodeTest.java

rev 57619 : [mq]: 8174270
6 lines changed: 0 ins; 1 del; 5 mod; 268 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/net/idn/TestStringPrep.java

rev 57619 : [mq]: 8174270
7 lines changed: 0 ins; 1 del; 6 mod; 279 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/BMPSet.java (was src/java.base/share/classes/sun/text/normalizer/BMPSet.java)

rev 57619 : [mq]: 8174270
5 lines changed: 1 ins; 0 del; 4 mod; 522 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/CharTrie.java (was src/java.base/share/classes/sun/text/normalizer/CharTrie.java)

rev 57619 : [mq]: 8174270
4 lines changed: 2 ins; 0 del; 2 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/CharacterIteratorWrapper.java (was src/java.base/share/classes/sun/text/normalizer/CharacterIteratorWrapper.java)

rev 57619 : [mq]: 8174270
5 lines changed: 2 ins; 0 del; 3 mod; 142 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/ICUBinary.java (was src/java.base/share/classes/sun/text/normalizer/ICUBinary.java)

rev 57619 : [mq]: 8174270
5 lines changed: 2 ins; 1 del; 2 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/Norm2AllModes.java (was src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java)

rev 57619 : [mq]: 8174270
9 lines changed: 5 ins; 0 del; 4 mod; 283 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/NormalizerImpl.java (was src/java.base/share/classes/sun/text/normalizer/NormalizerImpl.java)

rev 57619 : [mq]: 8174270
8 lines changed: 5 ins; 0 del; 3 mod; 2185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/Punycode.java (was src/java.base/share/classes/sun/net/idn/Punycode.java)

rev 57619 : [mq]: 8174270
4 lines changed: 1 ins; 0 del; 3 mod; 508 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/ReplaceableUCharacterIterator.java (was src/java.base/share/classes/sun/text/normalizer/ReplaceableUCharacterIterator.java)

rev 57619 : [mq]: 8174270
7 lines changed: 4 ins; 0 del; 3 mod; 183 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/StringPrepDataReader.java (was src/java.base/share/classes/sun/net/idn/StringPrepDataReader.java)

rev 57619 : [mq]: 8174270
4 lines changed: 1 ins; 0 del; 3 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/Trie.java (was src/java.base/share/classes/sun/text/normalizer/Trie.java)

rev 57619 : [mq]: 8174270
5 lines changed: 3 ins; 0 del; 2 mod; 362 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/Trie2.java (was src/java.base/share/classes/sun/text/normalizer/Trie2.java)

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 653 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/Trie2_16.java (was src/java.base/share/classes/sun/text/normalizer/Trie2_16.java)

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/UBiDiProps.java (was src/java.base/share/classes/sun/text/normalizer/UBiDiProps.java)

rev 57619 : [mq]: 8174270
10 lines changed: 7 ins; 0 del; 3 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/UCharacterProperty.java (was src/java.base/share/classes/sun/text/normalizer/UCharacterProperty.java)

rev 57619 : [mq]: 8174270
13 lines changed: 7 ins; 0 del; 6 mod; 601 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/UnicodeSetStringSpan.java (was src/java.base/share/classes/sun/text/normalizer/UnicodeSetStringSpan.java)

rev 57619 : [mq]: 8174270
7 lines changed: 3 ins; 0 del; 4 mod; 1161 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/Utility.java (was src/java.base/share/classes/sun/text/normalizer/Utility.java)

rev 57619 : [mq]: 8174270
6 lines changed: 3 ins; 0 del; 3 mod; 270 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/data/icudt64b/nfc.nrm (was src/java.base/share/classes/sun/text/resources/nfc.nrm)

rev 57619 : [mq]: 8174270
0 lines changed: 0 ins; 0 del; 0 mod; 91 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/data/icudt64b/nfkc.nrm (was src/java.base/share/classes/sun/text/resources/nfkc.nrm)

rev 57619 : [mq]: 8174270
0 lines changed: 0 ins; 0 del; 0 mod; 108 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/data/icudt64b/ubidi.icu (was src/java.base/share/classes/sun/text/resources/ubidi.icu)

rev 57619 : [mq]: 8174270
0 lines changed: 0 ins; 0 del; 0 mod; 1935 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/jdk/internal/icu/impl/data/icudt64b/uprops.icu (was src/java.base/share/classes/sun/text/resources/uprops.icu)

rev 57619 : [mq]: 8174270
0 lines changed: 0 ins; 0 del; 0 mod; 2255 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/lang/UCharacter.java (was src/java.base/share/classes/sun/text/normalizer/UCharacter.java)

rev 57619 : [mq]: 8174270
8 lines changed: 6 ins; 0 del; 2 mod; 537 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/lang/UCharacterDirection.java (was src/java.base/share/classes/sun/net/idn/UCharacterDirection.java)

rev 57619 : [mq]: 8174270
3 lines changed: 1 ins; 0 del; 2 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/lang/UCharacterEnums.java (was src/java.base/share/classes/sun/net/idn/UCharacterEnums.java)

rev 57619 : [mq]: 8174270
2 lines changed: 1 ins; 0 del; 1 mod; 586 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/BidiBase.java (was src/java.base/share/classes/sun/text/bidi/BidiBase.java)

rev 57619 : [mq]: 8174270
6 lines changed: 1 ins; 1 del; 4 mod; 4775 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/BidiLine.java (was src/java.base/share/classes/sun/text/bidi/BidiLine.java)

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 833 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/BidiRun.java (was src/java.base/share/classes/sun/text/bidi/BidiRun.java)

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 122 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/BidiWriter.java (was src/java.base/share/classes/sun/text/bidi/BidiWriter.java)

rev 57619 : [mq]: 8174270
4 lines changed: 0 ins; 1 del; 3 mod; 448 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/FilteredNormalizer2.java (was src/java.base/share/classes/sun/text/normalizer/FilteredNormalizer2.java)

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 264 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/Normalizer2.java (was src/java.base/share/classes/sun/text/normalizer/Normalizer2.java)

rev 57619 : [mq]: 8174270
5 lines changed: 2 ins; 0 del; 3 mod; 270 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/NormalizerBase.java (was src/java.base/share/classes/sun/text/normalizer/NormalizerBase.java)

rev 57619 : [mq]: 8174270
4 lines changed: 2 ins; 0 del; 2 mod; 780 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/Replaceable.java (was src/java.base/share/classes/sun/text/normalizer/Replaceable.java)

rev 57619 : [mq]: 8174270
3 lines changed: 0 ins; 0 del; 3 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/ReplaceableString.java (was src/java.base/share/classes/sun/text/normalizer/ReplaceableString.java)

rev 57619 : [mq]: 8174270
3 lines changed: 0 ins; 0 del; 3 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java (was src/java.base/share/classes/sun/net/idn/StringPrep.java)

rev 57619 : [mq]: 8174270
10 lines changed: 1 ins; 2 del; 7 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/UCharacterIterator.java (was src/java.base/share/classes/sun/text/normalizer/UCharacterIterator.java)

rev 57619 : [mq]: 8174270
6 lines changed: 4 ins; 0 del; 2 mod; 311 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/UTF16.java (was src/java.base/share/classes/sun/text/normalizer/UTF16.java)

rev 57619 : [mq]: 8174270
4 lines changed: 2 ins; 0 del; 2 mod; 614 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/text/UnicodeSet.java (was src/java.base/share/classes/sun/text/normalizer/UnicodeSet.java)

rev 57619 : [mq]: 8174270
12 lines changed: 8 ins; 1 del; 3 mod; 1403 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/util/CodePointMap.java (was src/java.base/share/classes/sun/text/normalizer/CodePointMap.java)

rev 57619 : [mq]: 8174270
2 lines changed: 0 ins; 0 del; 2 mod; 499 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/util/CodePointTrie.java (was src/java.base/share/classes/sun/text/normalizer/CodePointTrie.java)

rev 57619 : [mq]: 8174270
5 lines changed: 2 ins; 0 del; 3 mod; 1307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/util/OutputInt.java (was src/java.base/share/classes/sun/text/normalizer/OutputInt.java)

rev 57619 : [mq]: 8174270
3 lines changed: 0 ins; 0 del; 3 mod; 47 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/jdk/internal/icu/util/VersionInfo.java (was src/java.base/share/classes/sun/text/normalizer/VersionInfo.java)

rev 57619 : [mq]: 8174270
12 lines changed: 10 ins; 0 del; 2 mod; 183 unchg

This code review page was prepared using /projects/tools/webrev.ksh (vers 25.17-hg+openjdk.java.net).