Code Review for open

Prepared by:naoto on Wed May 22 15:34:13 PDT 2019
Workspace:/projects/jdk/jdk/unicode/open
Compare against: ssh://hg.openjdk.java.net/jdk/jdk
Compare against version:qparent
Summary of changes: 97421 lines changed: 59378 ins; 37277 del; 766 mod; 69172 unchg
Patch of changes: open.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/CompileJavaModules.gmk

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 684 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/ToolsJdk.gmk

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
4 lines changed: 3 ins; 0 del; 1 mod; 125 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/characterdata/CharacterData00.java.template

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
7 lines changed: 6 ins; 0 del; 1 mod; 1093 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/characterdata/CharacterData01.java.template

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
54 lines changed: 37 ins; 0 del; 17 mod; 488 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/PropList.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
55 lines changed: 29 ins; 4 del; 22 mod; 1615 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/Scripts.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
126 lines changed: 70 ins; 12 del; 44 mod; 2724 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/SpecialCasing.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
3 lines changed: 0 ins; 0 del; 3 mod; 278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/UnicodeData.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
557 lines changed: 548 ins; 0 del; 9 mod; 32284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/VERSION

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
1 line changed: 0 ins; 0 del; 1 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/gensrc/Gensrc-java.base.gmk

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
1 line changed: 1 ins; 0 del; 0 mod; 106 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/lang/Character.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
488 lines changed: 229 ins; 49 del; 210 mod; 10664 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/regex/Grapheme.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
104 lines changed: 73 ins; 2 del; 29 mod; 174 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/regex/Pattern.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
29 lines changed: 1 ins; 22 del; 6 mod; 5942 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/normalizer/ICUBinary.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
35 lines changed: 30 ins; 3 del; 2 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
2 lines changed: 0 ins; 0 del; 2 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/normalizer/NormalizerImpl.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
92 lines changed: 14 ins; 30 del; 48 mod; 2126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/resources/ubidi.icu

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/src/java.base/share/classes/sun/text/resources/ubidi.icu new/src/java.base/share/classes/sun/text/resources/ubidi.icu`: $?=0, err= 1

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/resources/uprops.icu

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/src/java.base/share/classes/sun/text/resources/uprops.icu new/src/java.base/share/classes/sun/text/resources/uprops.icu`: $?=0, err= 1

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/legal/icu.md

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
382 lines changed: 350 ins; 27 del; 5 mod; 34 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/legal/unicode.md

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
23 lines changed: 0 ins; 16 del; 7 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Character/CharPropTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
8 lines changed: 1 ins; 4 del; 3 mod; 281 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Character/CheckProp.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
4 lines changed: 1 ins; 0 del; 3 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Character/CheckScript.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
5 lines changed: 1 ins; 0 del; 4 mod; 154 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Character/CheckUnicode.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
38 lines changed: 1 ins; 25 del; 12 mod; 74 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Character/UnicodeBlock/CheckBlocks.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
7 lines changed: 3 ins; 1 del; 3 mod; 342 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Character/UnicodeBlock/OptimalMapSize.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
5 lines changed: 1 ins; 0 del; 4 mod; 66 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/Character/UnicodeCasingTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
5 lines changed: 1 ins; 1 del; 3 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/String/SpecialCasingTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
5 lines changed: 2 ins; 1 del; 2 mod; 351 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/lang/String/UnicodeCasingTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
7 lines changed: 1 ins; 2 del; 4 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/regex/GraphemeTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
202 lines changed: 135 ins; 37 del; 30 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/util/regex/RegExTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
4 lines changed: 1 ins; 1 del; 2 mod; 4932 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/Blocks.txt (was test/jdk/java/lang/Character/UnicodeBlock/Blocks.txt)

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
12 lines changed: 9 ins; 0 del; 3 mod; 324 unchg

------ ------ ------ ------ --- New Patch Raw make/data/unicodedata/NormalizationTest.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
18875 lines changed: 18875 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/PropertyValueAliases.txt (was test/jdk/java/lang/Character/PropertyValueAliases.txt)

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
27 lines changed: 19 ins; 0 del; 8 mod; 1515 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/auxiliary/GraphemeBreakProperty.txt (was test/jdk/java/util/regex/GraphemeBreakProperty.txt)

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
130 lines changed: 102 ins; 9 del; 19 mod; 1308 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/data/unicodedata/auxiliary/GraphemeBreakTest.txt (was test/jdk/java/util/regex/GraphemeBreakTest.txt)

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
529 lines changed: 236 ins; 35 del; 258 mod; 136 unchg

------ ------ ------ ------ --- New Patch Raw make/data/unicodedata/emoji-data.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
769 lines changed: 769 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/gensrc/GensrcEmojiData.gmk

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
44 lines changed: 44 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw make/jdk/src/classes/build/tools/generateemojidata/GenerateEmojiData.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
142 lines changed: 142 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/java/util/regex/EmojiData.java.template

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
46 lines changed: 46 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/text/normalizer/CodePointMap.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
501 lines changed: 501 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/java.base/share/classes/sun/text/normalizer/CodePointTrie.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
1310 lines changed: 1310 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/resources/nfc.nrm (was src/java.base/share/classes/sun/text/resources/nfc.icu)

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/src/java.base/share/classes/sun/text/resources/nfc.icu new/src/java.base/share/classes/sun/text/resources/nfc.nrm`: $?=0, err= 1

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/text/resources/nfkc.nrm (was src/java.base/share/classes/sun/text/resources/nfkc.icu)

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/src/java.base/share/classes/sun/text/resources/nfkc.icu new/src/java.base/share/classes/sun/text/resources/nfkc.nrm`: $?=0, err= 1

------ ------ ------ ------ --- New Patch Raw test/jdk/java/text/Normalizer/ConformanceTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
529 lines changed: 529 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/text/Normalizer/DataValidationTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
447 lines changed: 447 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/text/Normalizer/ICUBasicTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
610 lines changed: 610 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/text/Normalizer/ICUNormalizationTest.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
11 lines changed: 11 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/text/Normalizer/NormalizationTest-3.2.0.Corrigendum4.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
17035 lines changed: 17035 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/text/Normalizer/NormalizationTest-3.2.0.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
17035 lines changed: 17035 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/java/text/Normalizer/SquareEraCharacterTest.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/lib/testlibrary/java/lang/UCDFiles.java

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/java.base/share/classes/sun/text/resources/nfkc_cf.icu

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/src/java.base/share/classes/sun/text/resources/nfkc_cf.icu /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/PropList.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
1641 lines changed: 0 ins; 1641 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/Scripts.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
2781 lines changed: 0 ins; 2781 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/SpecialCasing.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
281 lines changed: 0 ins; 281 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/UnicodeData.txt

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
32293 lines changed: 0 ins; 32293 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/charprop00.bin

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/test/jdk/java/lang/Character/charprop00.bin /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/charprop01.bin

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/test/jdk/java/lang/Character/charprop01.bin /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/charprop02.bin

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/test/jdk/java/lang/Character/charprop02.bin /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/charprop03.bin

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/test/jdk/java/lang/Character/charprop03.bin /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/charprop0E.bin

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/test/jdk/java/lang/Character/charprop0E.bin /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/charprop0F.bin

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/test/jdk/java/lang/Character/charprop0F.bin /dev/null`: $?=0, err= 1

------ ------ ------ ------ Old --- Patch --- test/jdk/java/lang/Character/charprop10.bin

rev 54996 : 8221431: Support for Unicode 12.1
Reviewed-by:
Unexpected Error occurred reading `diff -e old/test/jdk/java/lang/Character/charprop10.bin /dev/null`: $?=0, err= 1

This code review page was prepared using /projects/tools/webrev.ksh (vers 25.17-hg+openjdk.java.net).