| Prepared by: | never on Fri Jul 8 15:22:46 PDT 2011 |
|---|---|
| Workspace: | /export/ws/indy |
| Compare against: | ssh://hg.openjdk.java.net/hsx/hotspot-comp-gate/hotspot |
| Summary of changes: | 564 lines changed: 285 ins; 193 del; 86 mod; 7784 unchg |
| Patch of changes: | 7012081.patch |
| Author comments: |
7012081: JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries Summary: Reviewed-by: There we a bunch of changes to the constant pool and bytecode classes which were never reflected in the SA so it would break when looking at classes using 292 features. The fix is simply to make the SA code mirror the JVM code again. Primarily this was the code dealing with the size of index values for various bytecodes. The generateOopMap.cpp change is purely a formatting change to make it more regular. After these changes some of the tests still fail but this is because of test bugs that will be fixed separately. Tested with failing tests including the tmtools and sajdi suites which exercises the SA extensively. |
| Bug id: | 7012081 JSR 292: SA-JDI can't read MH/MT/Indy ConstantPool entries |
| Legend: |
Modified file Deleted file New file |
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecode.java
18 lines changed: 18 ins; 0 del; 0 mod; 99 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java
29 lines changed: 13 ins; 4 del; 12 mod; 216 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeStream.java
8 lines changed: 6 ins; 0 del; 2 mod; 137 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeWideable.java
2 lines changed: 0 ins; 1 del; 1 mod; 42 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeWithCPIndex.java
1 line changed: 0 ins; 0 del; 1 mod; 57 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/interpreter/Bytecodes.java
141 lines changed: 120 ins; 5 del; 16 mod; 708 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/oops/ConstMethod.java
27 lines changed: 27 ins; 0 del; 0 mod; 397 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPool.java
62 lines changed: 49 ins; 10 del; 3 mod; 619 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/oops/ConstantPoolCache.java
15 lines changed: 6 ins; 2 del; 7 mod; 122 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/oops/GenerateOopMap.java
34 lines changed: 2 ins; 13 del; 19 mod; 2295 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/oops/Method.java
12 lines changed: 12 ins; 0 del; 0 mod; 324 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/oops/TypeArray.java
3 lines changed: 3 ins; 0 del; 0 mod; 151 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
agent/src/share/classes/sun/jvm/hotspot/utilities/ConstantTag.java
53 lines changed: 29 ins; 0 del; 24 mod; 78 unchg
------ ------ ------
------
Old
---
Patch
---
agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastAAccess0.java
78 lines changed: 0 ins; 78 del; 0 mod; 0 unchg
------ ------ ------
------
Old
---
Patch
---
agent/src/share/classes/sun/jvm/hotspot/interpreter/BytecodeFastIAccess0.java
78 lines changed: 0 ins; 78 del; 0 mod; 0 unchg
Cdiffs
Udiffs
Sdiffs
Frames
Old
New
Patch
Raw
src/share/vm/oops/generateOopMap.cpp
3 lines changed: 0 ins; 2 del; 1 mod; 2539 unchg
This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).