Code Review for 7092278

Prepared by:never on Wed Sep 28 10:42:50 PDT 2011
Workspace:/net/smite.us.oracle.com/export/ws/synth
Compare against: ssh://hg.openjdk.java.net/hsx/hotspot-comp-gate/hotspot
Summary of changes: 141 lines changed: 110 ins; 9 del; 22 mod; 5997 unchg
Patch of changes: 7092278.patch
Author comments:
7092278: "jmap -finalizerinfo" throws "sun.jvm.hotspot.utilities.AssertionFailure: invalid cp index 0 137"
Reviewed-by:

There's was a mismatch between using scaled and unscaled indexes to
refer to fields in the SA because I hadn't completly hidden access to
the fields. I also added proper support for reading the internal
field names though that's currently not need for these tests. Tested
with tmtools suite, including the failing test.

Bug id: 7092278 "jmap -finalizerinfo" throws "sun.jvm.hotspot.utilities.AssertionFailure: invalid cp index 0 137"
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java

54 lines changed: 34 ins; 7 del; 13 mod; 917 unchg

------ ------ ------ ------ --- New Patch Raw agent/src/share/classes/sun/jvm/hotspot/runtime/vmSymbols.java

61 lines changed: 61 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java

10 lines changed: 0 ins; 2 del; 8 mod; 720 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/classfile/vmSymbols.hpp

2 lines changed: 1 ins; 0 del; 1 mod; 1126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/vmStructs.cpp

14 lines changed: 14 ins; 0 del; 0 mod; 3234 unchg

This code review page was prepared using /never/bin/webrev (vers 23.18-hg-never).