src/share/vm/gc_implementation/g1/satbQueue.hpp

Print this page
rev 5695 : 8029162: G1: Shared SATB queue never enabled
Reviewed-by:

@@ -85,11 +85,12 @@
   // "par" is true, then "worker" is the par thread id; if "false", worker
   // is ignored.
   bool apply_closure_to_completed_buffer_work(bool par, int worker);
 
 #ifdef ASSERT
-  void dump_active_values(JavaThread* first, bool expected_active);
+  void dump_active_states(bool expected_active);
+  void verify_active_states(bool expected_active);
 #endif // ASSERT
 
 public:
   SATBMarkQueueSet();
 

@@ -97,15 +98,15 @@
                   int process_completed_threshold,
                   Mutex* lock);
 
   static void handle_zero_index_for_thread(JavaThread* t);
 
-  // Apply "set_active(b)" to all Java threads' SATB queues. It should be
+  // Apply "set_active(active)" to all SATB queues in the set. It should be
   // called only with the world stopped. The method will assert that the
   // SATB queues of all threads it visits, as well as the SATB queue
   // set itself, has an active value same as expected_active.
-  void set_active_all_threads(bool b, bool expected_active);
+  void set_active_all_threads(bool active, bool expected_active);
 
   // Filter all the currently-active SATB buffers.
   void filter_thread_buffers();
 
   // Register "blk" as "the closure" for all queues.  Only one such closure