Code Review for open

Prepared by:pliden on Wed Jun 3 14:05:44 CEST 2020
Workspace:/home/pliden/openjdk/repos/jdk/open
Compare against version:conditionlock
Summary of changes: 1719 lines changed: 782 ins; 472 del; 465 mod; 9291 unchg
Patch of changes: open.patch
Bug id: JDK-8245208 : ZGC: Don't hold the ZPageAllocator lock while committing/uncommitting memory
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/gc/z/zPhysicalMemoryBacking_bsd.cpp

10 lines changed: 3 ins; 0 del; 7 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/bsd/gc/z/zPhysicalMemoryBacking_bsd.hpp

5 lines changed: 0 ins; 0 del; 5 mod; 43 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/gc/z/zPhysicalMemoryBacking_linux.cpp

28 lines changed: 3 ins; 0 del; 25 mod; 697 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/linux/gc/z/zPhysicalMemoryBacking_linux.hpp

16 lines changed: 0 ins; 0 del; 16 mod; 61 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/gc/z/zMapper_windows.cpp

7 lines changed: 3 ins; 0 del; 4 mod; 250 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/gc/z/zMapper_windows.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/gc/z/zPhysicalMemoryBacking_windows.cpp

11 lines changed: 8 ins; 0 del; 3 mod; 118 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/os/windows/gc/z/zPhysicalMemoryBacking_windows.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/vmStructs_z.hpp

3 lines changed: 0 ins; 0 del; 3 mod; 121 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zAllocationFlags.hpp

25 lines changed: 11 ins; 0 del; 14 mod; 82 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zArguments.cpp

13 lines changed: 12 ins; 0 del; 1 mod; 113 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zDirector.cpp

1 line changed: 0 ins; 0 del; 1 mod; 241 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zFuture.hpp

2 lines changed: 0 ins; 1 del; 1 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zFuture.inline.hpp

6 lines changed: 0 ins; 5 del; 1 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeap.cpp

29 lines changed: 5 ins; 19 del; 5 mod; 512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeap.hpp

8 lines changed: 1 ins; 5 del; 2 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeuristics.cpp

12 lines changed: 8 ins; 4 del; 0 mod; 97 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zHeuristics.hpp

3 lines changed: 2 ins; 0 del; 1 mod; 38 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zInitialize.cpp

2 lines changed: 0 ins; 1 del; 1 mod; 55 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zMemory.cpp

12 lines changed: 11 ins; 0 del; 1 mod; 222 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zMemory.hpp

3 lines changed: 2 ins; 0 del; 1 mod; 90 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.cpp

23 lines changed: 22 ins; 0 del; 1 mod; 110 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.hpp

8 lines changed: 3 ins; 4 del; 1 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPage.inline.hpp

17 lines changed: 4 ins; 11 del; 2 mod; 300 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageAllocator.cpp

643 lines changed: 268 ins; 150 del; 225 mod; 422 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageAllocator.hpp

49 lines changed: 21 ins; 13 del; 15 mod; 103 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageCache.cpp

123 lines changed: 105 ins; 13 del; 5 mod; 247 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPageCache.hpp

23 lines changed: 5 ins; 15 del; 3 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPhysicalMemory.cpp

343 lines changed: 223 ins; 54 del; 66 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPhysicalMemory.hpp

33 lines changed: 19 ins; 4 del; 10 mod; 89 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zPhysicalMemory.inline.hpp

16 lines changed: 10 ins; 0 del; 6 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zUncommitter.cpp

39 lines changed: 0 ins; 35 del; 4 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zUncommitter.hpp

8 lines changed: 0 ins; 7 del; 1 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zVirtualMemory.cpp

6 lines changed: 1 ins; 1 del; 4 mod; 165 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/z/zVirtualMemory.hpp

2 lines changed: 0 ins; 0 del; 2 mod; 70 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/jfr/metadata/metadata.xml

10 lines changed: 0 ins; 7 del; 3 mod; 1326 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jfr/share/conf/jfr/default.jfc

6 lines changed: 0 ins; 6 del; 0 mod; 982 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jfr/share/conf/jfr/profile.jfc

6 lines changed: 0 ins; 6 del; 0 mod; 982 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/z/test_zForwarding.cpp

2 lines changed: 0 ins; 0 del; 2 mod; 196 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/gtest/gc/z/test_zPhysicalMemory.cpp

46 lines changed: 32 ins; 0 del; 14 mod; 128 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/hotspot/jtreg/gc/z/TestUncommit.java

11 lines changed: 0 ins; 6 del; 5 mod; 124 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/jfr/EventNames.java

1 line changed: 0 ins; 1 del; 0 mod; 214 unchg

------ ------ ------ ------ Old --- Patch --- src/hotspot/share/gc/z/zPageCache.inline.hpp

35 lines changed: 0 ins; 35 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/jdk/jfr/event/gc/detailed/TestZPageCacheFlushEvent.java

69 lines changed: 0 ins; 69 del; 0 mod; 0 unchg

This code review page was prepared using /home/pliden/openjdk/tools/webrev/webrev/webrev.ksh (vers 25.17-hg+openjdk.java.net).