Code Review for jdk

Prepared by:psandoz on Tue Sep 29 15:54:57 CEST 2015
Workspace:/Users/sandoz/Projects/jdk9/dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:-2
Summary of changes: 452 lines changed: 107 ins; 21 del; 324 mod; 1256 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/Optional.java

rev 12783 : 8080418: Add Optional.or()
Reviewed-by: chegar, forax, scolebourne
rev 11660 : 8075560: Typo in Javadoc for java.util.Optional.equals()
Reviewed-by: alanb
rev 11400 : 8071670: java.util.Optional: please add a way to specify if-else behavior
Reviewed-by: dfuchs, lowasser
rev 11342 : 8050820: Please add java.util.Optional.stream() to convert Optional<T> to Stream<T>
Reviewed-by: alundblad, forax, chegar, jrose
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
150 lines changed: 38 ins; 3 del; 109 mod; 282 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/OptionalDouble.java

rev 12783 : 8080418: Add Optional.or()
Reviewed-by: chegar, forax, scolebourne
rev 11660 : 8075560: Typo in Javadoc for java.util.Optional.equals()
Reviewed-by: alanb
rev 11400 : 8071670: java.util.Optional: please add a way to specify if-else behavior
Reviewed-by: dfuchs, lowasser
rev 11342 : 8050820: Please add java.util.Optional.stream() to convert Optional<T> to Stream<T>
Reviewed-by: alundblad, forax, chegar, jrose
rev 11341 : 8059324: orElseThrow has different signatures for OptionalPrimitive and Optional<T>
Reviewed-by: lancea, chegar
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
87 lines changed: 9 ins; 4 del; 74 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/OptionalInt.java

rev 12783 : 8080418: Add Optional.or()
Reviewed-by: chegar, forax, scolebourne
rev 11660 : 8075560: Typo in Javadoc for java.util.Optional.equals()
Reviewed-by: alanb
rev 11400 : 8071670: java.util.Optional: please add a way to specify if-else behavior
Reviewed-by: dfuchs, lowasser
rev 11342 : 8050820: Please add java.util.Optional.stream() to convert Optional<T> to Stream<T>
Reviewed-by: alundblad, forax, chegar, jrose
rev 11341 : 8059324: orElseThrow has different signatures for OptionalPrimitive and Optional<T>
Reviewed-by: lancea, chegar
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
87 lines changed: 10 ins; 7 del; 70 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/OptionalLong.java

rev 12783 : 8080418: Add Optional.or()
Reviewed-by: chegar, forax, scolebourne
rev 11660 : 8075560: Typo in Javadoc for java.util.Optional.equals()
Reviewed-by: alanb
rev 11400 : 8071670: java.util.Optional: please add a way to specify if-else behavior
Reviewed-by: dfuchs, lowasser
rev 11342 : 8050820: Please add java.util.Optional.stream() to convert Optional<T> to Stream<T>
Reviewed-by: alundblad, forax, chegar, jrose
rev 11341 : 8059324: orElseThrow has different signatures for OptionalPrimitive and Optional<T>
Reviewed-by: lancea, chegar
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
88 lines changed: 10 ins; 7 del; 71 mod; 218 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/java/util/Optional/Basic.java

rev 12783 : 8080418: Add Optional.or()
Reviewed-by: chegar, forax, scolebourne
rev 11400 : 8071670: java.util.Optional: please add a way to specify if-else behavior
Reviewed-by: dfuchs, lowasser
rev 11342 : 8050820: Please add java.util.Optional.stream() to convert Optional<T> to Stream<T>
Reviewed-by: alundblad, forax, chegar, jrose
rev 7675 : 8015317: Optional.filter, map, and flatMap
Reviewed-by: psandoz, mduigou
Contributed-by: brian.goetz@oracle.com, henry.jen@oracle.com
rev 6798 : 8001642: Add Optional<T>, OptionalDouble, OptionalInt, OptionalLong
Reviewed-by: mduigou, darcy, alanb, jjb
Contributed-by: Brian Goetz <brian.goetz@oracle.com>
40 lines changed: 40 ins; 0 del; 0 mod; 319 unchg

This code review page was prepared using /Users/sandoz/Projects/jdk/tools/webrev/webrev.ksh (vers 25.12-hg+openjdk.java.net).