Code Review for jdk

Prepared by:psandoz on Thu Jul 30 18:29:28 CEST 2015
Workspace:/Users/sandoz/Projects/jdk9/dev/jdk
Compare against: http://hg.openjdk.java.net/jdk9/dev/jdk
Compare against version:-2
Summary of changes: 26 lines changed: 8 ins; 2 del; 16 mod; 6430 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/stream/Collector.java

rev 12482 : 8130828: Fix some typos and omissions in the the j.u.stream JavaDoc
Reviewed-by:
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
1 line changed: 0 ins; 0 del; 1 mod; 340 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/stream/DoubleStream.java

rev 12482 : 8130828: Fix some typos and omissions in the the j.u.stream JavaDoc
Reviewed-by:
rev 12324 : 8071597: Add Stream dropWhile and takeWhile operations
Reviewed-by: briangoetz, smarks, chegar, forax
rev 11609 : 8067969: Optimize Stream.count for SIZED Streams
Reviewed-by: psandoz, chegar
Contributed-by: Aggelos Biboudis <biboudis@gmail.com>
rev 11485 : 8073779: StackOverflowError called StackOverflowException in javadoc
Reviewed-by: martin
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 1065 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/stream/IntStream.java

rev 12482 : 8130828: Fix some typos and omissions in the the j.u.stream JavaDoc
Reviewed-by:
rev 12324 : 8071597: Add Stream dropWhile and takeWhile operations
Reviewed-by: briangoetz, smarks, chegar, forax
rev 11609 : 8067969: Optimize Stream.count for SIZED Streams
Reviewed-by: psandoz, chegar
Contributed-by: Aggelos Biboudis <biboudis@gmail.com>
rev 11485 : 8073779: StackOverflowError called StackOverflowException in javadoc
Reviewed-by: martin
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 1057 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/stream/LongStream.java

rev 12482 : 8130828: Fix some typos and omissions in the the j.u.stream JavaDoc
Reviewed-by:
rev 12324 : 8071597: Add Stream dropWhile and takeWhile operations
Reviewed-by: briangoetz, smarks, chegar, forax
rev 11609 : 8067969: Optimize Stream.count for SIZED Streams
Reviewed-by: psandoz, chegar
Contributed-by: Aggelos Biboudis <biboudis@gmail.com>
rev 11485 : 8073779: StackOverflowError called StackOverflowException in javadoc
Reviewed-by: martin
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 1062 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/stream/SliceOps.java

rev 12482 : 8130828: Fix some typos and omissions in the the j.u.stream JavaDoc
Reviewed-by:
rev 12324 : 8071597: Add Stream dropWhile and takeWhile operations
Reviewed-by: briangoetz, smarks, chegar, forax
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
1 line changed: 0 ins; 0 del; 1 mod; 709 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/stream/Stream.java

rev 12482 : 8130828: Fix some typos and omissions in the the j.u.stream JavaDoc
Reviewed-by:
rev 12324 : 8071597: Add Stream dropWhile and takeWhile operations
Reviewed-by: briangoetz, smarks, chegar, forax
rev 11609 : 8067969: Optimize Stream.count for SIZED Streams
Reviewed-by: psandoz, chegar
Contributed-by: Aggelos Biboudis <biboudis@gmail.com>
rev 11561 : 8073923: Files.lines() documentation needs clarification
Reviewed-by: darcy, alanb
rev 11485 : 8073779: StackOverflowError called StackOverflowException in javadoc
Reviewed-by: martin
rev 11379 : 8050819: Please add java.util.Stream.ofNullable(T object)
Reviewed-by: alanb, smarks
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
4 lines changed: 2 ins; 0 del; 2 mod; 1307 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/java/util/stream/Streams.java

rev 12482 : 8130828: Fix some typos and omissions in the the j.u.stream JavaDoc
Reviewed-by:
rev 12351 : 8076112: Add @HotSpotIntrinsicCandidate annotation to indicate methods for which Java Runtime has intrinsics
Summary: Annotate possibly intrinsified methods with @HotSpotIntrinsicCandidate. Add checks omitted by intrinsics to the library code. Add CheckIntrinsics flags to check consistency of intrinsics.
Reviewed-by: jrose, kvn, thartmann, vlivanov, abuckley, darcy, ascarpino, briangoetz, alanb, aph, dnsimon
rev 10469 : 8054834: Modular Source Code
Reviewed-by: alanb, chegar, ihse, mduigou
Contributed-by: alan.bateman@oracle.com, alex.buckley@oracle.com, chris.hegarty@oracle.com, erik.joelsson@oracle.com, jonathan.gibbons@oracle.com, karen.kinnear@oracle.com, magnus.ihse.bursie@oracle.com, mandy.chung@oracle.com, mark.reinhold@oracle.com, paul.sandoz@oracle.com
8 lines changed: 0 ins; 2 del; 6 mod; 890 unchg

This code review page was prepared using /Users/sandoz/Projects/jdk/tools/webrev/webrev.ksh (vers 25.11-hg+openjdk.java.net).