Code Review for vectorIntrinsics

Prepared by:psandoz psandoz on Thu May 14 16:08:03 PDT 2020
Workspace:/Users/sandoz/Projects/jdk/vectorIntrinsics
Compare against: ssh://hg.openjdk.java.net/panama/dev
Compare against version:-2
Branch:vectorIntrinsics
Summary of changes: 1143 lines changed: 1138 ins; 5 del; 0 mod; 58374 unchg
Patch of changes: vectorIntrinsics.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
7 lines changed: 7 ins; 0 del; 0 mod; 3693 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.vector/share/classes/jdk/incubator/vector/DoubleVector.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
8 lines changed: 7 ins; 1 del; 0 mod; 3648 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.vector/share/classes/jdk/incubator/vector/FloatVector.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
8 lines changed: 7 ins; 1 del; 0 mod; 3615 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.vector/share/classes/jdk/incubator/vector/IntVector.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
8 lines changed: 7 ins; 1 del; 0 mod; 3737 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.vector/share/classes/jdk/incubator/vector/LongVector.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
8 lines changed: 7 ins; 1 del; 0 mod; 3631 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ShortVector.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
8 lines changed: 7 ins; 1 del; 0 mod; 3707 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Vector.java

rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
4 lines changed: 4 ins; 0 del; 0 mod; 3628 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
7 lines changed: 7 ins; 0 del; 0 mod; 4319 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Byte128VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 904 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Byte256VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 904 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Byte512VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 904 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Byte64VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 904 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/ByteMaxVectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 913 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Double128VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Double256VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Double512VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Double64VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/DoubleMaxVectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 924 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Float128VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Float256VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Float512VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Float64VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/FloatMaxVectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 924 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Int128VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Int256VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Int512VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Int64VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/IntMaxVectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 924 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Long128VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Long256VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Long512VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Long64VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/LongMaxVectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 924 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Short128VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Short256VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Short512VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/Short64VectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/ShortMaxVectorLoadStoreTests.java

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 924 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jdk/incubator/vector/templates/X-LoadStoreTest.java.template

rev 61202 : Unify load/store code and add test.
Reviewed-by:
rev 61203 : Ensure stores to RO buffer throw exception.
Reviewed-by:
35 lines changed: 35 ins; 0 del; 0 mod; 947 unchg

This code review page was prepared using /Users/sandoz/Projects/jdk/tools/webrev/webrev.ksh (vers 25.18-hg+openjdk.java.net).