--- old/src/hotspot/share/runtime/deoptimization.cpp 2019-08-28 08:35:04.702468786 +0200 +++ new/src/hotspot/share/runtime/deoptimization.cpp 2019-08-28 08:35:04.379457775 +0200 @@ -779,10 +779,35 @@ return bt; JRT_END +class DeoptimizeMarkedTC : public ThreadClosure { + bool _in_handshake; + public: + DeoptimizeMarkedTC(bool in_handshake) : _in_handshake(in_handshake) {} + virtual void do_thread(Thread* thread) { + assert(thread->is_Java_thread(), "must be"); + JavaThread* jt = (JavaThread*)thread; + jt->deoptimize_marked_methods(_in_handshake); + } +}; + +void Deoptimization::deoptimize_all_marked() { + ResourceMark rm; + DeoptimizationMarker dm; -int Deoptimization::deoptimize_dependents() { - Threads::deoptimized_wrt_marked_nmethods(); - return 0; + if (SafepointSynchronize::is_at_safepoint()) { + DeoptimizeMarkedTC deopt(false); + // Make the dependent methods not entrant + CodeCache::make_marked_nmethods_not_entrant(); + Threads::java_threads_do(&deopt); + } else { + // Make the dependent methods not entrant + { + MutexLocker mu(CodeCache_lock, Mutex::_no_safepoint_check_flag); + CodeCache::make_marked_nmethods_not_entrant(); + } + DeoptimizeMarkedTC deopt(true); + Handshake::execute(&deopt); + } } Deoptimization::DeoptAction Deoptimization::_unloaded_action @@ -1397,14 +1422,7 @@ } } - -void Deoptimization::revoke_biases_of_monitors(JavaThread* thread, frame fr, RegisterMap* map) { - if (!UseBiasedLocking) { - return; - } - - GrowableArray* objects_to_revoke = new GrowableArray(); - +static void get_monitors_from_stack(GrowableArray* objects_to_revoke, JavaThread* thread, frame fr, RegisterMap* map) { // Unfortunately we don't have a RegisterMap available in most of // the places we want to call this routine so we need to walk the // stack again to update the register map. @@ -1428,6 +1446,14 @@ cvf = compiledVFrame::cast(cvf->sender()); } collect_monitors(cvf, objects_to_revoke); +} + +void Deoptimization::revoke_using_safepoint(JavaThread* thread, frame fr, RegisterMap* map) { + if (!UseBiasedLocking) { + return; + } + GrowableArray* objects_to_revoke = new GrowableArray(); + get_monitors_from_stack(objects_to_revoke, thread, fr, map); if (SafepointSynchronize::is_at_safepoint()) { BiasedLocking::revoke_at_safepoint(objects_to_revoke); @@ -1436,6 +1462,21 @@ } } +void Deoptimization::revoke_using_handshake(JavaThread* thread, frame fr, RegisterMap* map) { + if (!UseBiasedLocking) { + return; + } + GrowableArray* objects_to_revoke = new GrowableArray(); + get_monitors_from_stack(objects_to_revoke, thread, fr, map); + + int len = objects_to_revoke->length(); + for (int i = 0; i < len; i++) { + oop obj = (objects_to_revoke->at(i))(); + BiasedLocking::revoke_own_locks_in_handshake(objects_to_revoke->at(i), thread); + assert(!obj->mark()->has_bias_pattern(), "biases should be revoked by now"); + } +} + void Deoptimization::deoptimize_single_frame(JavaThread* thread, frame fr, Deoptimization::DeoptReason reason) { assert(fr.can_be_deoptimized(), "checking frame type"); @@ -1464,11 +1505,16 @@ fr.deoptimize(thread); } -void Deoptimization::deoptimize(JavaThread* thread, frame fr, RegisterMap *map) { - deoptimize(thread, fr, map, Reason_constraint); +void Deoptimization::deoptimize(JavaThread* thread, frame fr, RegisterMap *map, bool in_handshake) { + deopt_thread(in_handshake, thread, fr, map, Reason_constraint); } void Deoptimization::deoptimize(JavaThread* thread, frame fr, RegisterMap *map, DeoptReason reason) { + deopt_thread(false, thread, fr, map, reason); +} + +void Deoptimization::deopt_thread(bool in_handshake, JavaThread* thread, + frame fr, RegisterMap *map, DeoptReason reason) { // Deoptimize only if the frame comes from compile code. // Do not deoptimize the frame which is already patched // during the execution of the loops below. @@ -1478,7 +1524,11 @@ ResourceMark rm; DeoptimizationMarker dm; if (UseBiasedLocking) { - revoke_biases_of_monitors(thread, fr, map); + if (in_handshake) { + revoke_using_handshake(thread, fr, map); + } else { + revoke_using_safepoint(thread, fr, map); + } } deoptimize_single_frame(thread, fr, reason);