Code Review for langtools

Prepared by:rfield on Tue Jul 12 22:47:01 PDT 2016
Workspace:/w/x/dev/langtools
Compare against: http://hg.openjdk.java.net/jdk9/dev/langtools
Summary of changes: 5489 lines changed: 3092 ins; 2252 del; 145 mod; 7048 unchg
Patch of changes: langtools.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/internal/jshell/debug/InternalDebugControl.java

6 lines changed: 5 ins; 0 del; 1 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java

7 lines changed: 5 ins; 0 del; 2 mod; 2561 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/Eval.java

32 lines changed: 21 ins; 0 del; 11 mod; 826 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/JShell.java

72 lines changed: 27 ins; 24 del; 21 mod; 799 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/TaskFactory.java

3 lines changed: 0 ins; 1 del; 2 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/Unit.java

42 lines changed: 19 ins; 2 del; 21 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/spi/ExecutionControl.java

240 lines changed: 155 ins; 41 del; 44 mod; 69 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/spi/ExecutionEnv.java

45 lines changed: 1 ins; 43 del; 1 mod; 83 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/spi/SPIResolutionException.java

5 lines changed: 0 ins; 5 del; 0 mod; 64 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/spi/package-info.java

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/ComputeFQNsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/FailOverExecutionControlTest.java

55 lines changed: 1 ins; 44 del; 10 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/JDIListeningExecutionControlTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/KullaTesting.java

5 lines changed: 0 ins; 5 del; 0 mod; 1185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/UserExecutionControlTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/ClassTracker.java (was src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/ClassTracker.java)

61 lines changed: 20 ins; 19 del; 22 mod; 89 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/DemultiplexInput.java

110 lines changed: 110 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/DirectExecutionControl.java

264 lines changed: 264 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/ECLogger.java

49 lines changed: 49 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/ExecutionControlForwarder.java

211 lines changed: 211 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JDIDefaultExecutionControl.java

256 lines changed: 256 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JDIEventHandler.java

139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JDIExecutionControl.java

105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JDIInitiator.java

200 lines changed: 200 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JShellECLogger.java

57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/LocalExecutionControl.java

148 lines changed: 148 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/MultiplexingOutputStream.java

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/PipeInputStream.java

88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/RemoteClassLoader.java

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/RemoteCommand.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/RemoteExecutionControl.java

133 lines changed: 133 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/RemoteStatus.java

66 lines changed: 66 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/StreamingExecutionControl.java

291 lines changed: 291 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/Util.java

217 lines changed: 217 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/jshell/UserJDIUserRemoteTest.java

281 lines changed: 281 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/FailOverExecutionControl.java

119 lines changed: 0 ins; 119 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/JDIConnection.java

346 lines changed: 0 ins; 346 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/JDIEventHandler.java

182 lines changed: 0 ins; 182 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/JDIExecutionControl.java

598 lines changed: 0 ins; 598 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/JDINotConnectedException.java

43 lines changed: 0 ins; 43 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/remote/RemoteAgent.java

326 lines changed: 0 ins; 326 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/remote/RemoteClassLoader.java

64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/remote/RemoteCodes.java

47 lines changed: 0 ins; 47 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/jshell/execution/Internal.java

30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/jshell/LocalExecutionControl.java

313 lines changed: 0 ins; 313 del; 0 mod; 0 unchg

This code review page was prepared using /home/robert/apps/webrev/webrev.ksh (vers 25.2-hg+openjdk.java.net).