Code Review for langtools

Prepared by:rfield on Fri Jul 15 00:13:54 PDT 2016
Workspace:/w/x/dev/langtools
Compare against: http://hg.openjdk.java.net/jdk9/dev/langtools
Summary of changes: 5390 lines changed: 3018 ins; 2205 del; 167 mod; 7073 unchg
Patch of changes: langtools.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/internal/jshell/debug/InternalDebugControl.java

6 lines changed: 5 ins; 0 del; 1 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/internal/jshell/tool/JShellTool.java

7 lines changed: 5 ins; 0 del; 2 mod; 2561 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/Eval.java

35 lines changed: 24 ins; 0 del; 11 mod; 826 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/JShell.java

77 lines changed: 27 ins; 29 del; 21 mod; 794 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/TaskFactory.java

3 lines changed: 0 ins; 1 del; 2 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/Unit.java

45 lines changed: 22 ins; 2 del; 21 mod; 477 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/spi/ExecutionControl.java

251 lines changed: 170 ins; 31 del; 50 mod; 73 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/spi/ExecutionEnv.java

50 lines changed: 1 ins; 48 del; 1 mod; 78 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/spi/SPIResolutionException.java

7 lines changed: 0 ins; 5 del; 2 mod; 62 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/spi/package-info.java

2 lines changed: 0 ins; 0 del; 2 mod; 37 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/ComputeFQNsTest.java

1 line changed: 0 ins; 0 del; 1 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/FailOverExecutionControlTest.java

55 lines changed: 1 ins; 44 del; 10 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/JDIListeningExecutionControlTest.java

4 lines changed: 0 ins; 0 del; 4 mod; 42 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/KullaTesting.java

5 lines changed: 0 ins; 5 del; 0 mod; 1185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/jshell/UserExecutionControlTest.java

4 lines changed: 1 ins; 0 del; 3 mod; 50 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/ClassTracker.java (was src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/ClassTracker.java)

61 lines changed: 20 ins; 19 del; 22 mod; 89 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/DemultiplexInput.java

109 lines changed: 109 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/DirectExecutionControl.java

276 lines changed: 276 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/ExecutionControlForwarder.java

229 lines changed: 229 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JDIDefaultExecutionControl.java

278 lines changed: 278 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JDIEventHandler.java

139 lines changed: 139 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JDIExecutionControl.java

104 lines changed: 104 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/JDIInitiator.java

218 lines changed: 218 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/LocalExecutionControl.java

148 lines changed: 148 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/MultiplexingOutputStream.java

91 lines changed: 91 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/PipeInputStream.java

88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/RemoteClassLoader.java

65 lines changed: 65 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/RemoteCodes.java (was src/jdk.jshell/share/classes/jdk/internal/jshell/remote/RemoteCodes.java)

79 lines changed: 65 ins; 0 del; 14 mod; 33 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/RemoteExecutionControl.java

144 lines changed: 144 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/StreamingExecutionControl.java

324 lines changed: 324 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/jdk.jshell/share/classes/jdk/jshell/execution/Util.java

189 lines changed: 189 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw test/jdk/jshell/UserJDIUserRemoteTest.java

275 lines changed: 275 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/FailOverExecutionControl.java

119 lines changed: 0 ins; 119 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/JDIConnection.java

346 lines changed: 0 ins; 346 del; 0 mod; -1 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/JDIEventHandler.java

182 lines changed: 0 ins; 182 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/JDIExecutionControl.java

598 lines changed: 0 ins; 598 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/jdi/JDINotConnectedException.java

43 lines changed: 0 ins; 43 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/remote/RemoteAgent.java

326 lines changed: 0 ins; 326 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/internal/jshell/remote/RemoteClassLoader.java

64 lines changed: 0 ins; 64 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- src/jdk.jshell/share/classes/jdk/jshell/execution/Internal.java

30 lines changed: 0 ins; 30 del; 0 mod; 0 unchg

------ ------ ------ ------ Old --- Patch --- test/jdk/jshell/LocalExecutionControl.java

313 lines changed: 0 ins; 313 del; 0 mod; 0 unchg

This code review page was prepared using /home/robert/apps/webrev/webrev.ksh (vers 25.2-hg+openjdk.java.net).