Code Review for jdk-hs

Prepared by:rkennke on Mon Nov 20 16:28:50 CET 2017
Workspace:/home/rkennke/src/openjdk/jdk-hs
Compare against: ssh://hg.openjdk.java.net/jdk/hs/
Compare against version:47863
Summary of changes: 1119 lines changed: 607 ins; 494 del; 18 mod; 11458 unchg
Patch of changes: jdk-hs.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsHeap.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
5 lines changed: 5 ins; 0 del; 0 mod; 185 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/cms/cmsHeap.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
2 lines changed: 2 ins; 0 del; 0 mod; 115 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
5 lines changed: 5 ins; 0 del; 0 mod; 5396 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1CollectedHeap.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
2 lines changed: 2 ins; 0 del; 0 mod; 1543 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
5 lines changed: 5 ins; 0 del; 0 mod; 676 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 2 ins; 0 del; 1 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/serialHeap.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
5 lines changed: 5 ins; 0 del; 0 mod; 35 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/serial/serialHeap.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
4 lines changed: 3 ins; 1 del; 0 mod; 57 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
9 lines changed: 9 ins; 0 del; 0 mod; 611 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/shared/collectedHeap.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
7 lines changed: 7 ins; 0 del; 0 mod; 680 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryManager.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
32 lines changed: 0 ins; 32 del; 0 mod; 299 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryManager.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
76 lines changed: 0 ins; 75 del; 1 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryPool.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
26 lines changed: 0 ins; 26 del; 0 mod; 288 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryPool.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
17 lines changed: 0 ins; 16 del; 1 mod; 215 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryService.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
305 lines changed: 0 ins; 295 del; 10 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/services/memoryService.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
46 lines changed: 0 ins; 45 del; 1 mod; 174 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/cms/cmsGCServicabilitySupport.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
105 lines changed: 105 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/cms/cmsGCServicabilitySupport.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1GCServicabilitySupport.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
74 lines changed: 74 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/g1/g1GCServicabilitySupport.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MemoryPool.cpp (was src/hotspot/share/services/g1MemoryPool.cpp)

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 1 ins; 1 del; 1 mod; 87 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/g1/g1MemoryPool.hpp (was src/hotspot/share/services/g1MemoryPool.hpp)

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 0 ins; 2 del; 1 mod; 107 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/parallel/parallelGCServicabilitySupport.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
88 lines changed: 88 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/parallel/parallelGCServicabilitySupport.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psMemoryPool.cpp (was src/hotspot/share/services/psMemoryPool.cpp)

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
3 lines changed: 1 ins; 1 del; 1 mod; 95 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/hotspot/share/gc/parallel/psMemoryPool.hpp (was src/hotspot/share/services/psMemoryPool.hpp)

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
1 line changed: 0 ins; 0 del; 1 mod; 96 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/serial/serialGCServicabilitySupport.cpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
86 lines changed: 86 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/serial/serialGCServicabilitySupport.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
41 lines changed: 41 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/hotspot/share/gc/shared/gcServicabilitySupport.hpp

rev 47864 : 8191564: Refactor GC related servicability code into GC specific subclasses
43 lines changed: 43 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/rkennke/src/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).