Code Review for jdk

Prepared by: Roman Kennke (roman) on Fr 7. Aug 10:52:25 CEST 2009
Workspace:/home/roman/src/hg/openjdk/openjdk-2d/jdk
Compare against: ssh://rkennke@hg.openjdk.java.net/jdk7/2d/jdk
Compare against version:1378
Summary of changes: 13105 lines changed: 6431 ins; 5693 del; 981 mod; 55351 unchg
Patch of changes: jdk.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/sun/awt/FILES_export_windows.gmk

rev 1379 : [mq]: fontmanager.patch
250 lines changed: 1 ins; 0 del; 249 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/sun/awt/make.depend

rev 1379 : [mq]: fontmanager.patch
351 lines changed: 0 ins; 0 del; 351 mod; 0 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/sun/awt/mapfile-mawt-vers

rev 1379 : [mq]: fontmanager.patch
5 lines changed: 0 ins; 0 del; 5 mod; 518 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/sun/awt/mapfile-vers-linux

rev 1379 : [mq]: fontmanager.patch
5 lines changed: 0 ins; 0 del; 5 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/sun/font/mapfile-vers

rev 1379 : [mq]: fontmanager.patch
6 lines changed: 0 ins; 4 del; 2 mod; 60 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/sun/font/mapfile-vers.openjdk

rev 1379 : [mq]: fontmanager.patch
6 lines changed: 0 ins; 4 del; 2 mod; 79 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/sun/headless/mapfile-vers

rev 1379 : [mq]: fontmanager.patch
6 lines changed: 0 ins; 0 del; 6 mod; 102 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw make/sun/xawt/mapfile-vers

rev 1379 : [mq]: fontmanager.patch
6 lines changed: 0 ins; 0 del; 6 mod; 416 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/gtk/PangoFonts.java

6 lines changed: 2 ins; 0 del; 4 mod; 227 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java

rev 1379 : [mq]: fontmanager.patch
4 lines changed: 1 ins; 0 del; 3 mod; 2674 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/awt/Component.java

rev 1379 : [mq]: fontmanager.patch
9 lines changed: 7 ins; 0 del; 2 mod; 9842 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/awt/Font.java

rev 1379 : [mq]: fontmanager.patch
40 lines changed: 24 ins; 5 del; 11 mod; 2576 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/java/awt/GraphicsEnvironment.java

rev 1379 : [mq]: fontmanager.patch
13 lines changed: 4 ins; 4 del; 5 mod; 443 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/plaf/nimbus/Defaults.template

rev 1379 : [mq]: fontmanager.patch
2 lines changed: 0 ins; 0 del; 2 mod; 876 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/javax/swing/text/StyleContext.java

rev 1379 : [mq]: fontmanager.patch
3 lines changed: 0 ins; 0 del; 3 mod; 1618 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/awt/FontConfiguration.java

rev 1379 : [mq]: fontmanager.patch
24 lines changed: 3 ins; 1 del; 20 mod; 2246 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/CMap.java

rev 1379 : [mq]: fontmanager.patch
3 lines changed: 0 ins; 0 del; 3 mod; 1062 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/CompositeFont.java

rev 1379 : [mq]: fontmanager.patch
18 lines changed: 2 ins; 1 del; 15 mod; 442 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/CompositeGlyphMapper.java

rev 1379 : [mq]: fontmanager.patch
2 lines changed: 0 ins; 0 del; 2 mod; 271 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FileFont.java

rev 1379 : [mq]: fontmanager.patch
12 lines changed: 2 ins; 0 del; 10 mod; 277 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FileFontStrike.java

rev 1379 : [mq]: fontmanager.patch
11 lines changed: 0 ins; 0 del; 11 mod; 877 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FontDesignMetrics.java

rev 1379 : [mq]: fontmanager.patch
6 lines changed: 1 ins; 0 del; 5 mod; 584 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FontFamily.java

rev 1379 : [mq]: fontmanager.patch
3 lines changed: 1 ins; 0 del; 2 mod; 294 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FontManager.java

rev 1379 : [mq]: fontmanager.patch
3798 lines changed: 0 ins; 3707 del; 91 mod; 54 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FontManagerNativeLibrary.java

rev 1379 : [mq]: fontmanager.patch
1 line changed: 0 ins; 0 del; 1 mod; 76 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FontResolver.java

rev 1379 : [mq]: fontmanager.patch
1 line changed: 0 ins; 0 del; 1 mod; 245 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FontScaler.java

rev 1379 : [mq]: fontmanager.patch
76 lines changed: 76 ins; 0 del; 0 mod; 180 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/FreetypeFontScaler.java

rev 1379 : [mq]: fontmanager.patch
17 lines changed: 5 ins; 0 del; 12 mod; 244 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/GlyphLayout.java

rev 1379 : [mq]: fontmanager.patch
2 lines changed: 0 ins; 0 del; 2 mod; 666 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/PhysicalStrike.java

rev 1379 : [mq]: fontmanager.patch
9 lines changed: 8 ins; 0 del; 1 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/StandardGlyphVector.java

rev 1379 : [mq]: fontmanager.patch
2 lines changed: 0 ins; 0 del; 2 mod; 1915 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/StrikeCache.java

rev 1379 : [mq]: fontmanager.patch
5 lines changed: 4 ins; 0 del; 1 mod; 354 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/TrueTypeFont.java

rev 1379 : [mq]: fontmanager.patch
270 lines changed: 243 ins; 0 del; 27 mod; 1417 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/TrueTypeGlyphMapper.java

rev 1379 : [mq]: fontmanager.patch
9 lines changed: 0 ins; 0 del; 9 mod; 260 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/Type1Font.java

rev 1379 : [mq]: fontmanager.patch
5 lines changed: 0 ins; 1 del; 4 mod; 678 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/font/Type1GlyphMapper.java

rev 1379 : [mq]: fontmanager.patch
7 lines changed: 0 ins; 0 del; 7 mod; 170 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/java2d/SunGraphics2D.java

rev 1379 : [mq]: fontmanager.patch
4 lines changed: 2 ins; 0 del; 2 mod; 3306 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/java2d/SunGraphicsEnvironment.java

rev 1379 : [mq]: fontmanager.patch
1054 lines changed: 19 ins; 1027 del; 8 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/print/PSPrinterJob.java

rev 1379 : [mq]: fontmanager.patch
3 lines changed: 2 ins; 0 del; 1 mod; 2210 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/print/PathGraphics.java

rev 1379 : [mq]: fontmanager.patch
4 lines changed: 2 ins; 0 del; 2 mod; 1892 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/classes/sun/swing/SwingUtilities2.java

rev 1379 : [mq]: fontmanager.patch
2 lines changed: 0 ins; 0 del; 2 mod; 1845 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/native/sun/font/sunFont.c

rev 1379 : [mq]: fontmanager.patch
63 lines changed: 0 ins; 61 del; 2 mod; 336 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/native/sun/font/sunfontids.h

rev 1379 : [mq]: fontmanager.patch
5 lines changed: 0 ins; 5 del; 0 mod; 93 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/awt/X11/XToolkit.java

rev 1379 : [mq]: fontmanager.patch
4 lines changed: 3 ins; 0 del; 1 mod; 2471 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/awt/X11GraphicsEnvironment.java

rev 1379 : [mq]: fontmanager.patch
722 lines changed: 0 ins; 722 del; 0 mod; 400 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/awt/motif/MFontConfiguration.java

rev 1379 : [mq]: fontmanager.patch
15 lines changed: 5 ins; 0 del; 10 mod; 398 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/awt/motif/MToolkit.java

rev 1379 : [mq]: fontmanager.patch
2 lines changed: 1 ins; 0 del; 1 mod; 854 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/font/FcFontConfiguration.java

rev 1379 : [mq]: fontmanager.patch
32 lines changed: 11 ins; 0 del; 21 mod; 497 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/font/NativeFont.java

rev 1379 : [mq]: fontmanager.patch
6 lines changed: 3 ins; 0 del; 3 mod; 389 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/classes/sun/font/NativeStrike.java

rev 1379 : [mq]: fontmanager.patch
6 lines changed: 1 ins; 0 del; 5 mod; 373 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/solaris/native/sun/awt/fontpath.c

rev 1379 : [mq]: fontmanager.patch
49 lines changed: 16 ins; 20 del; 13 mod; 1301 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/classes/sun/awt/Win32GraphicsEnvironment.java

rev 1379 : [mq]: fontmanager.patch
131 lines changed: 7 ins; 122 del; 2 mod; 284 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/classes/sun/awt/windows/WFontConfiguration.java

rev 1379 : [mq]: fontmanager.patch
6 lines changed: 2 ins; 0 del; 4 mod; 240 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/classes/sun/awt/windows/WPathGraphics.java

rev 1379 : [mq]: fontmanager.patch
14 lines changed: 7 ins; 0 del; 7 mod; 1691 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/classes/sun/awt/windows/WPrinterJob.java

rev 1379 : [mq]: fontmanager.patch
3 lines changed: 2 ins; 0 del; 1 mod; 1991 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/classes/sun/awt/windows/WToolkit.java

rev 1379 : [mq]: fontmanager.patch
8 lines changed: 6 ins; 0 del; 2 mod; 1022 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/native/sun/font/fontpath.c

rev 1379 : [mq]: fontmanager.patch
12 lines changed: 0 ins; 9 del; 3 mod; 692 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp

rev 1379 : [mq]: fontmanager.patch
10 lines changed: 1 ins; 0 del; 9 mod; 329 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/sun/font/FontAccess.java

48 lines changed: 48 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/sun/font/FontManagerFactory.java

rev 1379 : [mq]: fontmanager.patch
106 lines changed: 106 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/sun/font/FontManagerForSGE.java

rev 1379 : [mq]: fontmanager.patch
57 lines changed: 57 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/sun/font/FontUtilities.java

486 lines changed: 486 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/share/classes/sun/font/SunFontManager.java

rev 1379 : [mq]: fontmanager.patch
3675 lines changed: 3675 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/solaris/classes/sun/awt/X11FontManager.java

850 lines changed: 850 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/solaris/classes/sun/font/FontConfigManager.java

455 lines changed: 455 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ --- New Patch Raw src/windows/classes/sun/awt/Win32FontManager.java

rev 1379 : [mq]: fontmanager.patch
280 lines changed: 280 ins; 0 del; 0 mod; 0 unchg

This code review page was prepared using /home/roman/install/bin/webrev (vers 23.10-hg).