Code Review for hotspot

Prepared by:roland on Thu Dec 8 10:58:36 CET 2016
Workspace:/home/rwestrel/valhalla/hotspot
Compare against: ssh://hg.openjdk.java.net/valhalla/valhalla/hotspot
Compare against version:10510
Summary of changes: 1334 lines changed: 1015 ins; 142 del; 177 mod; 56615 unchg
Patch of changes: hotspot.patch
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/cpu/x86/vm/sharedRuntime_x86_64.cpp

rev 10511 : value type calling convention
rev 10512 : more
rev 10513 : reviews
rev 10514 : more reviews
484 lines changed: 313 ins; 132 del; 39 mod; 3675 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciValueKlass.cpp

rev 10513 : reviews
16 lines changed: 16 ins; 0 del; 0 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/ci/ciValueKlass.hpp

rev 10513 : reviews
2 lines changed: 2 ins; 0 del; 0 mod; 59 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/codeBlob.cpp

rev 10511 : value type calling convention
8 lines changed: 4 ins; 0 del; 4 mod; 572 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/code/codeBlob.hpp

rev 10511 : value type calling convention
8 lines changed: 6 ins; 0 del; 2 mod; 550 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/interpreter/linkResolver.cpp

rev 10511 : value type calling convention
1 line changed: 0 ins; 0 del; 1 mod; 1662 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/arraycopynode.hpp

rev 10511 : value type calling convention
rev 10513 : reviews
0 lines changed: 0 ins; 0 del; 0 mod; 173 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/buildOopMap.cpp

rev 10511 : value type calling convention
2 lines changed: 0 ins; 0 del; 2 mod; 674 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/callGenerator.cpp

rev 10511 : value type calling convention
rev 10512 : more
10 lines changed: 6 ins; 0 del; 4 mod; 1358 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/callnode.cpp

rev 10511 : value type calling convention
3 lines changed: 0 ins; 0 del; 3 mod; 2047 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/callnode.hpp

rev 10511 : value type calling convention
rev 10513 : reviews
2 lines changed: 0 ins; 0 del; 2 mod; 1126 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/chaitin.cpp

rev 10511 : value type calling convention
1 line changed: 0 ins; 0 del; 1 mod; 2408 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/compile.cpp

rev 10493 : keep
rev 10511 : value type calling convention
rev 10513 : reviews
1 line changed: 0 ins; 0 del; 1 mod; 4524 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/doCall.cpp

rev 10511 : value type calling convention
5 lines changed: 2 ins; 2 del; 1 mod; 1168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/escape.cpp

rev 10511 : value type calling convention
10 lines changed: 5 ins; 0 del; 5 mod; 3512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/generateOptoStub.cpp

rev 10511 : value type calling convention
rev 10513 : reviews
1 line changed: 0 ins; 0 del; 1 mod; 312 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/graphKit.cpp

rev 10511 : value type calling convention
rev 10512 : more
22 lines changed: 13 ins; 1 del; 8 mod; 4508 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/machnode.cpp

rev 10511 : value type calling convention
2 lines changed: 0 ins; 0 del; 2 mod; 822 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/macro.cpp

rev 10511 : value type calling convention
2 lines changed: 0 ins; 0 del; 2 mod; 2766 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/macroArrayCopy.cpp

rev 10511 : value type calling convention
1 line changed: 0 ins; 0 del; 1 mod; 1258 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/matcher.cpp

rev 10511 : value type calling convention
8 lines changed: 2 ins; 0 del; 6 mod; 2686 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/parse1.cpp

rev 10494 : more
rev 10496 : more
rev 10511 : value type calling convention
rev 10512 : more
rev 10513 : reviews
91 lines changed: 73 ins; 0 del; 18 mod; 2402 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/runtime.cpp

rev 10511 : value type calling convention
rev 10513 : reviews
5 lines changed: 0 ins; 0 del; 5 mod; 1671 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/type.cpp

rev 10511 : value type calling convention
rev 10512 : more
rev 10513 : reviews
77 lines changed: 59 ins; 1 del; 17 mod; 5481 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/type.hpp

rev 10511 : value type calling convention
rev 10513 : reviews
13 lines changed: 9 ins; 0 del; 4 mod; 1901 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/valuetypenode.cpp

rev 10493 : keep
rev 10496 : more
rev 10497 : embedded vt
rev 10511 : value type calling convention
rev 10513 : reviews
39 lines changed: 38 ins; 0 del; 1 mod; 350 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/opto/valuetypenode.hpp

rev 10493 : keep
rev 10494 : more
rev 10496 : more
rev 10511 : value type calling convention
2 lines changed: 0 ins; 0 del; 2 mod; 94 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/globals.hpp

rev 10511 : value type calling convention
rev 10513 : reviews
4 lines changed: 2 ins; 0 del; 2 mod; 4278 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sharedRuntime.cpp

rev 10511 : value type calling convention
rev 10512 : more
rev 10513 : reviews
rev 10514 : more reviews
188 lines changed: 166 ins; 4 del; 18 mod; 3054 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/share/vm/runtime/sharedRuntime.hpp

rev 10511 : value type calling convention
rev 10512 : more
rev 10513 : reviews
rev 10514 : more reviews
50 lines changed: 44 ins; 2 del; 4 mod; 706 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/compiler/valhalla/valuetypes/ValueTypeTestBench.java

rev 10493 : keep
rev 10511 : value type calling convention
rev 10513 : reviews
276 lines changed: 255 ins; 0 del; 21 mod; 724 unchg

This code review page was prepared using /home/rwestrel/code-tools/webrev/webrev.ksh (vers 25.16-hg+openjdk.java.net).