Code Review for JDK-8252055

Prepared by: rriggs on Wed Aug 19 16:01:35 EDT 2020
Compare against: https://hg.openjdk.java.net/jdk/jdk
Compare against version: 7fdab308
Summary of changes: 460 lines changed; 34 ins; 271 del; 155 mod; 21858 unchg
Patch of changes: JDK-8252055.patch
Bug id: JDK-8252055
Legend: Modified file
Deleted file
New file

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/AbstractDrbg.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
13 lines changed; 0 ins; 13 del; 0 mod; 742 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/CtrDrbg.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
3 lines changed; 1 ins; 0 del; 2 mod; 529 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/HashDrbg.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
4 lines changed; 2 ins; 0 del; 2 mod; 285 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/HmacDrbg.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
3 lines changed; 1 ins; 0 del; 2 mod; 203 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/provider/certpath/RevocationChecker.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
3 lines changed; 1 ins; 1 del; 1 mod; 1175 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/SSLLogger.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
2 lines changed; 1 ins; 0 del; 1 mod; 595 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/ServerHello.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
4 lines changed; 1 ins; 1 del; 2 mod; 1512 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/ssl/Utilities.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
27 lines changed; 2 ins; 20 del; 5 mod; 207 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/tools/keytool/Main.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
39 lines changed; 1 ins; 33 del; 5 mod; 4804 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/Debug.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
11 lines changed; 1 ins; 9 del; 1 mod; 320 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
23 lines changed; 0 ins; 21 del; 2 mod; 211 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
28 lines changed; 1 ins; 20 del; 7 mod; 809 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/AVA.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
49 lines changed; 3 ins; 33 del; 13 mod; 1267 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw src/java.base/share/classes/sun/security/x509/X509CertImpl.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
17 lines changed; 0 ins; 16 del; 1 mod; 1968 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/ChaCha20KAT.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
9 lines changed; 0 ins; 3 del; 6 mod; 486 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/ChaCha20KeyGeneratorTest.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
5 lines changed; 1 ins; 2 del; 2 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/ChaCha20NoReuse.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
12 lines changed; 0 ins; 5 del; 7 mod; 608 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/ChaCha20Poly1305ParamTest.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
12 lines changed; 0 ins; 5 del; 7 mod; 397 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/com/sun/crypto/provider/Cipher/ChaCha20/unittest/ChaCha20CipherUnitTest.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
6 lines changed; 1 ins; 1 del; 4 mod; 246 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/security/KeyAgreement/KeySizeTest.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
5 lines changed; 1 ins; 2 del; 2 mod; 232 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/java/security/KeyAgreement/NegativeTest.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
7 lines changed; 1 ins; 2 del; 4 mod; 400 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/javax/crypto/SecretKeyFactory/SecKeyFacSunJCEPrf.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
8 lines changed; 1 ins; 2 del; 5 mod; 67 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/SignatureDigestTruncate.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
11 lines changed; 1 ins; 4 del; 6 mod; 114 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/ed/EdDSAKeySize.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
4 lines changed; 2 ins; 0 del; 2 mod; 219 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/ed/EdDSANegativeTest.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
7 lines changed; 0 ins; 1 del; 6 mod; 291 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/ed/EdDSAParamSpec.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
6 lines changed; 0 ins; 0 del; 6 mod; 168 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/ed/EdDSATest.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
3 lines changed; 0 ins; 0 del; 3 mod; 353 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/ed/EdECKeyFormat.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
4 lines changed; 0 ins; 2 del; 2 mod; 138 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/ed/TestEdDSA.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
9 lines changed; 0 ins; 1 del; 8 mod; 571 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/ed/TestEdOps.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
15 lines changed; 3 ins; 3 del; 9 mod; 276 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/xec/TestXDH.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
11 lines changed; 1 ins; 0 del; 10 mod; 492 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/xec/TestXECOps.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
6 lines changed; 0 ins; 0 del; 6 mod; 130 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/xec/XECIterative.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
6 lines changed; 0 ins; 1 del; 5 mod; 133 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/ec/xec/XECKeyFormat.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
4 lines changed; 0 ins; 1 del; 3 mod; 141 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/krb5/RFC396xTest.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
20 lines changed; 1 ins; 17 del; 2 mod; 216 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/krb5/etype/KerberosAesSha2.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
6 lines changed; 1 ins; 4 del; 1 mod; 201 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/jdk/sun/security/util/math/TestIntegerModuloP.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
12 lines changed; 0 ins; 10 del; 2 mod; 375 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/Convert.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
24 lines changed; 1 ins; 22 del; 1 mod; 71 unchg

Cdiffs Udiffs Sdiffs Frames Old New Patch Raw test/lib/jdk/test/lib/Utils.java

c0c7bdb2: 8252055: Use java.util.Hex encoder and decoder in java.security  
22 lines changed; 4 ins; 16 del; 2 mod; 839 unchg

This code review page was prepared using webrev version 9f5bf30ef5c5e4333babc17285f6f2a1688443a3