< prev index next >
src/java.base/share/classes/com/sun/java/util/jar/pack/Package.java
Print this page
rev 52881 : 8214971: Replace use of string.equals("") with isEmpty()
Reviewed-by: jlaskey, prappo, lancea, dfuchs, redestad
*** 683,693 ****
public void maybeChooseFileName() {
if (thisClass == null) {
return; // do not choose yet
}
String canonName = canonicalFileName();
! if (file.nameString.equals("")) {
file.nameString = canonName;
}
if (file.nameString.equals(canonName)) {
// The file name is predictable. Transmit "".
file.name = getRefString("");
--- 683,693 ----
public void maybeChooseFileName() {
if (thisClass == null) {
return; // do not choose yet
}
String canonName = canonicalFileName();
! if (file.nameString.isEmpty()) {
file.nameString = canonName;
}
if (file.nameString.equals(canonName)) {
// The file name is predictable. Transmit "".
file.name = getRefString("");
*** 704,714 ****
return thisClass.stringValue() + ".class";
}
public java.io.File getFileName(java.io.File parent) {
String name = file.name.stringValue();
! if (name.equals(""))
name = canonicalFileName();
String fname = name.replace('/', java.io.File.separatorChar);
return new java.io.File(parent, fname);
}
public java.io.File getFileName() {
--- 704,714 ----
return thisClass.stringValue() + ".class";
}
public java.io.File getFileName(java.io.File parent) {
String name = file.name.stringValue();
! if (name.isEmpty())
name = canonicalFileName();
String fname = name.replace('/', java.io.File.separatorChar);
return new java.io.File(parent, fname);
}
public java.io.File getFileName() {
*** 777,787 ****
assert(stubClass != null);
return stubClass;
}
public boolean isTrivialClassStub() {
return isClassStub()
! && name.stringValue().equals("")
&& (modtime == NO_MODTIME || modtime == default_modtime)
&& (options &~ FO_IS_CLASS_STUB) == 0;
}
// The nameString is the key. Ignore other things.
--- 777,787 ----
assert(stubClass != null);
return stubClass;
}
public boolean isTrivialClassStub() {
return isClassStub()
! && name.stringValue().isEmpty()
&& (modtime == NO_MODTIME || modtime == default_modtime)
&& (options &~ FO_IS_CLASS_STUB) == 0;
}
// The nameString is the key. Ignore other things.
< prev index next >