< prev index next >

src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java

Print this page
rev 52881 : 8214971: Replace use of string.equals("") with isEmpty()
Reviewed-by: jlaskey, prappo, lancea, dfuchs, redestad


 184 
 185     private void collectHeaders1(StringBuilder sb,
 186                                  HttpHeaders headers,
 187                                  BiPredicate<String,String> filter) {
 188         for (Map.Entry<String,List<String>> entry : headers.map().entrySet()) {
 189             String key = entry.getKey();
 190             List<String> values = entry.getValue();
 191             for (String value : values) {
 192                 if (!filter.test(key, value))
 193                     continue;
 194                 sb.append(key).append(':').append(' ')
 195                         .append(value)
 196                         .append('\r').append('\n');
 197             }
 198         }
 199     }
 200 
 201     private String getPathAndQuery(URI uri) {
 202         String path = uri.getRawPath();
 203         String query = uri.getRawQuery();
 204         if (path == null || path.equals("")) {
 205             path = "/";
 206         }
 207         if (query == null) {
 208             query = "";
 209         }
 210         if (query.equals("")) {
 211             return Utils.encode(path);
 212         } else {
 213             return Utils.encode(path + "?" + query);
 214         }
 215     }
 216 
 217     private String authorityString(InetSocketAddress addr) {
 218         return addr.getHostString() + ":" + addr.getPort();
 219     }
 220 
 221     private String hostString() {
 222         URI uri = request.uri();
 223         int port = uri.getPort();
 224         String host = uri.getHost();
 225 
 226         boolean defaultPort;
 227         if (port == -1) {
 228             defaultPort = true;
 229         } else if (request.secure()) {
 230             defaultPort = port == 443;




 184 
 185     private void collectHeaders1(StringBuilder sb,
 186                                  HttpHeaders headers,
 187                                  BiPredicate<String,String> filter) {
 188         for (Map.Entry<String,List<String>> entry : headers.map().entrySet()) {
 189             String key = entry.getKey();
 190             List<String> values = entry.getValue();
 191             for (String value : values) {
 192                 if (!filter.test(key, value))
 193                     continue;
 194                 sb.append(key).append(':').append(' ')
 195                         .append(value)
 196                         .append('\r').append('\n');
 197             }
 198         }
 199     }
 200 
 201     private String getPathAndQuery(URI uri) {
 202         String path = uri.getRawPath();
 203         String query = uri.getRawQuery();
 204         if (path == null || path.isEmpty()) {
 205             path = "/";
 206         }
 207         if (query == null) {
 208             query = "";
 209         }
 210         if (query.isEmpty()) {
 211             return Utils.encode(path);
 212         } else {
 213             return Utils.encode(path + "?" + query);
 214         }
 215     }
 216 
 217     private String authorityString(InetSocketAddress addr) {
 218         return addr.getHostString() + ":" + addr.getPort();
 219     }
 220 
 221     private String hostString() {
 222         URI uri = request.uri();
 223         int port = uri.getPort();
 224         String host = uri.getHost();
 225 
 226         boolean defaultPort;
 227         if (port == -1) {
 228             defaultPort = true;
 229         } else if (request.secure()) {
 230             defaultPort = port == 443;


< prev index next >