--- old/src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java 2018-12-06 17:53:11.049468775 -0500 +++ new/src/java.management/share/classes/javax/management/modelmbean/DescriptorSupport.java 2018-12-06 17:53:10.881467942 -0500 @@ -443,7 +443,7 @@ init(null); for (int i=0; i < fields.length; i++) { - if ((fields[i] == null) || (fields[i].equals(""))) { + if ((fields[i] == null) || (fields[i].isEmpty())) { continue; } int eq_separator = fields[i].indexOf('='); @@ -467,7 +467,7 @@ fieldValue = fields[i].substring(eq_separator+1); } - if (fieldName.equals("")) { + if (fieldName.isEmpty()) { if (MODELMBEAN_LOGGER.isLoggable(Level.TRACE)) { MODELMBEAN_LOGGER.log(Level.TRACE, "Descriptor(String... fields) " + @@ -500,7 +500,7 @@ public synchronized Object getFieldValue(String fieldName) throws RuntimeOperationsException { - if ((fieldName == null) || (fieldName.equals(""))) { + if ((fieldName == null) || (fieldName.isEmpty())) { if (MODELMBEAN_LOGGER.isLoggable(Level.TRACE)) { MODELMBEAN_LOGGER.log(Level.TRACE, "Illegal arguments: null field name"); @@ -522,7 +522,7 @@ throws RuntimeOperationsException { // field name cannot be null or empty - if ((fieldName == null) || (fieldName.equals(""))) { + if ((fieldName == null) || (fieldName.isEmpty())) { if (MODELMBEAN_LOGGER.isLoggable(Level.TRACE)) { MODELMBEAN_LOGGER.log(Level.TRACE, "Illegal arguments: null or empty field name"); @@ -664,7 +664,7 @@ responseFields[i++] = value; } else { for (i=0; i < fieldNames.length; i++) { - if ((fieldNames[i] == null) || (fieldNames[i].equals(""))) { + if ((fieldNames[i] == null) || (fieldNames[i].isEmpty())) { responseFields[i] = null; } else { responseFields[i] = getFieldValue(fieldNames[i]); @@ -700,7 +700,7 @@ } for (int i=0; i < fieldNames.length; i++) { - if (( fieldNames[i] == null) || (fieldNames[i].equals(""))) { + if (( fieldNames[i] == null) || (fieldNames[i].isEmpty())) { if (MODELMBEAN_LOGGER.isLoggable(Level.TRACE)) { MODELMBEAN_LOGGER.log(Level.TRACE, "Null field name encountered at element " + i); @@ -733,7 +733,7 @@ } public synchronized void removeField(String fieldName) { - if ((fieldName == null) || (fieldName.equals(""))) { + if ((fieldName == null) || (fieldName.isEmpty())) { return; } @@ -862,7 +862,7 @@ String thisDescType = (String)(getFieldValue("descriptorType")); if ((thisName == null) || (thisDescType == null) || - (thisName.equals("")) || (thisDescType.equals(""))) { + (thisName.isEmpty()) || (thisDescType.isEmpty())) { return false; } @@ -912,7 +912,7 @@ private boolean validateField(String fldName, Object fldValue) { - if ((fldName == null) || (fldName.equals(""))) + if ((fldName == null) || (fldName.isEmpty())) return false; String SfldValue = ""; boolean isAString = false; @@ -931,7 +931,7 @@ fldName.equalsIgnoreCase("Class")) { if (fldValue == null || !isAString) return false; - if (nameOrDescriptorType && SfldValue.equals("")) + if (nameOrDescriptorType && SfldValue.isEmpty()) return false; return true; } else if (fldName.equalsIgnoreCase("visibility")) {